Bug 195979 - KDE loading progress bar disappears if you click the mouse
Summary: KDE loading progress bar disappears if you click the mouse
Status: RESOLVED FIXED
Alias: None
Product: ksplash
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Debian testing Unspecified
: NOR normal
Target Milestone: ---
Assignee: Lubos Lunak
URL:
Keywords:
: 209015 224677 232953 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-06-11 09:22 UTC by David
Modified: 2010-04-01 14:30 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
patch for kdebase/workspace/ksplash/simple/main.cpp (1.88 KB, patch)
2010-02-11 11:49 UTC, anton
Details
patch for kdebase/workspace/ksplash/ksplashx/splash.cpp (1.73 KB, patch)
2010-02-11 13:39 UTC, anton
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David 2009-06-11 09:22:08 UTC
Version:            (using KDE 4.2.4)
Installed from:    Debian testing/unstable Packages

Hi. When you log into KDE 4.2, it shows a splash screen with loading progress.

But, if you click anywhere on the screen with them mouse while KDE is loading, the loading progress is hidden.

Please keep the loading progress on top of the screen. And maybe make it mouse-draggable too (that would be a nice touch).
Comment 1 Marco Martin 2009-06-11 12:34:48 UTC
afaik is an intended behaviour for all splash screens
anyways, not plasma stuff for sure :)
Comment 2 Lubos Lunak 2009-06-11 15:18:53 UTC
That is a feature and it will not be removed.
Comment 3 David 2009-06-11 16:07:13 UTC
Do you mind explaining why it's a feature?

I don't understand why the progress display disappearing when you click anywhere (even on the progress itself) is an expected behavior.

This is a very minor issue. It's more of a polish thing. It was one of the first things I noticed when using KDE 4 for the first time. Small things like this add up give a worse impression of KDE.

David.
Comment 4 Lubos Lunak 2009-06-12 09:21:34 UTC
Because it is occassionally useful to hide the splashscreen and I really don't feel like making this configurable or spending any time on it. If you don't like it, just don't do it.
Comment 5 Dario Andres 2009-09-30 20:19:07 UTC
*** Bug 209015 has been marked as a duplicate of this bug. ***
Comment 6 Lubos Lunak 2010-01-29 12:53:34 UTC
*** Bug 224677 has been marked as a duplicate of this bug. ***
Comment 7 anton 2010-02-09 20:17:25 UTC
How about changing the hide-splash key from single mouse click to doubleclick or keyboard Esc key? I think this might be a reasonable compromise for both sides with no extra config options.

I have found a place in the code which seems to be responsible for that behavior - lines 535 and 582 in the splash.cpp file

http://websvn.kde.org/trunk/KDE/kdebase/workspace/ksplash/ksplashx/splash.cpp?view=markup

if I make a small patch which would change mouseclick event to keyboard Esc event, would it be accepted?
Comment 8 Hasan Ceylan 2010-02-09 20:45:37 UTC
I was not planning to reply but to value Anton's work, I decided to do so. I am sure Anton invested more time and effort that KSplash team in this particular, issue - I think.

One of the bad things in OSS, I cannot take statements "it will not change PERIOD". 

And when asked, 
1) "Because it is occassionally useful to hide the splashscreen" is not really helping.
2) "and I really don't feel like making this configurable or spending any time on it. If you don't like it, just don't do it." is even worse. 

I think the rather better approach would be "Why do you think yours is a better idea, I'll change if I'm convinced." And after all you are the boss!

The reason I participated in that bug is 
1) Have a resolution larger then 1024x768
2) Prepare a desktop based on NOT white  background
3) Click somewhere during KDE boot
4) You get an empty white 1024x768 box at the top left of screen before desktop has fully initialized

In response to the second part of comment #4, I know it, and I do not do it. The consequences of doing so for those who are not aware of this feature, makes the whole KDE Desktop look just not professional.

Last but not the least (being 20+ in development and 8+ years in OSS world) I perceived this one as "something slipped out of ksplash team's eyes" and do not remember seeing a splash screen goes away with a click.

Regards,
Hasan Ceylan
Comment 9 Lubos Lunak 2010-02-10 15:03:19 UTC
(In reply to comment #7)
> if I make a small patch which would change mouseclick event to keyboard Esc
> event, would it be accepted?

Keyboard presumably won't work since the splash doesn't have focus, but I have no problem with applying a patch changing the click to double-click. It would be great if the patch would include changing the simple splashscreen as well, the code is very similar.
Comment 10 anton 2010-02-11 11:49:33 UTC
Created attachment 40666 [details]
patch for kdebase/workspace/ksplash/simple/main.cpp

Patch for simple splash - splash is closed on double-click instead of single mouse press. main.cpp was taken from 4.4.0 tag, but think this patch can be applied to current trunk with no problems.

xlib does not support DoubleClick event natively, so it is recognized as 2 mouse presses with delay less than 200 milliseconds.
Comment 11 anton 2010-02-11 13:39:47 UTC
Created attachment 40674 [details]
patch for kdebase/workspace/ksplash/ksplashx/splash.cpp

Same patch for ksplashx splash version. 

I think it should work ok as the code is nearly identical to the simple splash version which works fine, but I was not able to test it on my opensuse 11.2 with kde 4.4.0 from factory. It does compile, but when I run it in this way:
./ksplashx ksplashx-suse

It shows "Cannot find description.txt file." error message and does not start.

At the same time, the ksplashx from system KDE package starts ok with same parameter, so I suppose ksplashx is patched in some way by opensuse team with changes which are not in kde svn.
Comment 12 Lubos Lunak 2010-02-15 16:53:14 UTC
I'm not aware of any current openSUSE patches for ksplashx. 'ksplashx ksplashx-suse --test' or 'ksplashx Default --test' work fine here. Anyway, thank you for the patches.
Comment 13 Lubos Lunak 2010-02-15 17:18:26 UTC
SVN commit 1090602 by lunakl:

Close the splash prematurely only on double-click, not a single click.
Patch by <benderamp@gmail.com>.
FEATURE: 195979



 M  +19 -2     ksplashx/splash.cpp  
 M  +19 -2     simple/main.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1090602
Comment 14 Dario Andres 2010-04-01 14:12:34 UTC
*** Bug 232953 has been marked as a duplicate of this bug. ***
Comment 15 Astazi 2010-04-01 14:30:26 UTC
This bug is still present in the 4.4.2 KDE release. (And yes, it's a bug. Things should not disappear when you click randomly on the screen. If it were a feature, it would have been a "Hide" button on the splash screen). 

Moreover, once the splash screen disappears after the click, the screen turns black, and then the desktop appears with more visual artifacts, instead of the neat fade-out/fade-in.