Bug 195711 - Desktop settings doesn't allow to choose the wallpaper twice
Summary: Desktop settings doesn't allow to choose the wallpaper twice
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Unmaintained
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Compiled Sources Unspecified
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-08 22:35 UTC by Einar Lielmanis
Modified: 2009-06-09 01:05 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Possible patch (696 bytes, application/octet-stream)
2009-06-08 22:36 UTC, Einar Lielmanis
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Einar Lielmanis 2009-06-08 22:35:16 UTC
Version:           svn:978887 (using Devel)
Installed from:    Compiled sources

1. open desktop settings
2. choose any wallpaper from the disk (using file chooser icon)
3. dislike the wallpaper
4. choose another wallpaper from the disk (again, using the file chooser icon)
5. observe that the wallpaper doesn't change, the image stays the same and the new file is ignored.

The problem lies in kdebase/workspace/plasma/wallpapers/image/image.cpp and lies in the fact that browse() which gets called on choosing the file removes the okClicked() signal from the dialog, which doesn't get reconnected on dialog reuse. See attached patch.
Comment 1 Einar Lielmanis 2009-06-08 22:36:23 UTC
Created attachment 34377 [details]
Possible patch

I don't know the reason for removing the signal in the first place.
Comment 2 Aaron J. Seigo 2009-06-09 01:05:12 UTC
thanks for the patch; http://reviewboard.kde.org is usually a better place for plasma patches ...
Comment 3 Aaron J. Seigo 2009-06-09 01:05:25 UTC
SVN commit 979110 by aseigo:

remove an errant disconnect; improve the readability while i'm in here with a better method name than "browse()"
BUG:195711


 M  +3 -3      image.cpp  
 M  +1 -1      image.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=979110