Bug 195555 - Add a new option to use a constant scrolling speed with Kenburns effect [patch]
Summary: Add a new option to use a constant scrolling speed with Kenburns effect [patch]
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Generic-Presentation (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-07 13:33 UTC by S. Burmeister
Modified: 2021-03-09 03:05 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.2.0
Sentry Crash Report:


Attachments
add option for constant speed of ken burns of presentation (6.75 KB, patch)
2021-03-02 23:36 UTC, Phuoc Khanh LE
Details

Note You need to log in before you can comment on or make changes to this bug.
Description S. Burmeister 2009-06-07 13:33:13 UTC
Version:           0.10 (using KDE 4.2.4)
OS:                Linux
Installed from:    SuSE RPMs

If one uses the ken burns effect for the slideshow one gets different scrolling speeds for landscape and portrait pictures. 

If there was an option to have a constant speed, digikam would calculate a longer time for portrait pictures and thus have a constant speed no matter what size the picture has.

I do not think it is necessary to have the exact same speed, i.e. if the pictures shown do not have the "normal" lenght-width ratios they would still have diffferent speeds.

Maybe adding a drop-down to select the ratio 4:3, 16:9 etc. would already be enough to fit most users' needs.
Comment 1 caulier.gilles 2021-02-21 05:56:57 UTC
Hi Le,

This Presentation tool entry sound like not to hard to implement as you start to know a little bit the plugin implementation now...

Please take a look to see what's possible to do as junior job.

Thanks in advance

Gilles
Comment 2 Phuoc Khanh LE 2021-03-02 23:36:49 UTC
Created attachment 136331 [details]
add option for constant speed of ken burns of presentation

This patch will add an of option to make speed of ken burns equal in every image. Speed is calculated by time between two times of "swap image". By this moment, this time is same by all images. So the speed of motion is proportional with height of image. 
The option "Ken Burns Same Speed" will adjust the speed by ratio between height and width. By using this option, the speed of motion is same for all images. This option is implemented in widget "advanced"
Comment 3 caulier.gilles 2021-03-09 03:05:30 UTC
Git commit 5534eb9de615d88a9ccc6280114e72ecb9c9b0f3 by Gilles Caulier.
Committed on 09/03/2021 at 03:02.
Pushed by cgilles into branch 'master'.

Apply patch #136331  for Phuoc Khanh Le to use the same visual Ken-Burns effects speed while playing Presentation on scrren.
FIXED-IN: 7.2.0

M  +1    -0    core/dplugins/generic/view/presentation/common/presentationcontainer.cpp
M  +1    -0    core/dplugins/generic/view/presentation/common/presentationcontainer.h
M  +2    -0    core/dplugins/generic/view/presentation/dialogs/presentation_advpage.cpp
M  +7    -0    core/dplugins/generic/view/presentation/dialogs/presentation_advpage.ui
M  +14   -4    core/dplugins/generic/view/presentation/opengl/presentationkb.cpp
M  +4    -0    core/dplugins/generic/view/presentation/opengl/presentationkb_p.h

https://invent.kde.org/graphics/digikam/commit/5534eb9de615d88a9ccc6280114e72ecb9c9b0f3