Bug 194979 - JJ: move auto-spellcheck suggestions to the top level right click menu
Summary: JJ: move auto-spellcheck suggestions to the top level right click menu
Status: RESOLVED FIXED
Alias: None
Product: kdelibs
Classification: Frameworks and Libraries
Component: kdeui (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords:
: 149989 163674 175941 202143 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-06-02 12:48 UTC by Benjamin
Modified: 2010-01-31 05:26 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin 2009-06-02 12:48:54 UTC 
Version:           4:4.2.2-1 (using KDE 4.2.2)
OS:                Linux
Installed from:    Debian testing/unstable Packages

In Kmail's composer when you right click a mispelt word with the auto-spellchecker active there is a separate submenu for suggested spellings. 

Because the suggested spellings are by far the most likely thing a user is looking for when they right click a misspelt word (it certainly is when I click one) it would be more efficient to reorganise the menus so the suggested spellings is at the top of the top level menu.
Comment 1 Christophe Marin 2009-08-20 21:31:27 UTC 
*** Bug 175941 has been marked as a duplicate of this bug. ***
Comment 2 Tom Chiverton 2009-08-21 21:47:31 UTC 
So, what's the status on this ?
Comment 3 Harsh J 2009-11-09 20:18:36 UTC 
I've written a patch for fixing this. You can monitor/review it here: http://reviewboard.kde.org/r/2097/
Comment 4 Benjamin 2009-11-09 20:48:50 UTC 
Its an improvement, but is not possible to move the Suggestions from a submenu to the root menu as well?
Comment 5 Harsh J 2009-11-10 10:04:04 UTC 
Wouldn't that make it too crowded/long? I mean, I don't know why it exists in the popup right now but there has to be a UI reason for it, perhaps. Where do I get this clarified?

I've updated the diff (r2) there with the top 'level' method as was requested - Its much like what OpenOffice.org does. Also added another screen-shot for the new patch.
Comment 6 Tom Chiverton 2009-11-10 12:48:13 UTC 
On suggestion would be to put the top N (10?) items into the first menu, with a 'more..' submenu for the rest. 
This is a familiar UI paradigm to users (look at what FireFox does, for instance), and accomplishes the twin goals of making the suggestions quicker and easier to get too and not crowding the menu too much.

Every time I have to correct a spelling at the moment in KDE4, I scream a little inside.
Comment 7 Harsh J 2009-11-11 14:18:47 UTC 
Hm, I failed to look at the suggestions-retriever earlier - looks like it only returns 10 items by default so no issues there! :)
Comment 8 Harsh J 2009-11-11 17:19:54 UTC 
Fixed. Committed patch to trunk.

See: http://websvn.kde.org/?view=rev&revision=1047622
Comment 9 Tom Chiverton 2009-11-11 17:53:41 UTC 
Is this a good candidate for going onto the existing 4.x branches too ?
Comment 10 Benjamin 2009-11-11 18:05:11 UTC 
Awesome, thank you so much! :)
Comment 11 Christoph Feck 2009-12-09 07:45:26 UTC 
*** Bug 163674 has been marked as a duplicate of this bug. ***
Comment 12 Christoph Feck 2010-01-31 05:26:07 UTC 
*** Bug 149989 has been marked as a duplicate of this bug. ***
Comment 13 Christoph Feck 2010-01-31 05:26:17 UTC 
*** Bug 202143 has been marked as a duplicate of this bug. ***