Bug 193894 - Pop up "Copy Finished!" dialogue when done downloading from camera
Summary: Pop up "Copy Finished!" dialogue when done downloading from camera
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: ProgressManager-Batch (show other bugs)
Version: 1.0.0
Platform: Ubuntu Unspecified
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-24 15:19 UTC by Dotan Cohen
Modified: 2022-02-05 15:56 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 1.0.0


Attachments
kate build plugin task bar notification (207.01 KB, image/png)
2009-05-26 08:54 UTC, caulier.gilles
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dotan Cohen 2009-05-24 15:19:52 UTC
Version:            (using KDE 4.2.3)
Installed from:    Ubuntu Packages

Please add an option for a "Copy Finished!" popup dialogue when Digikam is done downloading from camera. There is no intuitive way for the user to know that the download has completed.
Comment 1 caulier.gilles 2009-05-24 15:25:56 UTC
Instead a pop-up dialog, i thinking about a pop-up windows appears from the task bar, as K3b do write CD writting is done.

I think that camera gui must be embeded in task bar tray as K3b...

Marcel, Andi, Mathias ?

Gilles Caulier
Comment 2 Andi Clemens 2009-05-25 18:56:36 UTC
I don't quite understand what you mean. Can you give a screenshot or something like that?
Do you mean this little "progress bar window" that K3B produces? The one that is visible on all desktops?

Or do you mean a KDE4 notification?
Comment 3 caulier.gilles 2009-05-26 08:54:21 UTC
Created attachment 34013 [details]
kate build plugin task bar notification

Andi, 

Look on the bottom of this screen-shot for ex. It come from Kate build plugin which notify task bar with a simple pop-up tooltip when compilation is done.

Gilles
Comment 4 caulier.gilles 2009-05-26 09:08:38 UTC
Andi,

Look it's really easy to do:

http://lxr.kde.org/source/KDE/kdesdk/kate/plugins/katebuild-plugin/plugin_katebuild.cpp#406

Gilles
Comment 5 Andi Clemens 2009-05-26 09:15:21 UTC
Ok, but is this a normal KDE4 notification?
Because those will disappear after 2 or 3 seconds, at least on my system (I guess this is the default).
So when you go to get a cup of coffee and return, this box might already be gone again.
Anyway if it stays open, it might be a good idea. Although I would think that a popup dialog is more visible. A popup has a disadvantage though: You need to click "ok" or press enter.
This popup-tooltip could be automatically closed when the cameraUI is closed.

What about using the DTipTracker? Like I use for the renamewidget?
It can be closed when the cameraUI is gone?
Comment 6 Andi Clemens 2009-05-26 09:17:02 UTC
Yes, this is indeed easy :D
We could just implement it for testing purposes, I mean this is why there is a SVN version :)
If it is not suitable, we can revert the commit and think of something new.

Andi
Comment 7 caulier.gilles 2009-05-26 09:54:10 UTC
>Ok, but is this a normal KDE4 notification?

I'm not sure.

>Because those will disappear after 2 or 3 seconds, at least on my system (I
>guess this is the default).

yes, i see.

Also, if you reduce kate, pop-up will appear over task bar. It's suitable if user still on computer to work on other task during downloading

>So when you go to get a cup of coffee and return, this box might already be
>gone again.

yes

>Anyway if it stays open, it might be a good idea. Although I would think that a
>popup dialog is more visible. A popup has a disadvantage though: You need to
>click "ok" or press enter.

This is why i don't like it. 

To solve this point, a download log view need to be added. It's not very complex to do, and i remember a B.K.O file about this subject.

>This popup-tooltip could be automatically closed when the cameraUI is closed.

yes

>What about using the DTipTracker? Like I use for the renamewidget?
It can be closed when the cameraUI is gone?

yes, it's a good candidate.

Gilles
Comment 8 Andi Clemens 2009-05-26 10:11:38 UTC
Well, if you delete it in the destructor, it should be gone :-)
And I guess with the standard settings it is visible even when you change to another application.
I'm not sure if it will be visible on all desktops though.

Does this passive popdialog from kate disappear after some time?
I can not test it at the moment.
Comment 9 caulier.gilles 2009-05-26 15:43:39 UTC
SVN commit 973119 by cgilles:

pop-up passive windows under taskbar to bring user when all downloading operations are done.
BUGS: 193894


 M  +10 -1     cameraui.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=973119
Comment 10 caulier.gilles 2009-05-26 15:47:11 UTC
Andi, Implemented with commit #973119. 

And yes, it's KPassivePopUp diseapear after 3-4 secondes, but it's not really a problem now, because we have a download history view available under icon view :

http://farm4.static.flickr.com/3651/3565963705_725dc03f3a_o.png

Gilles Caulier
Comment 11 Andi Clemens 2009-05-26 15:53:01 UTC
Hmm but will the average user ever open this log view?
Isn't KPassivePopup deprecated somehow? Because this is why we have notifications in KDE4?

Andi
Comment 12 caulier.gilles 2009-05-26 17:28:02 UTC
>Hmm but will the average user ever open this log view?

Well it exist, and it simple to use. If something is wrong during download you can see what exactly.

>Isn't KPassivePopup deprecated somehow? Because this is why we have
>notifications in KDE4?

I don't know KDE4 notification stuff.

Why KPassivePopup is depreciate ?

I can see it in others KDE4 applications. It's simple, use just one line of code, and work very well under Windows.

Gilles
Comment 13 Dotan Cohen 2009-05-26 18:03:26 UTC
Although I personally prefer a real popup window, I understand that KDE 4 has it's own notification system that pops up from the system tray. I think that it is in Digikam's and KDE's interest to use the current KDE convention.
Comment 14 caulier.gilles 2009-05-26 18:14:47 UTC
Another arguments for KPassivePopup : it will work with Gnome or another non KDE desktop.

Gilles