Bug 193419 - When I click on an emoticon in the list, I have to press the enter key to add it. Clicking it does not work
Summary: When I click on an emoticon in the list, I have to press the enter key to add...
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Unmaintained
Component: Chat Window (other bugs)
Version First Reported In: 0.70.2
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-20 22:37 UTC by Ils Helsen
Modified: 2009-09-12 05:55 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Patch : change the signal connected (644 bytes, patch)
2009-05-22 05:18 UTC, Vincent Dupont 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Ils Helsen 2009-05-20 22:37:06 UTC 
Version:           0.70.2 (using 4.2.2 (KDE 4.2.2), Debian packages)
Compiler:          cc
OS:                Linux (x86_64) release 2.6.28-1-amd64

When I click on the "Smiley" button in the chat window to add an emoticon, I have to select it with the mouse and then press the Enter key to add it. Simply clicking it does not insert the emoticon.

Simply clicking the emoticon should add the emoticon to the message and close the list of available emoticons.

Regards,
Ils
Comment 1 Vincent Dupont 2009-05-22 05:18:35 UTC 
Created attachment 33912 [details]
Patch : change the signal connected 

The patch change just the signal connected to EmoticonSelector::emoticonClicked() , itemActivated() by itemClicked().
Comment 2 Vincent Dupont 2009-05-22 05:21:03 UTC 
Patch above applies to kopete/chatwindow/emoticonselector.cpp
Comment 3 Ils Helsen 2009-05-23 22:48:30 UTC 
I've tested the patch. Emoticons are now inserted when I click on them, but no longer when I select them with the arrow keys and press Enter. Both actions should insert the emoticon.
Comment 4 Matt Rogers 2009-09-12 05:51:54 UTC 
SVN commit 1022573 by mattr:

Fix bug 193419

Prevent the user from having to press the enter key to add an emoticon
when using the emoticon selector.

Patch by Vincent Dupont. Thanks!

This is the commit for KDE 4.4. The commit for the KDE 4.3 branch will
close the bug
CCBUG: 193419

 M  +1 -1      emoticonselector.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1022573
Comment 5 Matt Rogers 2009-09-12 05:55:50 UTC 
SVN commit 1022577 by mattr:

Fix bug 193419

Prevent the user from having to press the enter key to add an emoticon
when using the emoticon selector.

Patch by Vincent Dupont. Thanks!

This is the commit for KDE 4.3.
BUG: 193419

 M  +1 -1      emoticonselector.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1022577