Bug 192541 - Name based Flickr set selection is ambiguous [patch]
Summary: Name based Flickr set selection is ambiguous [patch]
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-WebService-Flickr (show other bugs)
Version: 5.6.0
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-13 09:03 UTC by Pieter Edelman
Modified: 2018-03-23 11:30 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 0.5.0
Sentry Crash Report:


Attachments
Use unique id instead of non-unique name for Flickr sets (1.45 KB, patch)
2009-05-13 09:06 UTC, Pieter Edelman
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pieter Edelman 2009-05-13 09:03:15 UTC
Version:           0.2.0 (using KDE 4.2.3)
OS:                Linux
Installed from:    Unspecified Linux

In the Flickr export plugin, the user is presented with a list of Flickr set names to select the set the uploaded photos should be added to. When processing the uploads, the plugin uses the set name as unique identifier to determine the id of the set, which is ultimately used in the request to the Flickr API.
However, a Flickr account can have multiple sets with the same name. When using a name based identifier, always the first set in the list with the given name is used instead of the actual selected set.
I've attached a patch to store the unique identifier of each set as userData in the QComboBox list together with the name. This should solve the issue.
Comment 1 Pieter Edelman 2009-05-13 09:06:15 UTC
Created attachment 33606 [details]
Use unique id instead of non-unique name for Flickr sets
Comment 2 James Vega 2009-06-06 11:48:14 UTC
This patch works correctly for me, but #180055 addresses this issue as part of a larger patch.  This bug should probably be closed in favor of #180055.
Comment 3 caulier.gilles 2009-06-06 11:53:31 UTC
Jain,

Look last comment #2 from Vega

Gilles Caulier
Comment 4 Vardhman 2009-06-06 13:24:06 UTC
The patch looks good, please go ahead and submit it!
Comment 5 caulier.gilles 2009-06-28 09:32:59 UTC
targeted to 0.5.0 release.
Comment 6 Nicolas L. 2009-07-05 03:52:30 UTC
SVN commit 991484 by nlecureuil:

Fix creation of photoset ( Patch from Pieter Edelman and enhanced by James Vega )
BUG:180055
BUG:192541
CCMAIL:vega.james@gmail.com
CCMAIL:p.edelman@gmx.net


 M  +2 -1      NEWS  
 M  +8 -57     flickrexport/flickralbumdialog.ui  
 M  +50 -25    flickrexport/flickrtalker.cpp  
 M  +6 -1      flickrexport/flickrtalker.h  
 M  +73 -23    flickrexport/flickrwindow.cpp  
 M  +2 -1      flickrexport/flickrwindow.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=991484