Bug 192500 - Regressions in interface What's This coverage & other missing strings
Summary: Regressions in interface What's This coverage & other missing strings
Status: RESOLVED FIXED
Alias: None
Product: konversation
Classification: Applications
Component: general (show other bugs)
Version: Git
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on:
Blocks: 187307
  Show dependency treegraph
 
Reported: 2009-05-12 23:28 UTC by Eike Hein
Modified: 2010-07-01 16:19 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Missing strings vs. the KDE 3 version. (16.59 KB, text/plain)
2009-05-12 23:28 UTC, Eike Hein
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Hein 2009-05-12 23:28:27 UTC
Created attachment 33597 [details]
Missing strings vs. the KDE 3 version.

During the porting to KDE 4, a whole bunch of strings (mostly "What's This" help tooltips) got lost. These need to be added back before we can move from /branches/work to /trunk/extragear to minimize issues with auto-merging existing translations from the KDE 3 version.

Attached is a list of all missing strings.
Comment 1 Pino Toscano 2009-05-13 23:18:02 UTC
SVN commit 967742 by pino:

- put back accelerators and buddies for labels, as they were in kde3's version
- remove extra markup
- put back some tooltips and whatsthis
- (correctly) fix few strings, also to match their kde3 equivalents

CCBUG: 192500


 M  +73 -29    identitydialog.ui  
 M  +4 -1      irc/serverlistdialogui.ui  


WebSVN link: http://websvn.kde.org/?view=rev&revision=967742
Comment 2 Pino Toscano 2009-05-13 23:37:03 UTC
SVN commit 967746 by pino:

re-add whatsthis

CCBUG: 192500


 M  +5 -1      servergroupdialogui.ui  


WebSVN link: http://websvn.kde.org/?view=rev&revision=967746
Comment 3 Pino Toscano 2009-05-13 23:53:43 UTC
SVN commit 967748 by pino:

set again the suffix for the inactivity time spinbox, doing the right thing if using kde 4.3

CCBUG: 192500


 M  +7 -0      identitydialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=967748
Comment 4 Pino Toscano 2009-05-17 02:06:33 UTC
All the messages that were untouched since KDE 3 were saved correctly to the KDE 4 version.
Comment 5 Pino Toscano 2010-07-01 16:19:18 UTC
commit 932a9f7b8c19b2a13892f05439ca71ac843cd766
Author: Pino Toscano <pino@kde.org>
Date:   Wed May 13 21:53:40 2009 +0000

    set again the suffix for the inactivity time spinbox, doing the right thing if using kde 4.3
    
    CCBUG: 192500
    
    svn path=/branches/work/konvi-kde4/; revision=967748

diff --git a/src/identitydialog.cpp b/src/identitydialog.cpp
index fbc0ac8..585887a 100644
--- a/src/identitydialog.cpp
+++ b/src/identitydialog.cpp
@@ -54,6 +54,13 @@ namespace Konversation
         // add encodings to combo box
         m_codecCBox->addItems(Konversation::IRCCharsets::self()->availableEncodingDescriptiveNames());
 
+        // set the suffix for the inactivity time spinbox
+#if KDE_IS_VERSION(4, 2, 80)
+        m_awayInactivitySpin->setSuffix(ki18np(" minute", " minutes"));
+#else
+        m_awayInactivitySpin->setSuffix(i18n(" minutes"));
+#endif
+
         // set values for the widgets
         updateIdentity(0);