Bug 191987 - Cannot change a custom contact list layout after creating it
Summary: Cannot change a custom contact list layout after creating it
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Unmaintained
Component: Contact list (other bugs)
Version First Reported In: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-08 03:09 UTC by Raphael Kubo da Costa
Modified: 2009-05-15 16:25 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa 2009-05-08 03:09:56 UTC
Version:            (using Devel)
OS:                Linux
Installed from:    Compiled sources

With the new contact list layout settings, if I change the default layout Kopete asks me for a name for the new layout.

After that, whenever I try to change it the Apply button is greyed out and clicking OK doesn't apply the changes I've made. Clicking Preview does apply the changes, but they aren't saved, so the next time I run Kopete the old layout is restored.
Comment 1 Roman Jarosz 2009-05-10 11:05:33 UTC
I cannot reproduce this, do you see anything in console if you run Kopete from there. Maybe screenshot would be helpfull too or exact steps (e.g. changed bold property, clicked apply ... and so on)
Comment 2 Roman Jarosz 2009-05-10 11:08:04 UTC
One more question do you see anything in ~/.kde/share/apps/kopete/contactlistlayouts there should be xml file with the new layout name, if no do you have permission to save the file?
Comment 3 Roman Jarosz 2009-05-10 12:32:52 UTC
SVN commit 966004 by rjarosz:

Show error messages when layout save/delete has failed.
Add layout fallback.

CCBUG: 191987



 M  +4 -4      config/appearance/appearanceconfig.cpp  
 M  +5 -3      config/appearance/contactlistlayoutwidget.cpp  
 M  +1 -1      config/appearance/contactlistlayoutwidget.h  
 M  +39 -15    contactlist/contactlistlayoutmanager.cpp  
 M  +2 -2      contactlist/contactlistlayoutmanager.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=966004
Comment 4 Raphael Kubo da Costa 2009-05-12 03:36:15 UTC
(In reply to comment #2)
> One more question do you see anything in
> ~/.kde/share/apps/kopete/contactlistlayouts there should be xml file with the
> new layout name, if no do you have permission to save the file?

Everything is OK in the directory: "My layout.xml" is present and writeable.

Currently, the problem only happens when I drag an item out of the layout.

Suppose I only have "Display Name" in my layout. If I drag "Contact Icons" to it, the Apply button becomes active and I can apply it to the layout. However, if I drag "Contact Icons" back to the item list, the Apply button becomes inactive again and I can't save this change. However, if I drag another item to my layout and remove it, the Apply button is kept active and I can save my change and have only "Display Name" again.
Comment 5 Roman Jarosz 2009-05-15 16:11:55 UTC
SVN commit 968339 by rjarosz:

Add second "Compact" contact list style.

CCBUG: 191987


 M  +1 -1      CMakeLists.txt  
 A             CompactContactListLayouts.xml  
 M  +1 -0      contactlistlayoutmanager.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=968339
Comment 6 Roman Jarosz 2009-05-15 16:25:38 UTC
SVN commit 968349 by rjarosz:

Sync with Amarok code.
Fixes bug when apply button isn't enabled when user moves token from layout.

BUG: 191987


 M  +1 -1      TokenDropTarget.cpp  
 M  +1 -1      TokenDropTarget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=968349