Bug 191908 - Quoted Text font size setting is broken
Summary: Quoted Text font size setting is broken
Status: RESOLVED FIXED
Alias: None
Product: kmail
Classification: Unmaintained
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Unspecified
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-07 14:44 UTC by Tristan Miller
Modified: 2009-06-18 00:06 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot showing bug (41.03 KB, image/png)
2009-05-07 14:54 UTC, Tristan Miller
Details
Patch for kdelibs to fix the bug (358 bytes, patch)
2009-06-15 20:54 UTC, Frank Niethardt
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tristan Miller 2009-05-07 14:44:53 UTC
Version:            (using KDE 4.2.2)
Installed from:    SuSE RPMs

In Configure KMail->Appearance->Fonts, the user can select a font style to apply to Quoted Text at the first, second, and third levels.  When the "Apply to:" drop-down box is set to one of these options, the "Font:" and "Size:" lists are greyed out, while the "Font style:" list and the "Size:" spinner are left active. (See attached screenshot.)

This does not make sense.  Why is the "Size:" spinner active while the "Size:" list is inactive?  Either the user should be able to set the font size here, or he should not be able to.  Both widgets should be greyed out, or both widgets should be active.

I suggest that both widgets should be active.  KMail recently introduced a setting to decrease the font size of quoted text (Appearance->Message Window->Use smaller font for quoted text); however, this setting does not allow the user to specify how much the text should be reduced.  On my system, for example, enabling this option causes quoted text to be reduced so much that it's not easy to read.  Why not get rid of this checkbox and simply allow the user to select the font size for quoted text in the Fonts tab?
Comment 1 Tristan Miller 2009-05-07 14:54:50 UTC
Created attachment 33435 [details]
Screenshot showing bug
Comment 2 Frank Niethardt 2009-06-15 20:35:54 UTC
This seems to be a bug in KFontChooser::enableColumn() - there you can disable column SizeList, what is done in AppearancePage::FontsTab::slotFontSelectorChanged().

But disabling column SizeList disables just sizeListBox and not size does not disable sizeOfFont...
Comment 3 Frank Niethardt 2009-06-15 20:54:00 UTC
Created attachment 34554 [details]
Patch for kdelibs to fix the bug
Comment 4 Jaime Torres 2009-06-16 14:04:00 UTC
Please, use http://reviewboard.kde.org or follow the steps in
http://techbase.kde.org/Contribute/Send_Patches.
As your patch is for kdelibs, it has to be reviewed and tested before it is applied.
Comment 5 Frank Niethardt 2009-06-17 23:53:34 UTC
Ok, I sent it, it is reviewed, marked "ship it" and I commited it in svn trunk. But I have no power to mark the bug RESOLVED...
Comment 6 Thomas McGuire 2009-06-18 00:06:10 UTC
Thanks, marking as resolved.