Bug 191394 - add "minimize all" action to window list plasmoid
Summary: add "minimize all" action to window list plasmoid
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Show Desktop/Minimize All (show other bugs)
Version: 5.8.4
Platform: Ubuntu Unspecified
: NOR wishlist
Target Milestone: 1.0
Assignee: Plasma Development Mailing List
URL:
Keywords:
: 238778 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-05-02 22:52 UTC by Aapo Rantalainen
Modified: 2022-03-01 17:08 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
minimizeall.cpp (273 bytes, text/x-c++src)
2009-06-14 12:41 UTC, Aapo Rantalainen
Details
cmakefile for minimizeall (388 bytes, text/plain)
2009-06-14 12:43 UTC, Aapo Rantalainen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aapo Rantalainen 2009-05-02 22:52:40 UTC
Version:            (using KDE 4.2.2)
Installed from:    Ubuntu Packages

KDE is using term "minimize all" wrong. "Minimize all" means all windows are minimized. And that it is.
No popping them visible again, it has name 'Show desktop'.

Now there are no way to do "minimize all".
Comment 1 George Goldberg 2009-06-13 13:48:14 UTC
Hi, can you please explain exactly where you are seeing this phrase "minimize all" used incorrectly? I mean, can you give me instructions on what to click so that I can see where it is appearing. Thanks.
Comment 2 Aapo Rantalainen 2009-06-13 14:36:52 UTC
Click 'plasma-bean' in upper right corner of desktop.

Add widget...

Select 'Show the Desktop'

Push 'Add Widget'

(It appears on desktop)

Move mouse over it and wait a second, tip will pop up saying:

"Show the Desktop
Minimize all open windows and show the Desktop"

----------------------------

If I click that, all windows are minimized but when I do anything they are returned back. This behaving is called 'show desktop', I need 'minimize all' functionality.
Comment 3 George Goldberg 2009-06-13 14:42:12 UTC
I can now see the problem you are mentioning. Reassigning the bug report to the relevant team.
Comment 4 George Goldberg 2009-06-13 14:42:31 UTC
...and reopening.
Comment 5 Aapo Rantalainen 2009-06-14 12:41:58 UTC
Created attachment 34517 [details]
minimizeall.cpp
Comment 6 Aapo Rantalainen 2009-06-14 12:43:06 UTC
Created attachment 34518 [details]
cmakefile for minimizeall
Comment 7 Aapo Rantalainen 2009-06-14 12:46:37 UTC
kwin is designed so that foreach-window-do-minimize is hard to implement. I tested many nuts and bolts way like XIconifyWindow (dd, wins[i], scr_screen); but no success.

But there are still easy way do MinimizeAll. This works on plasmoid too, but it is easier to show on standalone application:

wget https://bugs.kde.org/attachment.cgi?id=34517 -O minimizeall.cpp
wget https://bugs.kde.org/attachment.cgi?id=34518 -O CMakeLists.txt
mkdir build
cd build
cmake ../
make
./minimizeall


Showdesktop-plasmoid has that info.setShowingDesktop too so it can be dublicated and then we have minimizeall-plasmoid.
Comment 8 Beat Wolf 2009-08-24 11:46:39 UTC
Sending patches etc is better done on the mailing list:
plasma-devel@kde.org

you can also use http://reviewboard.kde.org
Comment 9 Krenar Qehaja 2009-10-25 03:17:27 UTC
I think I'm having a problem with "Show the Desktop" that is probably related to this bug.

To reproduce:
1. Add a "Show the Desktop" plasmoid to the desktop or panel.
2. Open two random apps.
3. Minimize only one of the opened apps (from step 2).
4. Click the "Show the Desktop" plasmoid or trigger the shortcut attached to it / [both apps are now minimized]
5. Launch a new app

Current result: The new app is launched and visible (step 5) BUT also the app that has been minimized through "Show the Desktop" plasmoid (from step 4) gets shown.

Expected result: Only the new app should be visible, the other two should remain minimized.

KDE 4.3.2
Qt 4.5.2

Thank you.
Comment 10 Aapo Rantalainen 2009-10-26 14:38:20 UTC
Krenar, you are not only who had thought there are bug in 'Show desktop'. But this is actually feature of 'Show desktop', it should work just like you describe. It shows desktop and then unminimize all applications again. Then there are another thing called 'minimize all'. It sends minimize signal for each running application and nothing more.

This bug report is because kde has messed these terms. I attached also way how to do real minimizeall, but maybe it is then feature request.
Comment 11 Marco Martin 2010-05-25 20:53:06 UTC
*** Bug 238778 has been marked as a duplicate of this bug. ***
Comment 12 Yakup Turgut 2010-05-25 21:46:16 UTC
The code you supplied works well as we want however we want to able to use it as "show desktop" I mean how are we going to add it as a widget to our panel? I couldn't understand if you have described above. And I think this bug can be thought as a feature request as you have stated, because many people complain about this "show desktop" implementation. And thanks for code.

What I wrote before to bug 238778:
When I click the "show desktop" widget on the panel it hides the windows but
what I want is to minimize them. For example, my home folder is open and I need
to open another folder and copy or do something on that folder so I click "show
desktop" widget, it hides everything then I open the new folder, then what I
see is not the folder I opened, instead it shows me the home folder which is
annoying for me. Although hiding windows is a design choice, I think users
should be able to choose the behaviour of the show desktop: hide or minimize
windows.
Comment 13 Aapo Rantalainen 2010-05-25 22:19:23 UTC
Yakup, this is very Ubuntu related way:

apt-get source plasma-widgets-addons
sudo apt-get build-dep plasma-widgets-addons

edit file kdeplasma-addons-*/applets/showdesktop/showdesktop.cpp

about row 80:        info.setShowingDesktop(m_down);
Just duplicate this row.

cd kdeplasma-addons-*
dpkg-buildpackage -rfakeroot -d -b
sudo dpkg -i ../kdeplasma-addons*.deb
(reboot plasma?)


There are in showdesktop.h:21 //#define MINIMIZE_ONLY
But not sure what that should be do. (I'm not running KDE at this moment to check that.)
Comment 14 Yakup Turgut 2010-05-26 11:02:29 UTC
Aapo, thank you for helping. I am using neither Ubuntu nor a Debian-based distro, but I get the idea. I can try the things you've said when I find to get source code of the packet from my distro's repository. I think my distro does not have an equivalent command to "apt-get source <packet>". I found the source code but now I don't have the necessary files to build the package. Thanks for everything.
Comment 15 Yakup Turgut 2010-06-05 14:51:54 UTC
Will the developers consider this bug as feature request or should we open a new bug to state our "real minimize all" wish?
Comment 16 Vincas Dargis 2016-12-11 11:29:28 UTC
Could this issue be moved to plasma 5 please?

Show desktop is really confusing. If I want to drag-and-drop some file from Desktop into some messaging app for example, I have to manually minimize all windows (leaving that one app I need), because if I use Show Desktop shortcut, and later activate that single app I need, all other windows pops back up!

Kubuntu 16.04.
Comment 17 João Vidal da Silva 2020-04-17 23:43:30 UTC
It should also be an action assignable to the keyboard.
Comment 18 Nate Graham 2022-03-01 17:08:28 UTC
There is now a real "Minimize all" applet.