Version: (using Devel) Compiler: visual studio 8 OS: MS Windows Installed from: Compiled sources Chances are you would have fixed this soon anyway... but cannot link against marble library on Windows. Problem is caused by missing MARBLE_EXPORT in MarbleWidgetInputHandler.h for the classes MarbleWidgetInputHandler and MarbleWidgetDefaultInputHandler. Also the Q_DISABLE_COPY used MarbleWidgetInputHandler is made protected rather than private. See attached patch.
Created attachment 33211 [details] patch for MarbleWidgetInputHandler.h
I see this bug is marked as fixed, though I notice no change in the MarbleWidgetInputHandler.h file. Was it determined that this is not a bug or was the fix accidentally not committed?
I think it was by accident that the fix didn't get committed. Glad that you mention it before tomorrow's tagging of the final. I need to check back with Patrick tomorrow morning that there are no issues with this fix. Please remind us if it hasn't been applied within the next 14 hours.
SVN commit 1003241 by rahn: BUG: 191047 fix by egk865. - Committed after discussion with jmho. Needs Patrick's confirmation still. M +7 -3 MarbleWidgetInputHandler.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1003241
After discussing this issue jmho and me decided to apply this patch immediately. egk865: please test and confirm that you consider this issue fixed in KDE4.3/Marble0.8 branch as well as trunk. Patrick: If you read this please tell me whether you think that this issue got appropriately solved. Thanks! Torsten
Looks good. Thanks! One new thing I just noticed though was that in order to get marble to compile on windows xp using visual studio 2008, I needed to change line 71 of GeoWidgetBubble.cpp from QPalette p( QColor(Qt::lightGray ), QColor( Qt::lightGray) ); to QPalette p( Qt::lightGray , Qt::lightGray ); Not sure why but for some reason a compiler error was generated: Here's the output from visual studio 1>Compiling... 1>GeoWidgetBubble.cpp 1>..\..\..\..\..\marble-svn\src\plugins\render\osmannotate\GeoWidgetBubble.cpp(71) : error C2751: 'lightGray' : the name of a function parameter cannot be qualified 1>..\..\..\..\..\marble-svn\src\plugins\render\osmannotate\GeoWidgetBubble.cpp(71) : error C2751: 'lightGray' : the name of a function parameter cannot be qualified 1>..\..\..\..\..\marble-svn\src\plugins\render\osmannotate\GeoWidgetBubble.cpp(71) : error C2086: 'QColor lightGray' : redefinition 1> ..\..\..\..\..\marble-svn\src\plugins\render\osmannotate\GeoWidgetBubble.cpp(71) : see declaration of 'lightGray' 1>..\..\..\..\..\marble-svn\src\plugins\render\osmannotate\GeoWidgetBubble.cpp(75) : error C2664: 'QWidget::setPalette' : cannot convert parameter 1 from 'QPalette (__cdecl *)(QColor)' to 'const QPalette &' 1> Reason: cannot convert from 'overloaded-function' to 'const QPalette' 1> No constructor could take the source type, or constructor overload resolution was ambiguous 1>Build log was saved at "file://c:\projects\adviser\marble\build2-svn\src\plugins\render\osmannotate\OsmAnnotatePlugin.dir\Release\BuildLog.htm" 1>OsmAnnotatePlugin - 4 error(s), 0 warning(s)
I see this last problem is fixed.