Bug 190671 - "New Subfolder…" button should not exist in folder selection dialog of Find Messages dialog
Summary: "New Subfolder…" button should not exist in folder selection dialog of Find M...
Status: RESOLVED FIXED
Alias: None
Product: kmail
Classification: Applications
Component: search (show other bugs)
Version: 1.11.2
Platform: openSUSE Unspecified
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2009-04-25 23:51 UTC by Tristan Miller
Modified: 2011-09-12 08:53 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tristan Miller 2009-04-25 23:51:20 UTC
Version:            (using KDE 4.2.2)
Installed from:    SuSE RPMs

In the "Find Messages" dialog, the user can bring up a folder selection dialog to search only in a specified folder.  This folder selection dialog contains a button "New Subfolder…" to create a new subfolder.  However, it makes no sense for the user to be creating subfolders when he is supposed to be searching them.  The button should be removed.
Comment 1 Laurent Montel 2010-04-23 17:38:59 UTC
SVN commit 1117974 by mlaurent:

Fix Bug 190671 -  "New Subfolder…" button should not exist in folder selection dialog of Find Messages dialog
CCBUG: 190671


 M  +3 -1      folderrequester.cpp  
 M  +3 -0      folderrequester.h  
 M  +21 -9     folderselectiondialog.cpp  
 M  +3 -2      folderselectiondialog.h  
 M  +2 -1      searchwindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1117974
Comment 2 Tristan Miller 2010-08-15 23:13:31 UTC
This bug still exists in KDE 4.5.  Is the SVN commit mentioned in the previous
comment still pending or does this bug need to be reopened?
Comment 3 Laurent Montel 2010-08-16 01:02:27 UTC
No kde 4.5 is frozen
=> wait 4.6
Regards
Comment 4 Tristan Miller 2010-08-16 09:28:15 UTC
Yeah, I knew 4.5 was frozen... I thought that the SVN commit was made before 4.5 was released, so I was expecting the bugfix to appear in 4.5.
Comment 5 Björn Ruberg 2010-08-16 13:28:09 UTC
The commit has been before any freeze. So it should be in KDE 4.5. I'm reopening this, because obviously something did not work here.
Comment 6 Björn Ruberg 2010-08-16 13:30:20 UTC
Oh... do you actually use kdepim4.5 packages? May be you have still the 4.4 ones, as kdepim 4.5 is not released yet.
Comment 7 Laurent Montel 2010-08-16 13:40:19 UTC
I re-close this bug !
kdepim-4.5 is frozen it's too late !
So don't reopen it.
Comment 8 Björn Ruberg 2010-08-16 13:49:19 UTC
Ehm ... sorry. KDE 4.5 is not frozen for bugfixes at all. Stuff committed to KDE 4.5 trunk is going to 4.5.1. Even if something were frozen, that would be no reason to close a bug.

But I already mentioned: This bug should be patched in KDE 4.5 because the fix was commited BEFORE even the soft feature freeze at 26. of April. 

So when it is still reported this can have two reasons:
1. The patch did not work or was not applied correctly. For this case I reopen this so that the bug can either be patched again or the patch can be transferred to KDE 4.5 trunk.
2. The reporter does still have old kdepim packages of KDE 4.4 running on his machine. In that case, this can be closed again.
Comment 9 Laurent Montel 2010-08-16 13:59:57 UTC
It"s not a bug it's a feature.
Add it adds a new string in kdepimlibs
=> NO ! You understand no ?!
Comment 10 Laurent Montel 2010-08-16 14:02:58 UTC
It"s not a bug it's a feature.
Add it adds a new string in kdepimlibs
=> NO ! You understand no ?!
Comment 11 Björn Ruberg 2010-08-16 14:26:00 UTC
Instead of being rude it would be more interesting, why something you committed on 23. April should not be in KDE 4.5. KDE 4.5 has been branched from trunk much later as far as I remember.
Comment 12 Tristan Miller 2010-08-16 14:50:57 UTC
I am using kdepimlibs-4.5.0, so if (as you say) the new string was to be added there, then this bug obviously didn't get fixed.
Comment 13 Christophe Marin 2010-08-16 15:06:57 UTC
kdepimlibs and kdepim are two different modules. Which kmail version are you using ?

(help/about KMail or kmail --version)

If the version is 1.xx, then you're using KMail from KDE 4.4 which is perfectly normal: kdepim 4.5 was not released.

Oh, and the fix is in the 4.5 branch: http://websvn.kde.org/branches/KDE/4.5/kdepim/kmail/searchwindow.cpp?r1=1115976&r2=1117974
Comment 14 Tristan Miller 2011-09-12 08:31:07 UTC
I am still experiencing this bug.  I'm running openSUSE 11.4 with KDE 4.6.0, kdepimlibs 4.6.0, and KMail 1.13.6.

Did the bugfix not get committed, is this a regression, or is this a downstream problem with my distribution?
Comment 15 Laurent Montel 2011-09-12 08:53:54 UTC
I implemented it, but we remove "search in folder" widget.
So this feature exists now in akonadi but was removed from search windows.