Bug 190479 - when using find-replace width vertical selection, it doesn't respect selection limits
Summary: when using find-replace width vertical selection, it doesn't respect selectio...
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Bernhard Beschow
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-24 00:45 UTC by pedroserra
Modified: 2010-06-21 01:53 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description pedroserra 2009-04-24 00:45:04 UTC
Version:           3.2.2 (using 4.2.2 (KDE 4.2.2), Kubuntu packages)
Compiler:          cc
OS:                Linux (i686) release 2.6.28-11-generic

Using find-replace with a vertical selection, it replaces occurrences outside the selection. 

It seams as the "vertical selection" setting is ignored and the normal selection is used instead.
Comment 1 Christoph Cullmann 2010-02-16 23:17:04 UTC
Passing over to Bernhard, he refactors this code.
Comment 2 erikr_le_rouge 2010-02-26 14:53:00 UTC
I have the same problem with version :
Qt: 4.5.3
KDE: 4.3.1 (KDE 4.3.1) "release 6"
Kate: 3.3.1

Very boring as I use frequently block-mode and find/replace command for my work...

Someone have a solution ?

Thanks
Comment 3 Dominik Haumann 2010-06-21 00:18:15 UTC
@Pascal: isn't this fixed?
Comment 4 Pascal Létourneau 2010-06-21 00:26:43 UTC
Yep
Comment 5 Bernhard Beschow 2010-06-21 01:53:46 UTC
There is still a BlockInputRange-TODO in KateDocument::searchText(), so block selection should be implemented in KatePlainTextSearch and KateRegExpSearch. After all, unit tests would be very helpful ;)