Bug 190403 - add notification for highlight triggers
Summary: add notification for highlight triggers
Status: RESOLVED FIXED
Alias: None
Product: konversation
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-23 06:43 UTC by Brandon Munger
Modified: 2009-04-24 18:09 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
adds highlight notifcation (2.26 KB, patch)
2009-04-24 03:02 UTC, Travis McHenry
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brandon Munger 2009-04-23 06:43:27 UTC
Version:           1.1.75+ #3400 (using 4.2.2 (KDE 4.2.2), Kubuntu packages)
Compiler:          cc
OS:                Linux (x86_64) release 2.6.28-11-generic

A notification option for configured highlighted text would be useful for notifying users.  Currently there is no option to alert the task bar entry.  While used nickname option is useful it does not work for the case where your real name is used in channel or message.
Comment 1 Eike Hein 2009-04-23 15:36:32 UTC
I could have sworn we had a Configure Notifications entry for "Highlight triggered", but apparently not indeed.
Comment 2 Travis McHenry 2009-04-24 03:02:18 UTC
Created attachment 33048 [details]
adds highlight notifcation 

This patch adds a notification for highlights and addresses a personal grievance with the Nick Written notification, making it only show when the window or tab is out of focus.

I would've committed this (using my fancy new svn account) but konversation.notifyrc has translations for all of the other event's comments/names...so I wasn't sure what to do.
Comment 3 Eike Hein 2009-04-24 15:11:29 UTC
Translations are added after your commit by translators (via the scripty bot you see making commits everywhere, which transfers translations from the language teams' SVN directories -- once we move back to a SVN location covered by translations that is).
Comment 4 Eike Hein 2009-04-24 18:09:37 UTC
Fixed in r958774 by Travis.