Bug 189651 - Konsole doubleclick word separator setting has no effect
Summary: Konsole doubleclick word separator setting has no effect
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-14 23:07 UTC by Gunter Ohrner
Modified: 2010-05-12 15:43 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Applying this patch in reverse against Konsole 2.2.2 sources resolves bug (2.08 KB, patch)
2009-04-27 11:15 UTC, lstewart
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gunter Ohrner 2009-04-14 23:07:50 UTC
Version:            (using KDE 4.2.2)
OS:                Linux
Installed from:    Debian testing/unstable Packages

Konsole 2.2.2 from KDE 4.2.2 does not seem to respect the double-click word separator setting any more. Eg. dots and dashes are always considered to be separators, although both are missing from the seprarators string in my current Konsole profile.

This is a regression from KDE 4.2.1 where it did work as far as I can tell.
Comment 1 lstewart 2009-04-27 10:11:28 UTC
I am experiencing the same Konsole regression on FreeBSD 7-STABLE with KDE 4.2.2 built from ports. It previously worked fine with KDE 4.2.1 built from ports. It's a minor, but rather annoying bug.

I used svn to get a diff of Konsole between 4.2.1 and 4.2.2 by running:

svn diff svn://anonsvn.kde.org/home/kde/tags/KDE/4.2.1/kdebase/apps/konsole/ svn://anonsvn.kde.org/home/kde/tags/KDE/4.2.2/kdebase/apps/konsole/

The changes to TerminalDisplay.cpp and removal of isCharBoundary() looks like it is likely related, but that's a guess based on the function/variable names in the diff.

Happy to test patches or debug further as instructed.

Cheers,
Lawrence
Comment 2 lstewart 2009-04-27 11:15:22 UTC
Created attachment 33150 [details]
Applying this patch in reverse against Konsole 2.2.2 sources resolves bug

I spent a few minutes investigating things a bit further. I have confirmed that applying this patch in reverse against the Konsole 2.2.2 (KDE 4.2.2) sources resolves the bug.
Comment 3 Marc Schiffbauer 2009-05-03 14:44:52 UTC
I just wanted to confirm this annoying bug.
Comment 4 Gunter Ohrner 2009-07-05 13:06:45 UTC
Hi Kurt! You tagged this bug as fixed, but without any further comment.

Has a patch been comitted to KDE 4.3 trunk? Will another 4.2 bugfix release, if there is any, also contain a fix?
Comment 5 Kurt Hindenburg 2009-07-05 15:32:17 UTC
It was fixed in 4.2.3.
Comment 6 Gunter Ohrner 2009-07-06 21:22:51 UTC
Mh, I'm still experiencing the bug, currently in Konsole "Version 2.2.3
running under KDE 4.2.4 (KDE 4.2.4)".

Is there anything I can do wrong, or is there any possibility it's not yet fixed in KDE 4.2.4?
Comment 7 lstewart 2009-07-07 15:34:51 UTC
I also agree that this bug is not fixed in KDE 4.2.4 running Konsole 2.2.3. I'm happy to test patches as directed (I've already provided a candidate that at least restores the previous working functionality), but please leave the bug open until a fix has been tested and the issue fully resolved.
Comment 8 lstewart 2009-07-14 17:11:25 UTC
My apologies, but I was wrong. This bug does indeed appear to be fixed in KDE 4.2.4 for me. Not sure where my confusion stems from... my suspicion is that the logic behind what the specified double-click selection characters are used for may have been inverted i.e. by adding characters to the list, I'm now increasing the options for expanding double-click selection. I'm pretty sure that I used to have to remove characters form the list in order to achieve the same effect.

Ah yep, I just tested KDE 4.2.2 and the logic has been inverted in KDE 4.2.4, but it works. Just confusing when the behaviour was previously the opposite.

Gunter, can you try again with KDE 4.2.4/Konsole 2.2.3 and add some characters to the list and see if it works for you?

Cheers,
Lawrence
Comment 9 Gunter Ohrner 2009-07-14 21:51:03 UTC
Mh, yes - this way it works, but the behaviour is not only unintuitive - I'd say the configuration option's text label is simply wrong now, at least in the German locale...

It states "Word delimiters for double click selection", but now you actually have to add characters which you do NOT want to delimit words... Additionally there's no information whatsoever how the base word delimiter set is constituted from which these characters are subtracted...

Anyway, now knowing that the implementation does not match the GUI it works for me, but I do not consider the current logic to be easily understandable - I much prefer the old behaviour from KDE <= 4.2.1.
Comment 10 lstewart 2009-07-15 04:30:23 UTC
Agreed, the old behaviour seems more sensible in the context of the current UI. I'm guessing a '!' needs to be added somewhere to invert the logic, or the UI updated.

Cheers,
Lawrence
Comment 11 Marc Haber 2010-05-11 23:30:36 UTC
I have :@-./_~?&=%+# set as Word Delimiters, and konsole 4.4.3 ignores most of these settings. For example, double clicking on "alemana-X.log:ii" selects the entire string and does not cut the selection at the colon.
Comment 12 Kurt Hindenburg 2010-05-12 04:53:54 UTC
The wording of this option really causes confusion.  See #9 for an  explanation.
Comment 13 Kurt Hindenburg 2010-05-12 15:43:51 UTC
SVN commit 1125848 by hindenburg:

Change the wording for characters to be considered part of a word when double clicking to avoid confusion.

BUG: 189651


 M  +4 -1      EditProfileDialog.ui  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1125848