Bug 189581 - "Organize files" delete files if it doen't have permission to write to the destination
Summary: "Organize files" delete files if it doen't have permission to write to the de...
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: 2.0.90
Platform: unspecified Linux
: HI grave
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
: 198664 198672 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-04-14 02:31 UTC by Geir Erikstad
Modified: 2009-12-09 11:34 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Geir Erikstad 2009-04-14 02:31:56 UTC
Version:           2.0.90 (using KDE 4.2.2)
Compiler:          gcc 4.4.3 
OS:                Linux
Installed from:    Unlisted Binary Package

I tried to use the organize files function to move a few of my albums to another directory. I didn't notice that the directory it was set to write to was my old collection directory, with my old user name (I have recently changed my username). That is, it was trying to write to a non-existing directory, which I didn't have the permissions to create. When I clicked OK, I didn't get any warning. The files was gone from their old directory, and nowhere to be found on my system.
Comment 1 Geir Erikstad 2009-04-14 02:40:51 UTC
I managed to hit enter while I was editing the short summary. It was supposed to say: "Organize files" delete files if it don't have permission to write to the destination. Can I change this somehow? I was also going to say that I have compiled amarok myself, and I use a newly updated version of Archlinux.
Comment 2 Dan Meltzer 2009-04-14 02:51:47 UTC
The text in blue at the top of the page is actually editable... It's a whole bunch unintuitive.
Comment 3 Geir Erikstad 2009-04-14 10:30:47 UTC
Output from one file (got the same error for all the files) when I run amarok with --debug and try it on one album:

amarok:  copying from  KUrl("file:///home/geirr/Musikk/Bonnie 'Prince' Billy - I See A Darkness/01-A Minor Place.mp3")  to  KUrl("file:///home/geir/Musikk/Bonnie _Prince_ Billy/I See A Darkness/01 - A Minor Place.mp3")
amarok:  [WARNING!] Could not create directory   QDir( "/home/geir/Musikk/Bonnie _Prince_ Billy/I See A Darkness" , nameFilters = { * },  QDir::SortFlags( Name | IgnoreCase ) , QDir::Filters( Dirs|Files|Drives|AllEntries ) )
Comment 4 Myriam Schweingruber 2009-05-02 18:40:49 UTC
Can somebody confirm this? Let's hope not...
Comment 5 sentinel 2009-05-02 19:55:49 UTC
I've hit the same problem, just with a little different scenario:
I have my collection on the external driver. I didn't noticed that I haven't plug it in. Then after trying 'Move to collection' the files were lost.
Comment 6 Leo Franchi 2009-05-04 12:07:22 UTC
i can't manage to reproduce this. i have the exact same output, trying to organize files into a directory i don't have permissions to,  but the original files don't get deleted...
Comment 7 Myriam Schweingruber 2009-05-04 12:32:03 UTC
I can reproduce it here too, unfortunately:
- changed the premission of destination folder test,
- openened organize files, choose a file and changed the destination folder to 'test',
- the file was erased from it's previous location, and of course it did not show up in the destination folder.

2.1-SVN, rev. 963220
Comment 8 Maximilian Kossick 2009-05-08 18:54:03 UTC
SVN commit 965347 by mkossick:

mark as track as transfer error when we cannot create the target directory.
CCBUG: 189581

 M  +3 -0      SqlCollectionLocation.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=965347
Comment 9 Myriam Schweingruber 2009-07-08 13:31:57 UTC
*** Bug 198664 has been marked as a duplicate of this bug. ***
Comment 10 Myriam Schweingruber 2009-07-08 13:38:59 UTC
*** Bug 198672 has been marked as a duplicate of this bug. ***
Comment 11 Myriam Schweingruber 2009-07-29 12:47:57 UTC
Reminder: we need to add a warning if the target destination is not writable. Somebody?
Comment 12 Myriam Schweingruber 2009-08-13 10:46:35 UTC
*** Bug 198664 has been marked as a duplicate of this bug. ***
Comment 13 Maximilian Kossick 2009-09-05 12:23:23 UTC
please confirm that this is still an issue in 2.2-beta1 or newer. I think this was fixed a while ago.
Comment 14 Kolja 2009-09-24 22:47:15 UTC
fixed for me!
Comment 15 Myriam Schweingruber 2009-09-25 13:27:13 UTC
(In reply to comment #14)
> fixed for me!

Great! Closing this bug then.