Bug 189563 - When inserting a new adblock filter the return key will close the settings window.
Summary: When inserting a new adblock filter the return key will close the settings wi...
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: 4.2.2
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-13 21:32 UTC by Boyd Stephen Smith Jr.
Modified: 2009-11-03 09:28 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Boyd Stephen Smith Jr. 2009-04-13 21:32:36 UTC
Version:           4.2.2 (using KDE 4.2.2)
OS:                Linux
Installed from:    SuSE RPMs

When inserting a new adblock filter (From the konqueror menu bar: "Settings" -> "Configure Konqueror..." -> "AdBlocK Filters") the return key will close the settings window, not inserting the
new expression.  The expression entered is lost.

Please make the return key behave like the insert button while using the
text box.  Actually, it would probably be best to add the expression to the list and then clear the text box as well.  While a single expression might not be a lot of data loss, it can be quite annoying.

https://bugs.kde.org/show_bug.cgi?id=148159 might be related?
Comment 1 Boyd Stephen Smith Jr. 2009-04-13 21:34:57 UTC
Debian Bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=450774 (originally reported against 3.5.7, but I am confirming with oS 11.1 + KDE 4.2 packages from OBS)
Comment 2 Jonathan Marten 2009-11-03 09:28:49 UTC
SVN commit 1044142 by marten:

Improve the operation of the adblock filter dialogue.  Set the button
enable/disable states and the default button in accordance with the
selected filter and the text in the edit box, so two common actions
can be done as would be expected with the keyboard:

(a) select a filter in the list, edit it, press RETURN -> filter is
updated and dialogue stays open.

(b) type a new filter, press RETURN -> new filter is added and
dialogue stays open.

There is also additional information on the import/export format, and
the filter syntax, shown as popup tooltips.

Added action icons to buttons.

BUG:189563
GUI:


 M  +105 -32   filteropts.cpp  
 M  +8 -6      filteropts.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1044142