Bug 189265 - Now playing applet skips tracks
Summary: Now playing applet skips tracks
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Plasma
Component: widget-nowplaying (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Alex Merry
URL:
Keywords:
: 190013 194880 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-04-10 10:53 UTC by Valentyn Pavliuchenko
Modified: 2009-12-03 19:38 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Valentyn Pavliuchenko 2009-04-10 10:53:40 UTC
Version:            (using KDE 4.2.2)
OS:                Linux
Installed from:    Debian testing/unstable Packages

See commit 937561.

"Don't feed back when we change to a shorter track.  Caused a shorter track played after a longer one to skip straight to the end."

This makes applet unusable and should be backported to 4.2.2.
Comment 1 Valentyn Pavliuchenko 2009-04-10 11:24:28 UTC
Also commit 937561 does unsafe changes.

Here is changed code:

    if (length != m_length) {
        m_length = length;

+        m_positionSlider->blockSignals(true);
        if (length == 0) {
            updatePositionSlider(0);
        }
-        emit lengthChanged(m_length);
+        m_positionSlider->setMaximum(length);
+        m_positionSlider->blockSignals(false);
    }

But updatePositionSlider(0) also blocks signals. So we have nested signals blocking, that is unsafe and can cause bugs.

void NowPlaying::updatePositionSlider(int position)
{
    m_positionSlider->blockSignals(true);
    m_positionSlider->setValue(position);
    m_positionSlider->blockSignals(false);
}
Comment 2 Alex Merry 2009-05-31 12:57:23 UTC
SVN commit 975827 by alexmerry:

Don't nest signal blocking calls.

CCBUG: 189265



 M  +4 -9      nowplaying.cpp  
 M  +0 -1      nowplaying.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=975827
Comment 3 Alex Merry 2009-05-31 12:57:50 UTC
Sorry, I thought I had backported it.
Comment 4 Alex Merry 2009-05-31 12:58:12 UTC
*** Bug 190013 has been marked as a duplicate of this bug. ***
Comment 5 Alex Merry 2009-05-31 13:06:45 UTC
SVN commit 975830 by alexmerry:

Backport r937561:
Don't feed back when we change to a shorter track.  Caused a shorter track played after a longer one to skip straight to the end.

and r975827:
Don't nest signal blocking calls.

BUG: 189265




 M  +8 -12     nowplaying.cpp  
 M  +0 -1      nowplaying.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=975830
Comment 6 Mark Kretschmann 2009-06-01 22:44:28 UTC
*** Bug 194880 has been marked as a duplicate of this bug. ***
Comment 7 Mark Kretschmann 2009-08-27 19:24:23 UTC
*** Bug 205349 has been marked as a duplicate of this bug. ***
Comment 8 christian chevalier 2009-12-02 14:17:40 UTC
The problem is not resolved on 2.2.0.
When the playlist is a list of radio streams, if I try to play a stream that is not available, amarok will skip to the next stream, play ~ 0.5 second and skip to the next stream, etc.
Then, it is not possible to play one stream (but the last one in the playlist). Amarok must be restarted to retrieve its normal behaviour.
Comment 9 Alex Merry 2009-12-03 00:11:31 UTC
@christian chevalier: that is a different bug.  This bug refers to the presence of the Now Playing plasma applet on your desktop causing Amarok (and other media players) to skip tracks that are shorter than the previous track.  Your bug appears to be an Amarok-specific bug to do with streams.
Comment 10 Valentyn Pavliuchenko 2009-12-03 08:52:35 UTC
@christian chevalier:

Does the bug exist without this applet?
Comment 11 christian chevalier 2009-12-03 09:18:19 UTC
I reopened this bug because it was pointed by Bug 194880 that is more similar to what I see.
For me, the only applet installed is wikipedia.
Comment 12 Valentyn Pavliuchenko 2009-12-03 09:47:18 UTC
@christian chevalier:

Does this bug appears WITHOUT Now playing plasmoid? I also think that it is not related to Now playing. And what KDE version do you use?
Comment 13 christian chevalier 2009-12-03 11:24:02 UTC
Yes, the Now playing plasmoid is not installed.
I use KDE 4.3.2 from mandriva-2010.0
Comment 14 Valentyn Pavliuchenko 2009-12-03 18:43:08 UTC
>Yes, the Now playing plasmoid is not installed.

So why do you writing into this bug? It's for Now playing plasmoid, not for Amarok.
You should find existing/create new report for Amarok, not for Now Playing widget.
Comment 15 christian chevalier 2009-12-03 19:38:57 UTC
Look at comment #11 :
I reopened this bug because it was pointed by Bug 194880 that is more similar
to what I see