Bug 189006 - Energy info dialog has poor layout (long translation issue)
Summary: Energy info dialog has poor layout (long translation issue)
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Plasma
Component: widget-battery (show other bugs)
Version: unspecified
Platform: openSUSE Unspecified
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
: 189579 198079 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-04-07 05:30 UTC by Christoph Bartoschek
Modified: 2009-12-02 16:29 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
the energy info dialog (34.50 KB, image/png)
2009-04-07 05:31 UTC, Christoph Bartoschek
Details
Dialog from SVN KDE 4.3 (34.00 KB, image/png)
2009-04-29 22:47 UTC, Christoph Bartoschek
Details
The applet in French (31.37 KB, image/png)
2009-05-11 19:57 UTC, Anne-Marie Mahfouf
Details
SVN revision 980360 (32.66 KB, image/png)
2009-06-12 01:17 UTC, Christoph Bartoschek
Details
Dialog from SVN revision 1057075 (48.78 KB, image/png)
2009-12-02 10:57 UTC, Christoph Bartoschek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Bartoschek 2009-04-07 05:30:12 UTC
Version:            (using KDE 4.2.2)
Installed from:    SuSE RPMs

I have an attachement of how the energy info dialog currently looks like:

1. The remaining time text is too large. Why are you using descriptive language here?

2. There seems to be more text next to "Tiefschlaf". What is it?
Comment 1 Christoph Bartoschek 2009-04-07 05:31:53 UTC
Created attachment 32675 [details]
the energy info dialog
Comment 2 Andreas Hartmetz 2009-04-07 19:18:53 UTC
The whole dialog layout looks faulty, text is even cut off vertically. This should never happen in a properly laid out widget.
Comment 3 Aaron J. Seigo 2009-04-28 19:52:59 UTC
can someone who has seen this problem please check again with 4.3? thanks
Comment 4 Christoph Bartoschek 2009-04-29 22:47:21 UTC
Created attachment 33225 [details]
Dialog from SVN KDE 4.3

I've built the newest SVN version with kdesvn-build. Here the dialog seems to be worse. 

However I am not sure that this is the most recent version from the SVN. How can I check this?
Comment 5 Vincent Petry 2009-05-11 16:20:33 UTC
Similar problem with french locale in KDE 4.2.3:  the texts near the buttons for "suspend to ram", "suspend to disk"  and "more..." are cut. It would maybe be better to remove the button texts completely, and show their description in a tooltip when the mouse hovers them.

See attached screenshot.
Comment 6 Anne-Marie Mahfouf 2009-05-11 19:57:32 UTC
Created attachment 33554 [details]
The applet in French

Strings are cut and make it difficult to differentiate them

Trunk l10n/fr revision  966599
kdebase revision 966584
Comment 7 Marco Martin 2009-06-09 10:28:25 UTC
*** Bug 189579 has been marked as a duplicate of this bug. ***
Comment 8 Artur Souza (MoRpHeUz) 2009-06-11 17:17:06 UTC
Can you please test this with latest trunk ? It should be fixed now (at least the icon and combobox layout issues).
Comment 9 Christoph Bartoschek 2009-06-12 01:17:41 UTC
Created attachment 34448 [details]
SVN revision 980360

For me the dialog did not really improve.
Comment 10 Aaron J. Seigo 2009-06-12 02:18:52 UTC
sorry, what's wrong in that dialog? (besides the white text on the widget; theme error there)
Comment 11 Christoph Bartoschek 2009-06-12 09:07:56 UTC
1. The abbreviated Labels "Ruhezust..." "Tiefschlaf..." "Mehr ...".  Maybe only the first one is abbreviated.

2. The descender of the "g" is cut away.

3. The two labels "Akku" and "Netzkabel" are in bold. And Akku information spans two lines. This leads to the impression that the word "Bildschirm-Helligkeit" belongst to "Netzkabel".

4. The combobox and the button for "Ruhezustand" are not left aligned. And both together are not aligned with the labels Energieprofil and Aktionen.

5. A dark light bulb is missing at the left side of the slider.
Comment 12 Dario Andres 2009-06-27 23:57:17 UTC
*** Bug 198079 has been marked as a duplicate of this bug. ***
Comment 13 Beat Wolf 2009-11-28 16:50:52 UTC
Please check if this is still a issue in trunk, the layout has been reworked:
http://vizzzion.org/blog/2009/11/battery-applet-the-sequel/
Comment 14 Andrey Borzenkov 2009-11-28 17:01:50 UTC
Right now in 4.3.77 layout is completely broken for me (bug 215454)
Comment 15 Christoph Bartoschek 2009-12-02 10:57:08 UTC
Created attachment 38763 [details]
Dialog from SVN revision 1057075

I've tested the dialog from trunk and it is better. However there are some issues:

1. Not everything is translated. I cannot check whether a longer translation breaks the dialog.

2. The label "Energieprofil" and the combobox "Performane" are not correctly aligned.

3. The label "Bildschirm-Helligkeit" and the slider are not correctly aligned. The slider should be in the middle of the x-height of the characters.

4. The slider is visually too light. 

5. The setting of the brightness can be done only in steps on my notebook. Is a slider the correct widget for something like that?

6. The buttons "Ruhezustand" and "Tiefschlaf (Hibernate)" should be recognizable as buttons. Why not using normal dialog buttons? After changing them to real buttons I would remove the icons. They do not add anything here.

7. The button to edit energy profiles is easily missed. Make it a real button. I would also remove the icon and label it: "Edit Energy Profiles"

8. Colons are missing after "Bildschirm-Helligkeit" and "Energieprofil"

9. The horizontal alignment of "Ruhezustand" and "Tiefschlaf (Hibernate)" does not fit to the rest of the dialog. The second button looks like it should be aligned to the other elements that are right of a label. A cleaner separation would help. Maybe making the buttons real buttons will already help.
Comment 16 Christoph Bartoschek 2009-12-02 10:58:27 UTC
Changing status as the info is given.
Comment 17 Sebastian Kügler 2009-12-02 13:27:35 UTC
1. Which translations are missing? Is it not translated in the applet, or "just" in your language?

2., 3. Fixed

4. Belongs to libplasma, please file a new bug for this

5. Sliders often show stepped information, and the stepping can vary from only a couple (7 on my thinkpad) to 100 as I've seen on other hardware. I think a slider works OK with both extremes

6. They standard buttons used from plasma, if anything's wrong with it, file a bug against the plasma widgets

7. This is done on purpose, the thing has a tooltip, but I think its appearance is largely a matter of taste

8. needs fixing post-string freeze

9. I don't see how "real" buttons help, but putting them on top of each other will waste space

As the tangible issues have been fixed, I'm closing this bug as those "aggregate reports" aren't that useful.

Thanks for your input!
Comment 18 Christoph Bartoschek 2009-12-02 16:29:58 UTC
Standard buttons have a border and are visually above the background. Are plasma buttons different?