Bug 188213 - Support for file type BZ2
Summary: Support for file type BZ2
Status: RESOLVED FIXED
Alias: None
Product: ark
Classification: Applications
Component: general (show other bugs)
Version: 2.12
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Harald Hvaal
URL:
Keywords:
: 201298 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-03-26 23:50 UTC by Elan Ruusamäe
Modified: 2009-07-24 00:30 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot of offered content-types (18.08 KB, image/png)
2009-03-26 23:51 UTC, Elan Ruusamäe
Details
Add FindBZIP2.cmake (1.33 KB, patch)
2009-03-30 06:20 UTC, Raphael Kubo da Costa
Details
Include the bzip2 plugin subdirectory in the build. (1.16 KB, patch)
2009-03-30 06:20 UTC, Raphael Kubo da Costa
Details
Main code for the bzip2 plugin - implementation and .desktop file (11.20 KB, patch)
2009-03-30 06:21 UTC, Raphael Kubo da Costa
Details
Main code for the bzip2 plugin - implementation and .desktop file (11.41 KB, patch)
2009-03-30 06:50 UTC, Raphael Kubo da Costa
Details
Include the bzip2 plugin subdirectory in the build. (1.16 KB, patch)
2009-03-30 15:04 UTC, Raphael Kubo da Costa
Details
Main code for the bzip2 plugin - implementation and .desktop file (11.40 KB, patch)
2009-03-31 06:59 UTC, Raphael Kubo da Costa
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Elan Ruusamäe 2009-03-26 23:50:25 UTC
Version:           2.12 (using 4.2.1 (KDE 4.2.1), PLD-Linux)
Compiler:          x86_64-pld-linux-gcc
OS:                Linux (x86_64) release 2.6.27.7-2

for example take any *.patch.bz2 from:

http://users.k12system.com/mrwizard/pound/pound24.html

like: http://users.k12system.com/mrwizard/pound/pound-2.4.4-03_IncludeDirective.patch.bz2

it will display a list of content-types, but no .bz2 listed (the x-gzip suggested on irc, didn't work either)
Comment 1 Elan Ruusamäe 2009-03-26 23:51:25 UTC
Created attachment 32420 [details]
screenshot of offered content-types
Comment 2 Raphael Kubo da Costa 2009-03-30 06:20:25 UTC
Created attachment 32474 [details]
Add FindBZIP2.cmake

This and the following patches add read-only support for bzip2 files, based on the code for gz files and for libarchive.
Comment 3 Raphael Kubo da Costa 2009-03-30 06:20:59 UTC
Created attachment 32475 [details]
Include the bzip2 plugin subdirectory in the build.
Comment 4 Raphael Kubo da Costa 2009-03-30 06:21:45 UTC
Created attachment 32476 [details]
Main code for the bzip2 plugin - implementation and .desktop file
Comment 5 Raphael Kubo da Costa 2009-03-30 06:22:08 UTC
The previous three patches implement read-only support for bzip2 files.
Comment 6 Raphael Kubo da Costa 2009-03-30 06:50:43 UTC
Created attachment 32477 [details]
Main code for the bzip2 plugin - implementation and .desktop file

This patch fixes the extraction code by manually calling the open() method.
Comment 7 Pino Toscano 2009-03-30 11:12:32 UTC
(In reply to comment #2)
> Created an attachment (id=32474) [details]
> Add FindBZIP2.cmake

cmake provides already a FindBZip2.cmake, so there's no need of a custom bzip2 search module.
Comment 8 Raphael Kubo da Costa 2009-03-30 15:04:59 UTC
Created attachment 32483 [details]
Include the bzip2 plugin subdirectory in the build.

Oh, I didn't know. Fixing ark/plugins/CMakeLists.txt so it uses CMake's default FindBZip2.cmake and removing FindBZIP2.cmake.
Comment 9 Raphael Kubo da Costa 2009-03-31 06:59:38 UTC
Created attachment 32492 [details]
Main code for the bzip2 plugin - implementation and .desktop file

Fix call to userQuery - it's not a signal anymore.
Comment 10 Raphael Kubo da Costa 2009-04-21 22:34:42 UTC
SVN commit 957330 by rkcosta:

Generalize LibGzipInterface to make it support bz2 and lzma files by
making it use KFilterDev.
liblzmaplugin has been removed due to this.
Moved checks for the necessary libraries for gz/bz2/lzma support to
libsinglefileplugin/CMakeLists.txt.

BUG: 188213
BUG: 164795

 M  +1 -15     CMakeLists.txt  
 D             libgzplugin/CMakeLists.txt  
 D             libgzplugin/gzplugin.cpp  
 D             libgzplugin/kerfuffle_libgz.desktop  
 D             liblzmaplugin/CMakeLists.txt  
 D             liblzmaplugin/kerfuffle_liblzma.desktop  
 D             liblzmaplugin/lzmaplugin.cpp  
 A             libsinglefileplugin (directory)  
 A             libsinglefileplugin/CMakeLists.txt  
 A             libsinglefileplugin/bz2plugin.cpp   [License: BSD]
 A             libsinglefileplugin/bz2plugin.h   [License: BSD]
 A             libsinglefileplugin/gzplugin.cpp   [License: BSD]
 A             libsinglefileplugin/gzplugin.h   [License: BSD]
 A             libsinglefileplugin/kerfuffle_libbz2.desktop  
 A             libsinglefileplugin/kerfuffle_libgz.desktop   libgzplugin/kerfuffle_libgz.desktop#957180
 A             libsinglefileplugin/kerfuffle_libxz.desktop  
 A             libsinglefileplugin/singlefileplugin.cpp   [License: BSD]
 A             libsinglefileplugin/singlefileplugin.h   [License: BSD]
 A             libsinglefileplugin/xzplugin.cpp   [License: BSD]
 A             libsinglefileplugin/xzplugin.h   [License: BSD]


WebSVN link: http://websvn.kde.org/?view=rev&revision=957330
Comment 11 Raphael Kubo da Costa 2009-07-24 00:30:33 UTC
*** Bug 201298 has been marked as a duplicate of this bug. ***