Bug 187752 - build is broken when gsl header files missing
Summary: build is broken when gsl header files missing
Status: RESOLVED WORKSFORME
Alias: None
Product: kst
Classification: Applications
Component: general (show other bugs)
Version: 1.x
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-21 00:57 UTC by D. V. Wiebe
Modified: 2009-03-21 01:14 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description D. V. Wiebe 2009-03-21 00:57:08 UTC
Version:           1.8.0_svn_914813 (using KDE 3.5.10)
Compiler:          gcc (GCC) 4.2.4 
OS:                Linux
Installed from:    Compiled From Sources

When ./configure is run, many gsl header files are searched for.  However, the result of these tests appear to be discarded:

If the header files are not found, ./configure completes successfully, but still goes on to attempt to build kst components which require these header files.

Instead, if these gsl header files are not found, one or more of the following should be done:

1) kst components requiring gsl should not be built

2) ./configure should complain that kst can't be built without the headers

Steps to reproduce:

1) Start with a clean copy of the kst source code.

2) remove gsl header files from the system (or, at least, from the compiler's include search path)

3) ./configure (should complete successfully, while reporting gsl header files missing)

4) "make"

Result:

make[5]: Entering directory `/tmp/kst-1.8.0_svn_914813/kst/src/plugins/normalization'
/usr/share/qt3/bin/moc ./normalization.h -o normalization.moc
/bin/bash ../../../../libtool --silent --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I../../../.. -I../../../../kst/src/libkst -I../../../../kst -I../../../../kst/src/libkst -I../../../../kst/src/libkstmath -I/usr/include/kde -I/usr/share/qt3/include -I.   -DQT_THREAD_SUPPORT  -D_REENTRANT  -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -DNDEBUG -DNO_DEBUG -O2 -Wformat-security -Wmissing-format-attribute -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION  -MT normalization.lo -MD -MP -MF .deps/normalization.Tpo -c -o normalization.lo normalization.cpp
normalization.cpp:20:25: error: gsl/gsl_fit.h: No such file or directory
normalization.cpp:21:28: error: gsl/gsl_spline.h: No such file or directory
normalization.cpp: In member function 'void Normalization::fit(int, int, int, double*, double*, KstVectorPtr)':
normalization.cpp:142: error: 'gsl_fit_linear' was not declared in this scope
normalization.cpp: In member function 'void Normalization::interpolate(double*, double*, int)':
normalization.cpp:321: error: 'gsl_interp_accel' was not declared in this scope
normalization.cpp:321: error: 'acc' was not declared in this scope
normalization.cpp:321: error: 'gsl_interp_accel_alloc' was not declared in this scope
normalization.cpp:322: error: 'gsl_spline' was not declared in this scope
normalization.cpp:322: error: 'spline' was not declared in this scope
normalization.cpp:322: error: 'gsl_interp_akima' was not declared in this scope
normalization.cpp:322: error: 'gsl_spline_alloc' was not declared in this scope
normalization.cpp:324: error: 'gsl_spline_init' was not declared in this scope
normalization.cpp:328: error: 'gsl_spline_eval' was not declared in this scope
normalization.cpp:331: error: 'gsl_spline_free' was not declared in this scope
normalization.cpp:332: error: 'gsl_interp_accel_free' was not declared in this scope
make[5]: *** [normalization.lo] Error 1
make[5]: Leaving directory `/tmp/kst-1.8.0_svn_914813/kst/src/plugins/normalization'
make[4]: *** [all-recursive] Error 1
make[4]: Leaving directory `/tmp/kst-1.8.0_svn_914813/kst/src/plugins'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/tmp/kst-1.8.0_svn_914813/kst/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/tmp/kst-1.8.0_svn_914813/kst'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/tmp/kst-1.8.0_svn_914813'
make: *** [all] Error 2

Expected result:

The build system should not compile components requiring gsl, or else ./configure should not complete successfully, instead issuing an error message indicating the missing header files.
Comment 1 Andrew Walker 2009-03-21 01:14:47 UTC
I believe this was fixed about two weeks ago in revision 933179.

I'll withdraw this report, but if you still have the problem in the latest build please re-open.