Bug 187495 - Remove unnecessary code duplication for standard icons
Summary: Remove unnecessary code duplication for standard icons
Status: RESOLVED FIXED
Alias: None
Product: kdelibs
Classification: Unmaintained
Component: kstyle (show other bugs)
Version: unspecified
Platform: RedHat Enterprise Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Maksim Orlovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-18 11:27 UTC by Andrey Cherepanov
Modified: 2024-05-10 20:43 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
icons seems ok (102.36 KB, image/png)
2009-03-19 15:14 UTC, Huynh Huu Long 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Cherepanov 2009-03-18 11:27:59 UTC 
Version:            (using KDE 4.2.0)
OS:                Linux
Installed from:    RedHat RPMs

If I switch in qtconfig style to Oxygen, all standart Qt dialogs (for example, QMessageBox::critical() in Qt examples) show without icons (QMessageBox::Critical). In other styles (Plastique) these icons show correctly.
Comment 1 Huynh Huu Long 2009-03-19 15:14:29 UTC 
Created attachment 32259 [details]
icons seems ok

Not reproducable over here (Qt 4.5, KDE-trunk)
Comment 2 Andrey Cherepanov 2009-03-19 20:21:43 UTC 
I have Qt 4.4.3. I wait for Qt 4.5 and close bug if it will be OK.
Comment 3 Christoph Feck 2009-03-19 22:10:46 UTC 
This is fixed with commit 929352, but this commit is actually superflous, as Qt 4.5 has the same code in QCommonStyle. The fix is only required for Qt 4.4 (KDE 4.2 branch), but trunk requires Qt 4.5.

I will leave the bug open until the code duplication is solved.
Comment 4 Christoph Cullmann 2024-05-10 20:43:08 UTC 
That code got adjusted a lot in the last decade.