Bug 187300 - JJ: Better visibility of "new image from clipboard" functionallity.
Summary: JJ: Better visibility of "new image from clipboard" functionallity.
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2009-03-16 12:44 UTC by Raúl
Modified: 2013-05-17 07:15 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Proposed solution (11.95 KB, patch)
2013-05-01 11:06 UTC, Matjaž Rous
Details
Improvement (28.40 KB, patch)
2013-05-05 18:52 UTC, Matjaž Rous
Details
Improved GUI (30.88 KB, patch)
2013-05-05 19:02 UTC, Matjaž Rous
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Raúl 2009-03-16 12:44:27 UTC
Version:           2.0 beta-7 (using 4.2.1 (KDE 4.2.1), Debian packages)
Compiler:          cc
OS:                Linux (x86_64) release 2.6.26-1-amd64

Hello:

I came here because I thought that https://bugs.kde.org/show_bug.cgi?id=134588 were not solved. On the contrary, it is. Thanks for it. But would it be possible to add some kind of notification to improve visibility of this? I have tested on krita2.0beta7

It is not very intuitive to get this functionality. Suggestions:

  · On start krita goes straight to custom dialog when there is something on the clipboard.
  · Rename custom to custom/clipboard or something like that.
  · In custom dialog print a text label somewhere that states that the clipboard content is to be pasted onto a new image.

  If you need I can open a new bug.

  Thanks.
Comment 1 Raúl 2009-03-16 12:45:12 UTC
Forget about my comment on create a new bug.
Comment 2 Cyrille Berger 2009-03-16 13:09:44 UTC
The plan would be to have a the "new image from clipboard" outside the "custom document" widget, it would be an icon on the left, and offer something like a preview of what is in the clipboard, and possibely offer the option to select a profile.
Comment 3 Halla Rempt 2009-03-16 13:13:10 UTC
Yes, that would be best. But I doubt we'll get a patch to make that possible into the libraries.
Comment 4 Cyrille Berger 2009-06-01 15:43:45 UTC
Marking as junior job, it's already possible to do it in library, just add a widget to the list:

QList<KoDocument::CustomDocumentWidgetItem> KisDoc2::createCustomDocumentWidgets(QWidget *parent)

Might be worth to have them available as plugins, but for the JJ, adding the widget to that inside kritaui would be sufficient.
Comment 5 fossphreak 2012-11-19 07:48:14 UTC
Does this still need to be done? If not, I can work on it.
Comment 6 Halla Rempt 2012-11-19 09:03:05 UTC
Yes, it still needs to be done. And it would be wonderful if you would work on it! If you have any questions or want help to get started, join us on #krita on irc.freenode.net or the kimageshop@kde.org mailing list.
Comment 7 fossphreak 2013-03-15 06:02:20 UTC
I had been working on this off and on, and I had made some progress. But, my hard drive (or atleast the partition) seems to be corrupted and it's difficult to recover what was lost. I thought I could use git to recover the files, but it looks like several files in the git repository are corrupted/empty. So, I'll probably have to start all over.  :(.

If anyone else has been working on this, or was planning to, it's better and probably faster if they go ahead and do it.
Comment 8 Matjaž Rous 2013-05-01 11:06:46 UTC
Created attachment 79589 [details]
Proposed solution

I worked on this over the last couple of days and managed to solve the issue.
Comment 9 Halla Rempt 2013-05-02 19:10:20 UTC
Thanks, I'll test it tonight/early tomorrow!
Comment 10 Matjaž Rous 2013-05-05 18:52:43 UTC
Created attachment 79722 [details]
Improvement

Improved version of the patch.
Comment 11 Matjaž Rous 2013-05-05 19:02:39 UTC
Created attachment 79723 [details]
Improved GUI

Small GUI improvement.
Comment 12 Halla Rempt 2013-05-10 08:43:53 UTC
Hi  Matjaž,

I'm trying to apply your patch but running into lots of trouble. Could you attach the files you touched to the bug so I can make a new diff myself? Thanks!
Comment 13 Halla Rempt 2013-05-11 12:14:55 UTC
Git commit 1723decc4b8f5ba51a79b836f1d3064d48d20077 by Boudewijn Rempt.
Committed on 11/05/2013 at 14:14.
Pushed by rempt into branch 'master'.

Move create image from clip to a separate widget

Patch by Matjaž Rous
CCMAIL: matjazrous@gmail.com

M  +1    -0    krita/ui/CMakeLists.txt
M  +21   -19   krita/ui/forms/wdgnewimage.ui
M  +21   -9    krita/ui/kis_part2.cpp
M  +16   -53   krita/ui/widgets/kis_custom_image_widget.cc
M  +14   -6    krita/ui/widgets/kis_custom_image_widget.h
A  +150  -0    krita/ui/widgets/kis_image_from_clipboard_widget.cpp     [License: GPL (v2+)]
A  +55   -0    krita/ui/widgets/kis_image_from_clipboard_widget.h     [License: GPL (v2+)]

http://commits.kde.org/calligra/1723decc4b8f5ba51a79b836f1d3064d48d20077
Comment 14 Siddharth 2013-05-17 07:15:31 UTC
Git commit c78c598981b71c490f819bd879e3ccff5531b1c5 by Siddharth Sharma, on behalf of Boudewijn Rempt.
Committed on 11/05/2013 at 14:14.
Pushed by siddharthsharma into branch 'krita-psd-plugin-siddharth'.

Move create image from clip to a separate widget

Patch by Matjaž Rous
CCMAIL: matjazrous@gmail.com

M  +1    -0    krita/ui/CMakeLists.txt
M  +21   -19   krita/ui/forms/wdgnewimage.ui
M  +21   -9    krita/ui/kis_part2.cpp
M  +16   -53   krita/ui/widgets/kis_custom_image_widget.cc
M  +14   -6    krita/ui/widgets/kis_custom_image_widget.h
A  +150  -0    krita/ui/widgets/kis_image_from_clipboard_widget.cpp     [License: GPL (v2+)]
A  +55   -0    krita/ui/widgets/kis_image_from_clipboard_widget.h     [License: GPL (v2+)]

http://commits.kde.org/calligra/c78c598981b71c490f819bd879e3ccff5531b1c5