Version: svn r937541 (using KDE 4.2.1) OS: Linux Installed from: Ubuntu Packages chromatic aberration correction does not work: - resulting image is transparent (alpha == 0) - involves sub-pixel movements of color components, which is not implemented distortion correction creates artifacts - involves sub-pixel movements of image data, which is not implemented
Created attachment 32009 [details] proposed patch to fix the mentioned bugs this patch implements access to interpolated image data in class DImg, either via Lanczos or Bilinear interpolation. it also fixes the mentioned bugs in the lens defect auto-correction plugin
Matthias, can you update your patch to current trunk? I tried to apply it but it failed. Andi
Created attachment 32811 [details] updated patch
Created attachment 32985 [details] patch without tabs I removed the tabs from the patch. Sorry I hadn't the time yet to look at the patch, it is quite big. I guess we need to discuss this further, at least I will not commit it on my own :-) Gilles, Marcel, can you take a look at this patch, too? Andi
We can meet on IRC if you need real time.
Yes, patch is huge. Great job. Marcel, patch touch DImg component indeep. Can you take a look. I will do it also, but it a sensible part... Gilles
There are a lot of whitespace changes in the API docs of dimg.h. I think these are a side-product of the patch processing and should be removed from the patch - then it is much smaller. For me the characters of Ville's surname in the copyright notice are broken as well. Encoding issue. Other than that, I see a bug fix in blendClamp8() and the rest is added methods, that's fine with me.
Thanks Marcel. I review patch today... Gilles
SVN commit 958053 by cgilles: apply patch #32985 from Matthias Welwarsky fo fix LensFun tool with Lanzcos method BUG: 186823 M +7 -7 imageplugins/lenscorrection/autocorrection/klensfun.cpp M +1 -0 libs/dimg/dcolor.h M +16 -9 libs/dimg/dcolorblend.h M +218 -2 libs/dimg/dimg.cpp M +96 -80 libs/dimg/dimg.h M +28 -1 libs/dimg/dimgprivate.h WebSVN link: http://websvn.kde.org/?view=rev&revision=958053