Bug 186797 - remove "review" term and use annotations consistently
Summary: remove "review" term and use annotations consistently
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Unspecified
: NOR wishlist
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-10 17:41 UTC by Maciej Pilichowski
Modified: 2020-09-30 16:09 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 20.12.0
Sentry Crash Report:


Attachments
Reviews term not no longer used (6.22 KB, image/png)
2020-09-29 15:09 UTC, Laura David Hurka
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Pilichowski 2009-03-10 17:41:48 UTC
Version:            (using KDE 4.2.1)

Currently the term "review" is used once, and later is annotation this (author), annotation that, and so on. Ockham razor -- "review" does not bring anything here, quite contrary, it multiplies entities, so please remove that term, and use only "annotations" (*).

(*) I am not saying, the "annotation" is better, simply consistency matters
Comment 1 Stephan Wassipaul 2011-09-06 23:43:55 UTC
I want to second the original author's wish, I'm currently using Okular for the first time to seriously work on a scientific paper and it's a pleasure to use. However, sometimes it takes a bit to get used to the UI, and some little tweaks like this one could IMHO improve the user experience quite a lot.

Also, it would help you stay focused instead of thinking "Hey, did anybody else ever notice and file a bug about it?" :D
Comment 2 Simone Gaiarin 2020-09-29 07:00:01 UTC
This has been solved in the UI. The term "Reviews" is still used in the code though.
Comment 3 Laura David Hurka 2020-09-29 15:09:26 UTC
Created attachment 132008 [details]
Reviews term not no longer used

Almost...

> $ git grep '"Reviews"'
> conf/okular.kcfg: <group name="Reviews" >
> ui/side_reviews.cpp:    titleWidget->setText(i18n("Reviews"));
Comment 4 Bug Janitor Service 2020-09-30 06:31:42 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/okular/-/merge_requests/289
Comment 5 Simone Gaiarin 2020-09-30 16:09:51 UTC
Git commit 837a9c1f52a373ddfc441a83aa9abfceda03c7e2 by Simone Gaiarin.
Committed on 30/09/2020 at 06:24.
Pushed by aacid into branch 'master'.

Use the term "Annotations" everywhere in place of "Reviews"
FIXED-IN: 20.12.0

M  +1    -1    ui/side_reviews.cpp

https://invent.kde.org/graphics/okular/commit/837a9c1f52a373ddfc441a83aa9abfceda03c7e2