Bug 186745 - KPart shows a strange menu after first rightclick in a tab
Summary: KPart shows a strange menu after first rightclick in a tab
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: CVS
Platform: Compiled Sources Unspecified
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
: 187879 196177 197963 203390 205205 206231 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-03-10 10:48 UTC by Alessandro Guido
Modified: 2009-09-04 12:29 UTC (History)
20 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
good (10.12 KB, image/png)
2009-03-10 10:49 UTC, Alessandro Guido
Details
menu appears (10.83 KB, image/png)
2009-03-10 10:49 UTC, Alessandro Guido
Details
menu clicked (16.09 KB, image/png)
2009-03-10 10:49 UTC, Alessandro Guido
Details
Patch to test with on trunk (718 bytes, patch)
2009-08-29 19:24 UTC, Kurt Hindenburg
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alessandro Guido 2009-03-10 10:48:34 UTC
Version:            (using Devel)
Installed from:    Compiled sources

Whenever I click the right button of my mouse in a yakuake tab a strange menu appears on the top left corner of the console. I'm attaching three snapshots: the first taken on a "pristine" yakuake tab, the second taken after the right clicking (look close to the top left corner, the prompt seems corrupted beacause of that menu I'm talkink about appears), the third taken when I clicked on the menu.
Comment 1 Alessandro Guido 2009-03-10 10:49:12 UTC
Created attachment 31978 [details]
good
Comment 2 Alessandro Guido 2009-03-10 10:49:40 UTC
Created attachment 31979 [details]
menu appears
Comment 3 Alessandro Guido 2009-03-10 10:49:56 UTC
Created attachment 31980 [details]
menu clicked
Comment 4 Eike Hein 2009-03-10 13:00:41 UTC
As the terminal area and its context menu are provided by the Konsole KPart component which Yakuake embeds (and the Yakuake code also hasn't changed in any relevant way), I'm reassigning this bug to Konsole.

FWIW, this is similar to a KXMLGUI-related bug that reared its head in Konsole before.
Comment 5 Eike Hein 2009-03-10 13:04:46 UTC
Rename for clarity.
Comment 6 Alessandro Guido 2009-03-10 13:06:57 UTC
(In reply to comment #4)
> As the terminal area and its context menu are provided by the Konsole KPart
> component which Yakuake embeds (and the Yakuake code also hasn't changed in any
> relevant way), I'm reassigning this bug to Konsole.
> 
> FWIW, this is similar to a KXMLGUI-related bug that reared its head in Konsole
> before.

You're right, dolphin's terminal panel shows the same behaviour.
Comment 7 Eugene Shalygin 2009-03-25 14:20:13 UTC
I would like to note, that this strange menu is ordinal Konsole menu, but all top-level items has no text. Also, Oxygen and Skulpture styles does not show that menu at all, whyle all other styles installed on my machine (including Qt styles such as Cleanlooks and so) do. However, they do that in different way: QtCurve draws vertical context menu, Bespin draws usual horizontal menu, Cleanlooks draws series of black rectangles and so on.
Comment 8 Eike Hein 2009-03-25 14:26:03 UTC
Personally, I'm seeing this with the Oxygen style as well.
Comment 9 Christian Trippe 2009-06-05 15:09:09 UTC
I have the same problem in kate and kile.
Comment 10 Eike Hein 2009-06-12 16:57:48 UTC
*** Bug 196177 has been marked as a duplicate of this bug. ***
Comment 11 Eike Hein 2009-06-27 01:49:23 UTC
*** Bug 197963 has been marked as a duplicate of this bug. ***
Comment 12 Eike Hein 2009-08-03 00:50:03 UTC
I just noticed the KPart context menu has changed in 4.3.0; the "Scrollback" sub-menu is missing now. Since I believe this bug here is an XMLGUI issue I think it's related.
Comment 13 Eike Hein 2009-08-11 16:45:02 UTC
*** Bug 203390 has been marked as a duplicate of this bug. ***
Comment 14 Felipe Ortiz C. 2009-08-17 18:44:23 UTC
Same problem, right click show tab in left corner. Tested in Dolphin, Kate and Yakuake. Konsole is not affected
Comment 15 Nikos Chantziaras 2009-08-21 04:19:35 UTC
Same here on Gentoo, KDE 4.3.0.
Comment 16 Andrey Rakhmatullin 2009-08-22 12:57:59 UTC
Same here, appeared with 4.3.0.
Comment 17 Eike Hein 2009-08-26 16:23:05 UTC
*** Bug 205205 has been marked as a duplicate of this bug. ***
Comment 18 jarauh 2009-08-26 16:30:02 UTC
Can't someone put the keyword "Yakuake" into the title of this bug? Otherwise I guess more duplicates will continue to flow in...
Comment 19 Eike Hein 2009-08-26 16:34:35 UTC
It's not a Yakuake bug. It's in Konsole, and affects any application using the Konsole KPart component (Kate, Dolphin, KDevelop ...).
Comment 20 Juan Carlos Torres 2009-08-26 16:38:58 UTC
And in Konversation as well (just to add to the growing list of apps hit by this bug).
Comment 21 Kurt Hindenburg 2009-08-29 07:50:13 UTC
In SessionController.cpp, the following makes konsole part work.  I'll have to research this more.  Does anyone know if KDE 4.1.x had this issue as well?

//#ifdef KONSOLE_PART
    setXMLFile("konsole/partui.rc");
//#else
//    setXMLFile("konsole/sessionui.rc");
//#endif
Comment 22 Kurt Hindenburg 2009-08-29 07:50:33 UTC
*** Bug 187879 has been marked as a duplicate of this bug. ***
Comment 23 Nikos Chantziaras 2009-08-29 07:58:38 UTC
(In reply to comment #21)
> Does anyone know if KDE 4.1.x had this issue as well?

I don't think so. At least there never was a stray menu in Yakuake.
Comment 24 SErgio BELKin 2009-08-29 16:05:44 UTC
Same here on Mandriva 2009.1
Comment 25 Kurt Hindenburg 2009-08-29 19:24:17 UTC
Created attachment 36561 [details]
Patch to test with on trunk

This appears to work with Konsole and Konqueror on trunk.  The issue (I think) is that the #defines don't work and I'm not sure when they last did.

Let me know if it works for you and of course if there is a better way.
Comment 26 Sterling Christensen 2009-08-30 17:32:25 UTC
Kurt V. Hindenburg's patch (in comment #25) works here on 4.3.0 with Gentoo.
Comment 27 Robert Knight 2009-08-30 17:36:40 UTC
The problem probably relates to the fact that the Konsole part and the main application used to be build separately with no code in a common shared library.  I believe this changed so that the shared code is now in libkonsoleprivate.  

Kurt - I suggest moving the part/application test into an "isKonsolePart()" method or similar and then committing the patch.  There might be other #ifdef KONSOLE_PART checks elsewhere in the code which need to be addressed as well.
Comment 28 Kurt Hindenburg 2009-08-31 02:10:17 UTC
SVN commit 1017600 by hindenburg:

Correct KPart issue where the wrong context menu was used and invalid menus were created.

BUG: 186745


 M  +13 -6     SessionController.cpp  
 M  +3 -0      SessionController.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1017600
Comment 29 Eike Hein 2009-08-31 02:12:59 UTC
This should be backported to the 4.3 branch.
Comment 30 Kurt Hindenburg 2009-08-31 02:20:18 UTC
SVN commit 1017603 by hindenburg:

Correct KPart issue where the wrong context menu was used and invalid menus
were created.

CCBUG: 186745


 M  +13 -6     SessionController.cpp  
 M  +3 -0      SessionController.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1017603
Comment 31 Diego Schulz 2009-09-01 21:17:10 UTC
Apparently the problem persists, at least in Ubuntu's recently released 4.3.1 packages.

Please take a look at the snapshot in
http://i27.tinypic.com/2mqmc0n.png
Comment 32 Kurt Hindenburg 2009-09-02 17:13:50 UTC
I believe my patch was a few days after the tagging of 4.3.1.  So you'll have to wait until 4.3.2.
Comment 33 Felipe Ortiz C. 2009-09-02 18:28:16 UTC
I test 4.3.1 in ArchLinux and problem does not exist.
Comment 34 Eike Hein 2009-09-02 19:39:11 UTC
I've talked Fedora into adding the patch to their 4.3.1 packages, FWIW.
Comment 35 Dror Levin 2009-09-02 22:48:30 UTC
This patch is applied to the 4.3.1 packages in Gentoo.
Comment 36 Todd Partridge 2009-09-03 01:16:47 UTC
Thanks devs, can confirm fix on Arch linux.
Comment 37 Christophe Marin 2009-09-04 12:22:34 UTC
*** Bug 206231 has been marked as a duplicate of this bug. ***