Bug 186672 - Zoom slider should change amount of pictures, not picture size directly
Summary: Zoom slider should change amount of pictures, not picture size directly
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Thumbs-Image (show other bugs)
Version: 0.10.0
Platform: Ubuntu Unspecified
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-09 14:56 UTC by Dotan Cohen
Modified: 2013-12-04 17:11 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 4.0.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dotan Cohen 2009-03-09 14:56:38 UTC
Version:            (using KDE 4.2.0)
Installed from:    Ubuntu Packages

In the Thumbnails view of Digikam one can move the zoom slider to change the size of the thumbnails, and by changing the size of the thumbnails one can fit more or less thumbnails on a row. However, this lets the user choose thumbnail sizes that are smaller than the largest possible size for a given number of thumbnails per row. Thus, the slider should change the amount of thumbnails per row (and according to that have the size of the thumbnails generated) as opposed to changing the size of the thumbnails (and according to that have the amount of thumbnails per row).

For instance, if the row is 1000 px wide then the slider should only make thumbnails of 500, 333, 250, 200, 166, 142, 125, 111, and 100 pixels wide. Thumbnails of width 255 are useless: they show less information than thumbnails of width 333, but no more of them fit on a row than thumbnails of width 333.

Of course, I am not taking into account the borders and margins, and the real algorithm for determining legal thumbnail widths should account for this.
Comment 1 caulier.gilles 2011-12-12 12:23:38 UTC
Git commit 930c91ce25c6a90fd18e045ad665dd784f0b6291 by Gilles Caulier.
Committed on 12/12/2011 at 13:20.
Pushed by cgilles into branch 'master'.

in icon-view mode, zoom button named "Fit to Window" can be used now to fill all icon rows with thumb contents automaticaly. The right thumbs size is computed accordingly with space available...
CCBUGS: 186672

M  +9    -3    digikam/items/digikamimageview.cpp
M  +3    -2    digikam/items/digikamimageview.h
M  +59   -0    digikam/items/imagedelegate.cpp
M  +2    -0    digikam/items/imagedelegate.h
M  +9    -1    digikam/views/digikamview.cpp
M  +1    -1    libs/widgets/common/dzoombar.cpp

http://commits.kde.org/digikam/930c91ce25c6a90fd18e045ad665dd784f0b6291
Comment 2 caulier.gilles 2013-12-04 17:11:38 UTC
I just checked Dolphin and Gwenview. None of both adjust icon-view item size by number of items by line.

With my commit #930c91ce25c6a90fd18e045ad665dd784f0b6291 you can optimize space used by icon on a line by press "Fit to Window" button on status-bar.

It's enough for digiKam...

Gilles Caulier