Bug 186483 - make cable animation time configurable
Summary: make cable animation time configurable
Status: RESOLVED FIXED
Alias: None
Product: knetwalk
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Microsoft Windows Unspecified
: VLO wishlist
Target Milestone: ---
Assignee: Ashwin Rajeev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-07 19:30 UTC by Markus
Modified: 2013-10-12 20:55 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.12


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus 2009-03-07 19:30:04 UTC
Version:            (using KDE 4.2.1)
Installed from:    MS Windows

Currently the time for the animation of the cables is a fixed constant set in globals.h, int const AnimationTime = 400;
Is it possible to add a page to the settings dialog to configure this value? I'd like them way faster, but my grandmother approves of this speed (yes she uses KDE!). Maybe on the same page also make it possible to change HoveredCellColor and LockedCellColor?
Comment 1 Mark Rose 2009-04-03 16:05:28 UTC
Indeed. Having played thousands of games, the slow animation speed of the new version greatly slows me down. It takes the fun out of the game.
Comment 2 Parker Coates 2009-04-03 17:11:13 UTC
I don't really see how the animation speed could slow you down, so why would you care about how fast the animation occurs. You don't have to wait for the animation to finish before moving on. In fact, you can even lock pieces while they're still moving.

Maybe I'm missing something. Could you explain further?
Comment 3 Mark Rose 2009-04-03 17:16:39 UTC
Ahh, I didn't know you could lock pieces while they're moving. It would still be nice if the animation weren't so slow though, as it slows down making visual connections. I really enjoyed KNetWalk in KDE 3.5.
Comment 4 Markus 2009-04-05 03:26:34 UTC
See #167588 for a patch.
Comment 5 Albert Astals Cid 2009-05-12 00:02:16 UTC
Hi, KDE is in deep freeze preparing the KDE 4.3 release, could you please ping this bug after 4.3 release so we evaluate your patch? Sorry for not acting faster.
Comment 6 Markus 2009-05-19 21:55:13 UTC
Of course, no problem with me.
Comment 7 Markus 2009-08-11 12:01:51 UTC
I'm on holidays for two weeks now, when I'll be back there'll be an updated patch. So don't hurry in fixing this.
Comment 8 Markus 2009-08-30 19:56:31 UTC
I'm back again; see #167588 for an updated patch.
Comment 9 Markus 2009-09-13 22:11:45 UTC
There is a review now at http://reviewboard.kde.org/r/1597/.
Comment 10 Ashwin Rajeev 2013-10-05 07:13:00 UTC
Git commit 41c95b4fab19f0ed6906fa7157a16b4ccef49cb0 by Ashwin Rajeev.
Committed on 06/09/2013 at 08:48.
Pushed by rajeev into branch 'master'.

Auto lock and custom rotate duration
Related: bug 167588

M  +1    -1    src/CMakeLists.txt
M  +6    -0    src/customgame.ui
M  +11   -0    src/gameview.cpp
M  +2    -0    src/gameview.h
C  +25   -18   src/general.ui [from: src/customgame.ui - 060% similarity]
M  +12   -2    src/knetwalk.kcfg
M  +1    -4    src/knetwalkui.rc
M  +16   -11   src/mainwindow.cpp
M  +0    -1    src/mainwindow.h
M  +1    -1    src/qml/Cable.qml
M  +5    -0    src/qml/main.qml

http://commits.kde.org/knetwalk/41c95b4fab19f0ed6906fa7157a16b4ccef49cb0