Bug 185590 - save dialog: redesign the workflow when canceling overwrite
Summary: save dialog: redesign the workflow when canceling overwrite
Status: REPORTED
Alias: None
Product: kdelibs
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 4.2
Platform: openSUSE Unspecified
: NOR wishlist
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-26 11:12 UTC by Maciej Pilichowski
Modified: 2009-06-08 23:56 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Pilichowski 2009-02-26 11:12:11 UTC
Version:            (using KDE 4.2.0)
Installed from:    SuSE RPMs

User is about to point out the file for saving data. The problem is when the file already exists. Currently the dialog shows up with text if user really wants to overwrite the data and the buttons
[ overwrite ] [ cancel ]

The problem is the overwrite answer is for confirmation overwrite but cancel is not for canceling overwrite, but for canceling save. This is wrong because if user would like to cancel the saving, he/she could do this in the save dialog. And this answer is about canceling overwrite.

So please redesign the workflow -- after pressing "cancel" the save dialog should appear again. This is not only important from the UI perspective, but also have some practical impact:
a) konqueror saving data from server with ticket mechanism -- the moment you click save, you obtain the ticket, canceling the saving causes loosing the ticket
b) the save-on-exit mechanism -- with current design of the workflow it is harder to provide reliable and user-friendly mechanism of it
Comment 1 Dario Andres 2009-06-07 23:14:25 UTC
Something about this:

If the application use the default KFileDialog overwrite prompt (KFileDialog::setConfirmOverwrite()), if you select an already existing file, the "Overwrite" message box appears over the file dialog, *without closing it*; so if you cancel the Overwrite, you will be again on the dialog. This is the expectable and what you are asking for.

However, if the application do not use this default overwrite prompt and implements its own version; at first it will launch the save dialog, then when the file was selected, the dialog will close and the application will do the check for existing file and it will launch the overwrite dialog if needed. Of course in this case, canceling the overwrite you won't get the save dialog again.

So, this is not a kdelibs issue, but a issue on every Kde app implementation.
Kate/KWrite is an example of this behaviour.

The best approach will be:
- File a bug report for every app which shows this behaviour.
- May be close this report (or not, and use it to centralize all the other issues)

What do you think?
Regards
Comment 2 Maciej Pilichowski 2009-06-08 11:14:33 UTC
You are right, but before closing this one I think it should be handled in general. Two issues:
a) can you name an app which behaves correctly?
b) is it good that kdelibs let application to run save dialog without overwrite confirmation? Can you (or anyone) describe the case when save dialog w/o confirmation is good UI?

ad.b) if there is no such case it is kdelibs issue, to remove the ability to run save dialog in such mode (w/o overwrite confirmation)
Comment 3 Dario Andres 2009-06-08 14:06:03 UTC
a) KFind results save dialog. I have not yet searched for another apps
b) Probably not... the file dialog should always be launched with this confirm overwrite setting enabled. But some applications may need something special with this overwrite action and they will need to use their custom procedure.

BTW: we are discussing how to address this issue (both on kdelibs and on kde-apps) on: http://lists.kde.org/?l=kde-devel&m=124441282615654&w=2
http://lists.kde.org/?l=kde-core-devel&m=124441472417551&w=2
We can't change the behaviour of the current functions(nor modify its parameters), but we can add new functions and encourage the developers to use them and to avoid the custom overwrite file procedure if it is not needed at all.

Regards
Comment 4 Maciej Pilichowski 2009-06-08 17:25:20 UTC
a) I mean -- app which uses kdelibs confirmation mechanism, kfind simply overwrites file (two new reports filled, so thank you for the hint :-D)

b) thank you for the link, ok, so let's keep this one open as a report for new function and I post reports for apps which misbehave right now anyway
Comment 5 Dario Andres 2009-06-08 23:56:54 UTC
I fixed a) some time ago on 4.3 during a major redesign. (actually KFind needs a maintainer)
Thanks