Bug 185492 - kdelibs does not build against uclibc due to lack of dn_skipname
Summary: kdelibs does not build against uclibc due to lack of dn_skipname
Status: RESOLVED WORKSFORME
Alias: None
Product: kdelibs
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-25 05:07 UTC by Ryan Hope
Modified: 2023-01-07 05:25 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Add dn_skipname if __UCLIBC__ (3.83 KB, patch)
2009-02-25 05:08 UTC, Ryan Hope
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Hope 2009-02-25 05:07:23 UTC
Version:            (using Devel)
OS:                Linux
Installed from:    Compiled sources

Uclibc does not implement dn_skipname() in libresolv so kdelibs... particularlly, kio/misc/kpac/discovery.cpp fails to build against uclibc
Comment 1 Ryan Hope 2009-02-25 05:08:41 UTC
Created attachment 31626 [details]
Add dn_skipname if __UCLIBC__

This patch allows kdelibs to be built against uclibc...
Comment 2 Ryan Hope 2009-02-26 18:38:11 UTC
anything gonna happen with this?
Comment 3 Allen Winter 2009-02-26 23:02:11 UTC
this should go into kdefakes and not into kio/misc/kpac

additionally, we shouldn't check against _UCLIBC_.
we should do a cmake ConfigureCheck for dn_skipname and only
compile the fakes version if HAVE_DN_SKIPNAME is 0

please see kdecore/fakes.c, kdecore/kdefakes.h.cmake, and the top-level ConfigureChecks.cmake and make a new patch based on these.
Comment 4 Ryan Hope 2009-02-26 23:34:45 UTC
thanks, i figured you wanted it in cmake but I am a cmake noob and couldnt figure out how to detect __UCLIBC__ from cmake... I will look at what you suggested and submit a new patch
Comment 5 David Faure 2009-09-17 18:01:51 UTC
Checking for UCLIBC would be
 check_symbol_exists(__UCLIBC__ "stdlib.h" HAVE_UCLIBC).
But that's the wrong way to go about this.
Better check whether dn_skipname is available, and define it in fakes.c if not. That's a more general fix, which will work for all systems that might be missing dn_skipname.

So better do this in ConfigureChecks.cmake :
check_function_exists(dn_skipname HAVE_DN_SKIPNAME)
check_prototype_exists(dn_skipname HAVE_DN_SKIPNAME_PROTO)
and then in kdefakes.h.cmake and fakes.c, do like all other functions do there ;)
Comment 6 Andrew Crouthamel 2018-11-02 22:54:37 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 7 Andrew Crouthamel 2018-11-16 02:48:38 UTC
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version?

Thank you for helping us make KDE software even better for everyone!
Comment 8 Justin Zobel 2022-12-08 23:51:13 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 9 Bug Janitor Service 2022-12-23 05:22:30 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 10 Bug Janitor Service 2023-01-07 05:25:14 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!