Bug 184852 - kde don't assign any icon to external mime type
Summary: kde don't assign any icon to external mime type
Status: RESOLVED FIXED
Alias: None
Product: kdelibs
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Other
: NOR normal
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-18 21:59 UTC by Kamil Neczaj
Modified: 2009-02-25 10:38 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
It's the tuxguitar mime file which for me is placed in /usr/share/mime/packages (532 bytes, text/xml)
2009-02-18 22:01 UTC, Kamil Neczaj
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kamil Neczaj 2009-02-18 21:59:09 UTC
Version:            (using KDE 4.2.0)
OS:                Other
Installed from:    Unlisted Binary Package

I have installed "Tuxguitar" which is guitar tabulature editor for linux. It installs new mime types in the system: GuitarPro, PowerTab and TuxGuitar files. Clicking on any of these file types run tuxguitar as intended, but every file of these mimetypes has icon with "?" instead of generic audio icon. In gnome everything works ok and every of these mimes has the icon with note.

You can download tuxguitar from:
http://www.tuxguitar.com.ar/

Below I've attached the mime file.
Comment 1 Kamil Neczaj 2009-02-18 22:01:18 UTC
Created attachment 31450 [details]
It's the tuxguitar mime file which for me is placed in /usr/share/mime/packages
Comment 2 David Faure 2009-02-20 01:47:40 UTC
SVN commit 928749 by dfaure:

My previous commit (r928748) implemented support for generic icons. Unittest added for audio/x-tuxguitar: works now (will be in 4.3).
BUG: 184852


 M  +1 -0      kiconloader_unittest.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=928749
Comment 3 Kamil Neczaj 2009-02-25 02:12:37 UTC
I haven't tested it yet, but are you sure you fixed all of three mime types: audio/x-gtp, audio/x-ptb and audio/x-tuxguitar? I see only x-tuxguitar in your commit, but maybe i've missing something ;).

Isn't hard-coding of all these generic icons only a workaround? Shouldn't there be something more flexible? I really doubt that this mime icon is hardcoded in gnome, but maybe kde uses it only as temporary solution. Could you explain it?
Comment 4 David Faure 2009-02-25 10:38:10 UTC
Yes, that mimetype was just a test, it will work just the same with the other two. The generic icon is NOT hardcoded for each mimetype in kiconloader, it's determined from name audio/whatever. The fact that you see tuxguitar in my commit it just because of a unittest that needed an example. But the code is generic, it fallsback to audio/x-generic for any audio/whatever mimetype without a specific icon. As specified in the shared-mime-info spec. This seems fully flexible to me, I don't understand your concern.