Bug 184731 - Cannot apply inpainting, it just hangs
Summary: Cannot apply inpainting, it just hangs
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Editor-GmicQt (show other bugs)
Version: 0.10.0
Platform: unspecified Linux
: NOR crash
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-18 00:01 UTC by Anders Lund
Modified: 2023-03-23 09:41 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 5.8.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Lund 2009-02-18 00:01:37 UTC
Version:           0.10.0-rc2 (rev.: 917004) (using 4.2.00 (KDE 4.2.0), Arch Linux)
Compiler:          gcc
OS:                Linux (x86_64) release 2.6.28-ARCH

Being a fan of the inpainting plugin, I am sorry that since rc1 I have not been able to apply it.
Pressing OK apply, it just hangs for a moment, then the buttons becomes enabled, but the process never takes place.
Comment 1 caulier.gilles 2009-02-18 12:41:46 UTC
SVN commit 927749 by cgilles:

kill current thread with multithreaded Editor Tools when slotAbort() is called
CCBUGS: 184731


 M  +5 -1      editortool.cpp  
 M  +1 -1      editortool.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=927749
Comment 2 caulier.gilles 2009-02-18 12:45:06 UTC
SVN commit 927752 by cgilles:

kill current thread with multithreaded Editor Tools when slotAbort() is called
CCBUGS: 184731


 M  +5 -1      editortool.cpp  
 M  +1 -1      editortool.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=927752
Comment 3 caulier.gilles 2009-02-18 12:48:02 UTC
Anders,

KDE3 and KDE4 are patched. please try again

Gilles
Comment 4 Anders Lund 2009-02-18 18:53:54 UTC
Hi Gilles,
I did svn up (trunk), make and make install, but it does not work. The aboutbox says rev 917004, is that correct?
Comment 5 Andi Clemens 2009-02-18 18:59:23 UTC
latest revision should be 927957
Comment 6 Anders Lund 2009-02-18 19:17:13 UTC
Andi, would that be in the about box?
Svn says I am at rev. 927987.
I did do make install, and my digikam binary is from when I installed.
Comment 7 Anders Lund 2009-02-19 11:20:39 UTC
I updated again, and this time I noticed that the inpainting plugin was rebuilt.

The state is that I can get the filter to apply, if I stop the automatic preview run and press OK. This may however have been the case before, as I just let that run.

If the preview is finished, pressing OK leaves the plugin "dialog" open, and having to press Cancel to dismiss it, I cannot get the filter to apply.
Comment 8 caulier.gilles 2009-02-19 14:04:11 UTC
SVN commit 928363 by cgilles:

as inpainting is already computed, call righ slot and end when user press Ok.
CCBUGS: 184731


 M  +1 -2      inpaintingtool.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=928363
Comment 9 caulier.gilles 2009-02-19 14:08:35 UTC
SVN commit 928367 by cgilles:

sync with 0.11 branch
CCBUGS: 184731


 M  +1 -2      inpaintingtool.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=928367
Comment 10 caulier.gilles 2009-02-19 15:05:56 UTC
SVN commit 928401 by cgilles:

sync with trunk
BUG: 184731


 M  +1 -1      imageplugin_inpainting.cpp  
 M  +1 -1      imageplugin_inpainting.h  
 M  +7 -5      inpaintingtool.cpp  
 M  +1 -1      inpaintingtool.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=928401
Comment 11 Anders Lund 2009-02-19 15:52:51 UTC
Yes, I updated and it works, Thanks a lot!
Comment 12 caulier.gilles 2017-09-05 05:10:07 UTC
With 5.8.0, in-painting image editor tool was been replaced by a Clone tool.

More details here : 

https://community.kde.org/GSoC/2017/StatusReports/shazaismailkaoud

Gilles Caulier