Version: (using Devel) OS: Linux Installed from: Compiled sources As the description. After upgrading to Qt4.5 it is impossible to get kipi-plugin compiled. Errors attached.
Created attachment 31303 [details] the errors i get compiling kipi-plugins
I can confirm the error, but it looks like a problem in Qt 4.5 uic; the problem has been reported on qt-preview-feedback. I will keep you informed what the exact cause is.
Created attachment 31349 [details] Patch to avoid uic problem I've found an ugly workaround to avoid the problem, that should work also with old qt4.x (x<5). I do hope qt fixes the problem but by now this should work.
works OK for me
Created attachment 31473 [details] Patch (workaround) to avoid uic problem Here's a cleaned up version of the patch (without irrelevant changes).
Created attachment 31474 [details] 31473: Patch (workaround) to avoid uic problem Oops, I was missing a required line (lost in the mess of unrelated XML reformatting). This one should actually work.
Created attachment 31475 [details] Patch (workaround) to avoid uic problem Hopefully the third one is the good one. ;-) Fixed my whitespace, also removed unneeded changes from one of the changed lines.
And compilation work again with Qt4.4 ? Gilles
sorry, i want mean Qt 4.4 and KDE 4.1.x ? Gilles
I believe if the old one worked for you it should this one also :) The removed lines are the one qt 4.5 assistant added/changed. In any case the workaround is silly, i added a file with a redefinition of Phonon::VolumeSlider and used a local file into ui instead of the global one :) Angelo
For the record why "unneeded" changes were so bad? (I'm usually against to change ui files by hands....)
This is why i hate to work with ui files. why this must require a change like this ? Gilles Caulier
Laurent Montel has just commited a patch in svn: SVN commit 930363 by mlaurent: Add patch from #184332 to allow to compile it M +3 -3 playbackwidget.ui A volslider.h [License: UNKNOWN] --- trunk/extragear/graphics/kipi-plugins/advancedslideshow/playbackwidget.ui #930362:930363 @@ -107,7 +107,7 @@ </layout> </item> <item> - <widget class="Phonon::VolumeSlider" native="1" name="m_volumeSlider" > + <widget class="VolSlider" native="1" name="m_volumeSlider" > <property name="sizePolicy" > <sizepolicy vsizetype="Preferred" hsizetype="Expanding" > <horstretch>0</horstretch> @@ -132,9 +132,9 @@ </widget> <customwidgets> <customwidget> - <class>Phonon::VolumeSlider</class> + <class>VolSlider</class> <extends>QWidget</extends> - <header location="global" >Phonon/VolumeSlider</header> + <header>volslider.h</header> <container>1</container> </customwidget> </customwidgets> Please test and give feedback. Thanks in advance Gilles Cauleir
all compile fine here with Qt 4.4 and KDE 4.1.3: [gilles@pc-caulier advancedslideshow]$ make [ 33%] Building CXX object kipi-plugins/common/libkipiplugins/CMakeFiles/kipiplugins.dir/kpaboutdata.o Linking CXX shared library ../../../lib/libkipiplugins.so [ 33%] Built target kipiplugins [ 33%] Generating ui_playbackwidget.h Generating slideshow.moc [ 33%] Generating ui_captiondialog.h Scanning dependencies of target kipiplugin_advancedslideshow [ 33%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/common.o [ 33%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/kbeffect.o [ 33%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/slideshowkb.o [ 33%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/imageloadthread.o [ 66%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/maindialog.o [ 66%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/captiondialog.o [ 66%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/soundtrackdialog.o [ 66%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/advanceddialog.o [ 66%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/playbackwidget.o [ 66%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/slideshow.o [ 66%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/slideshowconfig.o [ 66%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/slideshowgl.o [ 66%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/plugin_advancedslideshow.o Linking CXX shared module ../../lib/kipiplugin_advancedslideshow.so [100%] Built target kipiplugin_advancedslideshow Gilles Caulier
Compile fine too with KDE 4.2 and Qt 4.4: [gilles@localhost kipi-plugins]$ [gilles@localhost advancedslideshow]$ make [ 33%] Built target kipiplugins [ 33%] Generating ui_playbackwidget.h Generating slideshow.moc [ 33%] Generating ui_captiondialog.h Scanning dependencies of target kipiplugin_advancedslideshow [ 33%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/common.o [ 33%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/kbeffect.o [ 66%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/slideshowkb.o [ 66%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/imageloadthread.o [ 66%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/maindialog.o [ 66%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/captiondialog.o [ 66%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/soundtrackdialog.o [ 66%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/advanceddialog.o [ 66%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/playbackwidget.o [ 66%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/slideshow.o [ 66%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/slideshowconfig.o [ 66%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/slideshowgl.o [ 66%] Building CXX object kipi-plugins/advancedslideshow/CMakeFiles/kipiplugin_advancedslideshow.dir/plugin_advancedslideshow.o Linking CXX shared module ../../lib/kipiplugin_advancedslideshow.so [100%] Built target kipiplugin_advancedslideshow Someone can check with Qt 4.5 now ? Gilles Caulier
(In reply to comment #15) > Someone can check with Qt 4.5 now ? > > Gilles Caulier Doing it right now. Will report in 10 minutes.
(In reply to comment #16) > (In reply to comment #15) > > > Someone can check with Qt 4.5 now ? > > > > Gilles Caulier > > Doing it right now. Will report in 10 minutes. It is compiling now (and working ;)). So i'm closing the bug as fixed. Thanks!
This looks like the relevant qt bug: http://www.qtsoftware.com/developer/task-tracker/index_html?method=entry&id=244998
Gilles since it is a qt 4.5 rc1 bug, and should be fixed in final shouldn't be better leaving this bug open and leaving the patch as a workaround for packagers? I mean that should be fixed upstream soon and mine is a ugly workaround...
I set fixed by upstream. Gilles