Bug 184323 - Memory warning when an image is modified
Summary: Memory warning when an image is modified
Status: RESOLVED FIXED
Alias: None
Product: gwenview
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Gwenview Bugs
URL:
Keywords:
: 265799 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-02-14 17:56 UTC by Hikaru
Modified: 2012-10-19 13:26 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Patch fixing the "Memory warning" problem for systems with more than 2GB RAM (733 bytes, patch)
2011-02-01 21:05 UTC, Wolfgang Lorenz 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Hikaru 2009-02-14 17:56:08 UTC 
Version:            (using KDE 4.2.0)
OS:                MS Windows
Installed from:    MS Windows

Open an image with Gwenview and try to modify it (resize or cut it). A warning appears with Save, Save all and Undo/Redo buttons. This warning says:

"Many images have been modified. You should save your changes to not have memory problems"

(I'm sorry, this could not be the correct English translation of the message).

This warning appears both if I have only one and more than one images in the working directory.
Memory usage doesn't seem to increase a lot.
Comment 1 Aurelien Gateau 2009-03-02 19:03:52 UTC 
There is work going on about providing more precise cross-platform memory usage. Hopefully this will be fixed in Gwenview 2.3 (KDE4.3).
Comment 2 FiNeX 2009-08-10 21:32:23 UTC 
This bug has been fixed on more recent versions. It is fixed on 4.2.95 windows version too.
Comment 3 Wolfgang Lorenz 2010-10-30 21:04:51 UTC 
This bug does still occur in version 4.5.2. Is it possible, that Gwenview has problems, if you have more than 4GB RAM? (integer overflow?) I first experienced this, when I upgraded my system to 6 GB RAM and switched to a PAE-Kernel on a 32 bit system. Now I'm working with an 64 bit system and still see this problem.

Greetings...

Version: 2.5.2
DE: KDE 4.5.2
OS: Ubuntu 10.10
Comment 4 Harald Hvaal 2011-01-31 18:32:39 UTC 
Same problem here, with 4.5.1. I have 8 gb of ram, and no swap space enabled at all. I see the warning message after rotating just a single image. Reopen?
Comment 5 Wolfgang Lorenz 2011-02-01 21:05:00 UTC 
Created attachment 56758 [details]
Patch fixing the "Memory warning" problem for systems with more than 2GB RAM

Hi, there!

Today I had a look at the memory calculations in Gwenview and found, that they are done using type int, which overflows after 2GiB. I changed it to qulonglong (quint64), which is working fine for me.

The patch is against [svn-something]/tags/KDE/4.6.0/kdegraphics/

Greetings...
Comment 6 Aurelien Gateau 2011-02-05 10:40:49 UTC 
SVN commit 1218969 by gateau:

Do not use int to hold memory count

int overflows after 2GB.
Patch from Wolfgang Lorenz, thanks!

BUG:184323

 M  +2 -2      savebar.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1218969
Comment 7 Aurelien Gateau 2011-02-05 10:43:37 UTC 
SVN commit 1218970 by gateau:

Do not use int to hold memory count

int overflows after 2GB.
Patch from Wolfgang Lorenz, thanks!

CCBUG:184323

Backported to 4.6 branch.

 M  +2 -2      savebar.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1218970
Comment 8 Aurelien Gateau 2011-02-14 11:22:41 UTC 
*** Bug 265799 has been marked as a duplicate of this bug. ***