Bug 183108 - View mode: mouse zoom and pan
Summary: View mode: mouse zoom and pan
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-Mouse (show other bugs)
Version: 0.10.0
Platform: Ubuntu Unspecified
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-04 01:29 UTC by Dotan Cohen
Modified: 2017-08-06 09:41 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In: 1.1.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dotan Cohen 2009-02-04 01:29:55 UTC
Version:            (using KDE 4.2.0)
Installed from:    Ubuntu Packages

Currently, one can click a thumbnail and go to View mode, then click the photo in View mode to go back to thumbnails. I suggest that this behaviour be retained but with an improvement:
When the user operates the scrollwheel over the photo in View mode, the photo would zoom in and out according to the scroll direction. Once zoomed in (so that there are scrollbars) then the mouse click would pan the photo. To return to thumbnails, the user would either double click the photo or use the keyboard shortcut

The zoom/pan behaviour that I describe is how Eye of Gnome works, and it is very intuitive and easy to operate.
Comment 1 Dotan Cohen 2009-03-09 14:46:37 UTC
I had the chance to introduce a Windows convert to digikam today. Sure enough, she moved the mouse wheel expecting it to scroll. After learning to scroll with the slider, she went right up and clicked the photo, expecting to be able to pan.
Comment 2 Vlado Plaga 2009-03-23 22:14:22 UTC
This is pretty much a dublicate of
http://bugs.kde.org/show_bug.cgi?id=148235

It is a good description, though, and I do support this wish!
Comment 3 Sherwood Botsford 2009-04-05 18:51:50 UTC
Pan and zoom are both desirable not only in view mode, but it edit mode.

The use of a single click to dismiss the view is counter intuitive to me.
I'm used to double-click.

Double click to both expand and contract would leave left mouse down to pan
and mousewheel to zoom.

Otherwise middle mouse down to pan, middle mouse wheel to zoom?
Comment 4 simon 2009-05-18 12:12:52 UTC
hi,

i wanted to add a bugreport/whishlist for the lighttable zoom/pan behaviour as it feels not intuitive the way one has to use external butoons/shortcuts for this.

what i'd like to do

* select the zoom rectangle with left mouse button (drawing a rectangle)
* zoom in/out with mouse wheel
* pan using pressed middle button

whats are the plans for this one?
Comment 5 Dotan Cohen 2009-05-18 12:23:30 UTC
Simon: please file a new bug for your feature request. Do not hijack this one, even if it looks similar. Thanks.
Comment 6 caulier.gilles 2009-05-18 12:27:38 UTC
This is the plan for preview widget (common to editor, Light table, and preview mode): Code still to use QT3 transition classes. It must be ported to Qt4 model/view. All changes will be done during code conversion.

Currently, we working to others part of digiKam to convert to Model View ,as Icon view, folder tree view, and thumbbar. when all of these will be port, digiKam will be really a pure Qt4 application.

Porting these code to Qt4 model view take a while. They are core implementation with full feature to test in regression. Please, you must be patient (:=)))

Gilles Caulier
Comment 7 caulier.gilles 2010-01-22 14:12:59 UTC
Definitivly, i would to close this file with 1.1.0 (current code from svn trunk)

- Pan is possible by middle mouse button, bottom/right corner button, and scroll bar

- Zoom is possible by mouse wheel, zoom slider, CTRL +/-

- go to back to icon view, press ESC or left cleck on preview.

Please try current code from svn.

Gilles Caulier
Comment 8 Fest 2010-01-22 14:38:33 UTC
Can you make such behavior optionally ? I mean to give choice to reassign all buttons. To be able to slide photos with mouse wheel, and move in zoomed frame with left button and etc. 
I hope this request suites to this wish-list. Thank you in advance.
Comment 9 caulier.gilles 2010-01-22 15:14:59 UTC
All is possible, but i won't, because it will be a big puzzle... At least the interface must have the same behaviors everywhere. I try to do it currently, and it's not simple.

Gilles Caulier
Comment 10 Fest 2010-01-22 15:28:53 UTC
Thank you.
I didn't meant to change default buttons behavior. Only option to reassign them. Something like "configure shortcuts" in "settings", but with possibility to change mouse click reaction in different view (collection view, photo view, zoom and etc).

Open a new wish, cause you can close this after implementing Dotan Cohen wish request ?
Comment 11 caulier.gilles 2010-01-22 15:30:43 UTC
Opening a new file is fine for me.

Gilles Caulier
Comment 12 Dotan Cohen 2010-01-22 15:58:22 UTC
Pan on _middle_mouse_button_? I hate that! The otherwise terrific fsviewer file manager does that and I cannot stand it. Please, add an option for pan (when zoomed) on left mouse button. Please!

Note that this is the intuitive behaviour expressed by most users not familiar with Digikam: just give Digikam to a new user and see how they intuitively try to pan with the _left_ mouse button. I've seen it literally over 20 times.
Comment 13 Marios Andreopoulos 2010-01-22 16:13:50 UTC
I have to agree that panning with the left button seems the most natural way.
Most image viewers I can think do that and it is the default and only behavior for KDE's gwenview so it is kind of a standard.

Personally because of this I use digikam for most of my needs but when I need to seriously view/preview photos I open gwenview which I feel has the most easy controls: pan with left click, switch between fit to view and 100% with middle click and select if the wheel will scroll between images or zoom in/out.

Another thing is laptop users. Middle click for them isn't that easy while panning.
Comment 14 caulier.gilles 2010-01-22 16:19:29 UTC
And i have a problem here, especially with editor canvas, where left mouse
button is used to make a selection not to pan image.

To have the same behavior, i used middle button everywhere, to be homogenous
with pan action. Do you understand ?

This include :

-icon view preview mode.
-light table previews.
-editor canvas
-editor tools preview.

Gilles Caulier
Comment 15 caulier.gilles 2010-01-22 16:21:10 UTC
About Laptop, i know, i has one without external mouse. this is not a problem: use pan icon widget from bottom/right corner of preview

Gilles Caulier
Comment 16 caulier.gilles 2010-01-22 16:23:17 UTC
For me left mouse button is not always the reference to pan. An example : Gimp use _also_ middle mouse button to pan. Left mouse button is delegate to tools (painting for ex).

Gilles Caulier
Comment 17 Marios Andreopoulos 2010-01-22 16:36:19 UTC
Thanks for the clarification. I respect that you try to have consistent shortcuts and controls' behavior throughout digikam suite.

Indeed image editors usually pan with the middle button but image viewers most of the time use the left button.
Comment 18 Fest 2010-01-22 16:42:22 UTC
Sorry for tiresomeness, like we see here everyone have his own opinion about
what reference is and what is more comfortable for him. 
That's why option to change defaults be the best solution to everyone. You set
up default behavior and people who don't like it - change it in settings.
Thank you.
Comment 19 Dotan Cohen 2010-01-22 17:12:42 UTC
> And i have a problem here, especially with editor canvas, where left mouse
> button is used to make a selection not to pan image.

I understand (and otherwise agree with) the desire to have consistency within the components of Digikam, but sacrificing intuition in the viewer just for the sake of consistency is ridiculous.
Comment 20 caulier.gilles 2010-01-25 14:27:04 UTC
SVN commit 1080050 by cgilles:

preview mode : 
- Do not use content left mouse bouton event to go back to album view. Use new preview tool bar or ESC key.
- Use left mouse button to pan content (middle button still available for this action too).
- Add a little toolbar on the left top corner to switch between album items and go back to album view.
BUGS: 183108


 M  +42 -38    digikam/imagepreviewview.cpp  
 M  +7 -9      libs/widgets/common/previewwidget.cpp  
 M  +1 -1      utilities/lighttable/lighttablepreview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1080050
Comment 21 Dotan Cohen 2010-01-26 16:58:14 UTC
Thank you Gilles!
Comment 22 caulier.gilles 2010-02-01 10:11:07 UTC
SVN commit 1083356 by cgilles:

use double left mouse button click to back to album in preview mode
CCBUGS: 183108



 M  +12 -9     digikam/imagepreviewview.cpp  
 M  +10 -1     libs/widgets/common/previewwidget.cpp  
 M  +2 -0      libs/widgets/common/previewwidget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1083356
Comment 23 Philipp 2010-02-01 10:44:56 UTC
sounds very nice ! looking forward to the next version :)
Comment 24 Marios Andreopoulos 2010-02-01 11:35:25 UTC
Thank you very much! All the changes sound perfect!
Comment 25 Marcel Wiesweg 2010-02-01 21:59:57 UTC
We had a lengthy discussion on the mailing list and some devs did not like specific changes here at all.
Entering into preview is done by single or double click, depending on system settings. Leaving the preview should be done the same way. System settings should be honored, not fixing either single or double click.
New users will enter preview and do not find the way out. Please also bear in mind that there is no panning at all with fit to window, thus no click action then at all.7

The suggestion was to pan when dragging with the left mouse button but to leave preview when clicking with the left mouse button.
Comment 26 Dotan Cohen 2010-02-01 22:14:04 UTC
> Entering into preview is done by single or double click, depending on
> system settings. Leaving the preview should be done the same way.

As a user whose's system is configured for single click, I respectfully disagree. I expect left mouse button to pan.



> The suggestion was to pan when dragging with the left mouse button but
> to leave preview when clicking with the left mouse button.

This might work, but I would have to try it to say for sure. I suppose if the image is panned less than N pixels, where N is some small integer in the vicinity of five, that would work.
Comment 27 caulier.gilles 2010-02-04 09:45:41 UTC
A new file is open. Dotan, Marcel, Johannes, etc... please continue this thread at this place :

https://bugs.kde.org/show_bug.cgi?id=225443

Gilles Caulier