Version: 2.2 (using 4.2.00 (KDE 4.2.0), Kubuntu packages) Compiler: cc OS: Linux (x86_64) release 2.6.27-11-generic How to reproduce: * Settings * Edit current profile * Input * Edit * Select two rows * Press remove #4 QTableWidget::row (this=0x57000000e9, item=0x332f940) at ../../include/QtGui/private/../../../src/gui/itemviews/qtablewidget_p.h:189 #5 0x00007f1a5f28e658 in QTableWidgetItem::row (this=0x332f940) at /home/kde42/qt44/include/QtGui/../../src/gui/itemviews/qtablewidget.h:356 #6 0x00007f1a5f2b256d in Konsole::KeyBindingEditor::removeSelectedEntry (this=0x3315fd0) at /home/kde42/kdebase/apps/konsole/src/KeyBindingEditor.cpp:78
I can reproduce if I select the two columns of the same row. _ui->keyBindingTable->selectedItems() will return both items, but the deletion process removes the whole row at the end, so when the loop is going to process the second item, its row is gone and it will crash. Possible solutions: - Filter the "_ui->keyBindingTable->selectedItems()" list to only have one item per row. - Do any other check to not access that item if its row does not exist
Created attachment 33986 [details] Proposed patch Filter the table items to get the unique ones (and column==0) I also tried filtering the items in the original iteration loop but it caused errors as we were accessing to dead/invalid elements. I hope indentantion and styles are OK
I can commit the patch if it gets reviewed and approved...
Hi Dario, Thanks for the patch - I think it would be simpler just to remove any items from the list returned by selectedItems() which are not in the first column before iterating over each item in the list to remove the rows. Alternatively, iterate through the selected items to create a set of selected rows then iterate through that set to remove the rows.
(In reply to comment #4) > Hi Dario, > > Thanks for the patch - I think it would be simpler just to remove any items > from the list returned by selectedItems() which are not in the first column > before iterating over each item in the list to remove the rows. > That could work if you set the selection mode to the whole row. Otherwise, user could select a binding (2° column) and it won't be deleted (as the 1° column is not selected) > Alternatively, iterate through the selected items to create a set of selected > rows then iterate through that set to remove the rows. That is what my patch is doing: creating a new list of unique rows items and then iterate normally. Regards
I fixed the issue where clicking will select the entire row in bug 183070.
SVN commit 1082422 by hindenburg: Fix crash on removing key bindings. Patch by Dario Andres BUG: 183069 M +16 -2 KeyBindingEditor.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1082422
Thanks for fixing. - Is the fix going to be backported ? Regards
*** Bug 227594 has been marked as a duplicate of this bug. ***
SVN commit 1095365 by hindenburg: Fix crash on removing key bindings. Patch by Dario Andres CCBUG: 183069 M +16 -2 KeyBindingEditor.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1095365