Bug 182911 - "Add Quote Characters" disrespects >%_ setting, always adds literal >
Summary: "Add Quote Characters" disrespects >%_ setting, always adds literal >
Status: RESOLVED FIXED
Alias: None
Product: kmail
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-02 20:01 UTC by Ronny Multrus
Modified: 2010-08-24 10:09 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ronny Multrus 2009-02-02 20:01:17 UTC
Version:            (using KDE 4.2.0)
OS:                Linux
Installed from:    Gentoo Packages

When choosing "Add Quote Characters" from a reply mail editor's "edit" menu, the selected text always gets indented with ">" only (no trailing space), no matter what is set for the current mail template (>%_ by default). I didn't have that behavior in 4.1.4.

Selecting text in a mail for quotation _before_ hitting the reply button correctly indents with "> ". It only works wrong when choosing the menu item.
Comment 1 Jaime Torres 2009-02-13 10:39:30 UTC
Confirmed in kmail 1.11.90 (kde 4.2.62) svn trunk r923448.

When I use "Add Quote Characters", it uses the Standars Template Quote Indicator, configured in the Message Composer Settings, instead of the Identity quote indicator, because I have checked the "Use custom Templates" in the identity.
Comment 2 Ronny Multrus 2009-02-13 19:24:44 UTC
Both the default template's and the custom template's quote identicators are set to ">%_" for me and it still only indents with ">" rather than with "> "...
Comment 3 Ronny Multrus 2009-05-15 17:51:13 UTC
This bug is still valid in KDE 4.2.3 and Qt 4.2.2 on Gentoo.
Comment 4 Jonathan Armond 2009-07-25 01:38:57 UTC
SVN commit 1002105 by jarmond:

Use correct quote prefix when replying, respecting global and identity
settings.

Also move formatString from kmmessage.cpp to stringutil.cpp
Also create TemplatesConfiguration::configIdString function for
obtaining custom template identifier.

BUG: 182911

 M  +2 -2      identitydialog.cpp  
 M  +22 -6     kmcomposewin.cpp  
 M  +5 -0      kmcomposewin.h  
 M  +1 -57     kmmessage.cpp  
 M  +0 -3      kmmessage.h  
 M  +52 -0     stringutil.cpp  
 M  +7 -0      stringutil.h  
 M  +1 -1      templateparser.cpp  
 M  +8 -4      templatesconfiguration.cpp  
 M  +5 -0      templatesconfiguration.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1002105
Comment 5 Ronny Multrus 2009-10-30 17:27:52 UTC
I don't think this bug is fixed as I still have this in KDE 4.3.2 and Qt 4.5.3 on Gentoo. I enter "foo" into the mail text editor, select "foo" with the mouse, then select "Edit" >  "Add Quote Characters" from the menu and the text becomes ">foo", though it should become "> foo". I have set my quote string to >%_ in all templates (grep QuoteString kmailrc|uniq yields QuoteString=>%_) so I think this bug is still valid.
Comment 6 Ronny Multrus 2010-08-24 10:09:08 UTC
Now running KDE 4.4.5, this bug no longer appears for me, all is working fine. Thank you!