Bug 180466 - closing app's window -- HIG violation
Summary: closing app's window -- HIG violation
Status: RESOLVED UNMAINTAINED
Alias: None
Product: kmail
Classification: Unmaintained
Component: composer (show other bugs)
Version: unspecified
Platform: Compiled Sources Unspecified
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
: 186922 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-01-12 16:14 UTC by Maciej Pilichowski
Modified: 2015-04-12 10:15 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Pilichowski 2009-01-12 16:14:23 UTC
Version:            (using Devel)
Installed from:    Compiled sources

closing app's window -- HIG violation

Since till now Composer is not docked within KMail main window it should be treated as standalone application -- it works that way, and looks that way, and it behaves that way.

Wait, not exactly -- HIG states that quitting app and closing document are different, distinct things. However Composer chose to use closing document as quitting main application. This is HIG violation.

Please change the label from "close" to "quit application/Composer" and use proper shortcut (ctr+q, not ctrl+w).

Note: since this violation, currently even within family there is no consistency, Composer behaves differently than main app --> KMail.
Comment 1 Jaime Torres 2009-01-13 11:38:40 UTC
Could you provide the link to the HIG part that says that?

What I've found is only:

"The control window should have a menu laid out according to the normal guidelines. This menu will probably not be the same as the menus on the document windows. The File menu will have a New entry, but no Open.

The 'Quit option of the control window' closes all the document windows (after any necessary save prompts) and exits the entire application."

at http://developer.kde.org/documentation/standards/kde/style/basics/windows.html
in the Controlled SDI section (the model kmail follows).
Comment 2 Maciej Pilichowski 2009-01-13 13:18:35 UTC
Composer can be launched from any app, like Konqueror so it is application on its own.

The document is mail content (the one you edit).

So you could close the document but without closing the app (Composer). This is one option. The other is not allowing to close the document.

Currently Composer chooses to have mixed UI -- and this is against HIG (thanks for the link, but this is old HIG):
http://techbase.kde.org/Projects/Usability/HIG/Keyboard_Shortcuts

So, whatever choice you made (1 or 2 option) it is fine. The simpler to do is of course the second, so I think it would be better to provide a quick and easy fix for this (removing closing document, introducing closing the app window).
Comment 3 Jaime Torres 2009-01-13 16:45:22 UTC
Even if the composer window can be called from any application that is able to talk D-bus, it is done executing kmail (there is no composer executable).

I see no violation using Ctrl+W to close the composer window, that is also able to quit kmail when it is called using D-bus (and is the only visible window of kmail).

Close 	 Ctrl+W 	 	 Close the current document. If there is only one document open, this shortcut "may not" (it does when called using D-bus) Close the window or Quit the application. 
If it were "must not", then you'll be right.
Comment 4 Maciej Pilichowski 2009-01-13 18:32:51 UTC
Jaime, thanks for the clarification. The meaning of HIG is

closing document (last) cannot lead to closing the main window

So reopening (as you say).
Comment 5 Jaime Torres 2009-01-16 23:42:05 UTC
Following your converstation about this bug.

http://markmail.org/message/erffx7q3dt4ldhny#query:+page:1+mid:ksdthfkx44axx7fi+state:results

Also related to bug 80981
Comment 6 Jaime Torres 2009-03-12 09:22:07 UTC
*** Bug 186922 has been marked as a duplicate of this bug. ***
Comment 7 Juha Tuomala 2009-03-12 09:45:11 UTC
I find this also quite unintuitive in cases when you have those windows (messages, SSL warnings, etc) open in other desktops and you may not have easy way to find them from 18 virtual desktops, buried under other windows.

This is even more difficult as bug 168403 (no windowlist with MMB against desktop) remains unfixed.

Using Quit causes main window to disappear - as user would expect, but still does not clear the situation/problem why user closed the application in the first place. Kmail will come back with next 'start' with same issue - not what user would expect.
Comment 8 Jaime Torres 2009-03-12 09:56:50 UTC
@Juha: Even all users know the ancient rule: "Shutdown and restart", one of the goals of kde is to not have to do that (unless for pleasure, of course), fixing all the issues the developers are aware of (by themselves or by bugreports).
Comment 9 Juha Tuomala 2009-03-12 10:14:43 UTC
(In reply to comment #8)
> Even all users know the ancient rule: "Shutdown and restart", one of the
> goals of kde is to not have to do that (unless for pleasure, of course), fixing
> all the issues the developers are aware of (by themselves or by bugreports).

This is a bug and should be fixed, in case it was not clear yet.
Comment 10 Jonathan Kolberg 2011-05-09 15:39:24 UTC
Problem is in KDEPIM 4.6 beta 5, too
Comment 11 Laurent Montel 2015-04-12 10:15:51 UTC
Thank you for taking the time to file a bug report.

KMail2 was released in 2011, and the entire code base went through significant changes. We are currently in the process of porting to Qt5 and KF5. It is unlikely that these bugs are still valid in KMail2.

We welcome you to try out KMail 2 with the KDE 4.14 release and give your feedback.