Bug 180201 - [PATCH] Tag guessing: Compress/simplify whitespace
Summary: [PATCH] Tag guessing: Compress/simplify whitespace
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Metadata Editing and Reading (show other bugs)
Version: 2.3-GIT
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-10 01:49 UTC by Nicos Gollan
Modified: 2010-08-01 11:12 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 2.3.1


Attachments
Patch against trunk that introduces tag whitespace simplification (6.07 KB, patch)
2009-01-10 01:52 UTC, Nicos Gollan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nicos Gollan 2009-01-10 01:49:58 UTC
Version:           trunk (using Devel)
OS:                Linux
Installed from:    Compiled sources

Tag creation from filenames will happily create runs of whitespace characters in tag contents. There should be an option to collapse that whitespace.
Comment 1 Nicos Gollan 2009-01-10 01:52:11 UTC
Created attachment 30078 [details]
Patch against trunk that introduces tag whitespace simplification

This adds an option for whitespace simplification to the FilenameLayoutDialog. The inside code uses QString::simplified(). That methos implies stripping, so the UI elements model that interdependency.
Comment 2 Mark Kretschmann 2009-01-10 08:51:01 UTC
Teo, could you please have a look at this patch? Thanks :)
Comment 3 Teo Mrnjavac 2009-01-10 22:51:16 UTC
There seems to be some recent b0rkage in FilenameLayoutDialog caused by a git-svn commit gone bananas that makes it hard to reliably test and apply the patch. I'd rather wait until we fix the issues before merging this, which will happen ASAP.
Comment 4 Teo Mrnjavac 2010-01-07 11:09:38 UTC
Casey, as I understand you've been doing some refactoring in FilenameLayoutDialog and related. Could you please check if this is still relevant in light of your planned changes?
Comment 5 Casey Link 2010-01-08 18:55:07 UTC
Just looking at the patch source, it doesn't affect anything I've been working on. However, I will include the patch in my upcoming changes after I test it to ensure it doesn't cause any conflicts.
Comment 6 Daniel Dewald 2010-05-13 00:47:59 UTC
This isn't really relevant anymore is it? Whitespace characters can already be removed easily.
Comment 7 Myriam Schweingruber 2010-08-01 11:12:13 UTC
Closing based on comment #6