Bug 180033 - cmake of networkmanager plasmoid does not check dependencies properly
Summary: cmake of networkmanager plasmoid does not check dependencies properly
Status: RESOLVED INTENTIONAL
Alias: None
Product: plasma4
Classification: Unmaintained
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-08 15:05 UTC by David Krapohl
Modified: 2009-03-04 21:27 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Krapohl 2009-01-08 15:05:01 UTC
Version:            (using Devel)
Compiler:          g++ (GCC) 4.3.2 
OS:                Linux
Installed from:    Compiled sources

CMakeLists.txt does not seem to check for NetworManager properly. As long as it finds libnetworkmanager it continues configuring but does generate a defective Makefile. As a result, make does not do anything.
Comment 1 David Krapohl 2009-01-08 15:06:38 UTC
Output of cmake:
david@farnsworth ~/build/kde4/plasma % make
-- Found Qt-Version 4.4.3 (using /usr/bin/qmake)
-- Found X11: /usr/lib/libX11.so                
-- Phonon Version: 4.2.80                      
-- Found KDE 4.2 include dir: /usr/include      
-- Found KDE 4.2 library dir: /usr/lib          
-- Found the KDE4 kconfig_compiler preprocessor: /usr/bin/kconfig_compiler
-- Found automoc4: /usr/bin/automoc4                                      
-- Ruby found: /usr/lib/libruby.so                                        
-- checking for one of the modules 'NetworkManager'                      
-- Configuring done                                                      
-- Generating done                                                        
-- Build files have been written to: /home/david/build/kde4/plasma

Output of "make help":
david@farnsworth ~/build/kde4/plasma/applets/networkmanager % make help
The following are some of the valid targets for this Makefile:
... all (the default if no target is provided)
... clean
... depend
... edit_cache
... rebuild_cache
... test

"make install" is missing here.
Comment 2 Aaron J. Seigo 2009-01-08 19:24:11 UTC
if there is nothing to install, no make install is generated. that's pretty straightforward.
Comment 3 David Krapohl 2009-01-08 20:13:25 UTC
And how am I supposed to find out what is missing? 
Not telling about a compile dependency doesn't seem straight forward to me.
Comment 4 Aaron J. Seigo 2009-01-08 22:28:37 UTC
in the version of cmake and kde's cmake modules i'm using here it tells me what optional modules aren't found at the end of the cmake run.
Comment 5 David Krapohl 2009-01-09 11:35:56 UTC
Ah I see. I checked out the complete plasma tree. Other plasmoids work. Maybe it is a run dependency. Might be distribution specific packaging (Arch) in networkmanager and libnetworkmanager.
Comment 6 Martin Klapetek 2009-03-04 21:27:21 UTC
Bug still persits in svn plasma NetworkManager applet revision 934409, it passes the NM or libNM check even when they're not present. It should stop and say that those libraries are missing...