Bug 179942 - Icons in mail list too large
Summary: Icons in mail list too large
Status: RESOLVED FIXED
Alias: None
Product: kmail
Classification: Applications
Component: new message list (show other bugs)
Version: 1.11.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Szymon Stefanek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-07 20:13 UTC by David Nolden
Modified: 2009-03-03 20:06 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
How it looks (162.50 KB, image/png)
2009-01-07 20:14 UTC, David Nolden
Details
How it should look (157.58 KB, image/png)
2009-01-07 20:14 UTC, David Nolden
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Nolden 2009-01-07 20:13:30 UTC
Version:            (using Devel)
OS:                Linux
Installed from:    Compiled sources

When the font-size is relatively small, the icons in the mail list are far too big in relation to the font. This leads to a lot of vertical white space, and makes the mail list a lot less functional.

I will attach a screenshot of the list in the kde4 version of kmail, and a screenshot how it should look, taken from the kde3 version.
Comment 1 David Nolden 2009-01-07 20:14:02 UTC
Created attachment 30013 [details]
How it looks
Comment 2 David Nolden 2009-01-07 20:14:26 UTC
Created attachment 30014 [details]
How it should look
Comment 3 George Kiagiadakis 2009-01-10 01:47:14 UTC
I can confirm that, although I had to change my font size to 6 in order to notice it...
Comment 4 Jaime Torres 2009-01-11 14:11:02 UTC
SVN commit 909353 by tmcguire:

Don't hardcode the icon size to 16, instead calculate it based on the size
hint and pass it around.
This allows the icons to be scaled down, which helps with small font sizes.
The icons is not made bigger than 16 yet.
BUG: 178035


 M  +143 -87   themedelegate.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=909353
Comment 5 David Nolden 2009-01-13 13:56:01 UTC
Very good! Is this backported to KDE 4.2?
Comment 6 Thomas McGuire 2009-01-13 13:58:38 UTC
> Very good! Is this backported to KDE 4.2?

I'll backport this this week eventually, during my usual backport+merge work.
Comment 7 Thomas McGuire 2009-01-19 19:37:40 UTC
SVN commit 913680 by tmcguire:

Backport r909353 by tmcguire from trunk to the 4.2 branch:

Don't hardcode the icon size to 16, instead calculate it based on the size
hint and pass it around.
This allows the icons to be scaled down, which helps with small font sizes.
The icons is not made bigger than 16 yet.
CCBUG: 178035



 M  +143 -87   themedelegate.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=913680
Comment 8 Thomas McGuire 2009-03-03 19:47:52 UTC
FYI: In trunk the situation changed a bit, the automatic resizing is gone (it was problematic), the size can now be configured with a spinbox.
Comment 9 David Nolden 2009-03-03 19:54:00 UTC
Just out of interest, why was it problematic, because of performance?
Comment 10 Thomas McGuire 2009-03-03 19:58:31 UTC
> Just out of interest, why was it problematic, because of performance?

No, the icon size wasn't calculated correctly for columns with no text (status columns). That caused various problems.
Comment 11 David Nolden 2009-03-03 20:06:22 UTC
What about QFontInfo::pixelSize() instead of using the size-hint? An option for this seems kind of exaggerated