Bug 179275 - Magic Lamp animation looks wrong when minimizing to a vertical panel
Summary: Magic Lamp animation looks wrong when minimizing to a vertical panel
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: effects-various (show other bugs)
Version: unspecified
Platform: Compiled Sources Unspecified
: LO normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
: 211483 264133 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-01-01 13:07 UTC by Bart Cerneels
Modified: 2018-06-05 20:07 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bart Cerneels 2009-01-01 13:07:58 UTC
Version:           4.1.85 (KDE 4.1.85 (KDE 4.2 Beta2)) (using Devel)
Installed from:    Compiled sources

I have a vertical panel with the task manager plasmoid, with "Show only minimized" to the right of my screen. The "Magic Lamp" animation moves correctly to the right, but the animation doesn't look anything like a magic lamp. This is very obvious when animation speed is lowered to "Extremely Slow".

Steps to reproduce:
1) Create a vertical panel on the right edge of the screen.
2) Add a task manager plasmoid to it.
3) Activate Magic Lamp minimize animation.
4) Minimize a window.
Comment 1 Roman K. 2009-06-03 23:07:32 UTC
I have this problem, too. But windows don't always minimize wrong for me, only if their width is big enough, ca. 1290 pixel. if the width is smaller, then everything looks fine.
Comment 2 Bart Cerneels 2009-08-05 14:17:59 UTC
Still occurs in 4.3.

Minimize always seems to go down, with the middle of the bottom edge "falling" first.
I couldn't not determine if the width of the windows has any effect.
The maximize animation is correct.
Comment 3 Roman K. 2009-08-06 11:11:20 UTC
http://dl.getdropbox.com/u/1272051/out.mpg

I hope that you can see how the effect looks like in this video. When the width of the window is wide enough, the effect looks wrong. 

First the width is small enough, the effect looks how it should. Then I resize the window an minimize it, and the effect looks wrong.
Comment 4 Bart Cerneels 2009-08-06 11:49:13 UTC
That certainly looks different than my problem.
I'll attach a video showing some minimize/maximize action.

Some details that might help:

I'm on a 64-bit system.
Vertical panel with taskmanager applet on the right, set to auto hide.
"Only show tasks that are minimized" option of task manager is enabled.

I've noticed that the maximize looks OK most of the time, it seems related with the panel being hidden or not. Yet switching the panel to "always show" has no influence.
Comment 5 Bart Cerneels 2009-08-06 12:09:44 UTC
The video: http://users.telenet.be/shanachie/files/kwin_magic-lamp_bug.mp4
Comment 6 Roman K. 2009-08-06 12:18:42 UTC
should I file a new bug or could these two wrong behaviours be related?
Comment 7 Martin Flöser 2009-08-06 12:32:22 UTC
(In reply to comment #6)
> should I file a new bug or could these two wrong behaviours be related?
Please don't file a second bug. I have not yet watched the videos but when I find the time to fix those issues I will of course try to fix all issues.
Comment 8 Cédric Bellegarde 2009-10-22 22:54:29 UTC
*** Bug 211483 has been marked as a duplicate of this bug. ***
Comment 9 Ben Morris 2010-01-08 14:25:13 UTC
I have a taskbar on a vertical panel and see the issues shown in both videos. The first, I see when minimising a sufficiently wide window.

I see the effect in the second video when minimising a window who's taskbar entry has been grouped with other windows from the same application.

I'm using KDE SC 4.3.4, and my panel is always visible.
Comment 10 Roman K. 2010-01-08 14:37:27 UTC
It still looks wrong with KDE 4.3.85 Beta 2 in opensuse
Comment 11 Ben Morris 2010-02-10 21:59:12 UTC
Problem is unchanged in KDE SC 4.4.0.
Comment 12 Martin Flöser 2011-01-24 17:43:42 UTC
*** Bug 264133 has been marked as a duplicate of this bug. ***
Comment 13 Amichai Rothman 2011-07-13 10:18:08 UTC
On KDE 4.6.5 (Kubuntu) I have the task panel placed on the top of the screen horizontally, and the lamp animation is broken there too - it looks like the top two corners of a window being minimized are being pulled correctly into the panel, but the bottom two corners are being pulled towards the bottom of the screen instead (where the panel would have been on a default installation). So basically half the window stretches upwards and half of it downwards. I see this on all windows of various sizes, although it's easier to see with smaller windows that are centered on the screen (since there's more travel space for the animation) and slow animation speed.

Strangely, I saw this happening a while back, possibly on KDE 4.6.3. Then it got fixed at some point, I think when I upgraded to KDE 4.6.4, and yesterday I upgraded to KDE 4.6.5 and the issue is back. I'm not 100% about the previous versions, but maybe this info can be useful to someone...

I don't know if this is caused by the same bug or not - I'd be happy to file a separate bug if necessary.
Comment 14 Amichai Rothman 2011-07-27 13:47:47 UTC
I just found that if I disable and then re-enable desktop effects (using the compositing state toggle tray icon widget), the issue no longer occurs and the animation is now correct. After a clean reboot, though, the issue surfaces once again. Maybe this will help the devs recreate and fix it...
Comment 15 Johannes Schmidt 2012-01-27 21:44:49 UTC
My various problems, among them this bug, with the magic lamp effect seem to be fixed in the KDE SC 4.8.0 release. Can anyone else verify this?
Comment 16 Amichai Rothman 2012-01-28 16:07:42 UTC
I haven't seen the issues with this effect for a while, I guess this was fixed at some point (maybe somewhere along the 4.7.x series)...
Comment 17 Ben Morris 2012-02-14 09:29:43 UTC
I just build 4.8.0, and I too can no longer reproduce this bug. 1600x900 display, if it's relevant.
Comment 18 Roman K. 2012-02-14 09:36:46 UTC
It is fixed for me, too. KDE 4.8.0, opensuse 12.1.
Comment 19 Vlad Zahorodnii 2018-06-05 20:02:05 UTC
Martin, shouldn't it be marked as resolved?
Comment 20 Martin Flöser 2018-06-05 20:07:32 UTC
Setting to fixed as per comments.