Bug 179198 - Last.fm plugin: Special characters in username are not supported
Summary: Last.fm plugin: Special characters in username are not supported
Status: RESOLVED UPSTREAM
Alias: None
Product: amarok
Classification: Applications
Component: Services/Last.fm (show other bugs)
Version: 2.3.1-GIT
Platform: Ubuntu Linux
: NOR normal
Target Milestone: 2.4.0
Assignee: Amarok Developers
URL:
Keywords:
: 243030 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-12-31 12:25 UTC by Fabian Potschies
Modified: 2011-05-07 09:38 UTC (History)
10 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Potschies 2008-12-31 12:25:45 UTC
Version:            (using KDE 4.1.3)
OS:                Linux
Installed from:    Ubuntu Packages

I'm using Amarok2.0. The only plugin loaded for Amarok is the above mentioned last.fm plugin. My username contains an equal sign (=) and although the Streams can be loaded and listened in Amarok no tracks are submitted to my account. To test my assumption i created another nickname without any symbols and with this one scrobbling works fine. I tried to replace the equal sign with the common HTML Expression = which didn't work neither. Password and username are definetly entered correct in the last.fm plugin.
Comment 1 Mark Kretschmann 2008-12-31 12:34:11 UTC
Ok, this could possibly be an encoding issue. Should be fixable.

We're CC'ing our Last.fm plugin creator Leo Franchi.
Comment 2 Leo Franchi 2009-01-04 01:48:11 UTC
thanks for the heads up. (this message is mostly to test my bugzilla settings).
Comment 3 Kevin Funk 2009-02-09 13:05:00 UTC
Still valid?
Comment 4 Fabian Potschies 2009-02-09 13:34:28 UTC
Yep, still doesn't work.
Comment 5 loizbec 2009-04-13 15:54:29 UTC
My screen name contains a '-' and it does not work for me either. The test login button in the configuration of the last.fm internet service does not return any result (success OR failure). I copied and pasted the password from Kate (both to login to last.fm on my browser and in amarok) and am therefore sure it is right.
Whereas I can access my radios (my screenname thus being taken into account by the service), no track is added to my profile neither last.fm radio tracks nor collection tracks.
Comment 6 loizbec 2009-04-13 16:02:45 UTC
Forgot to mention my software versions :
kubuntu 9.04 Beta (w/ KDE 4.2.2)
amarok : 2.0.2
last.fm service : Version 1.0

NB: Added kde@dontletsstart.com (Shane King, author of the service according to last.fm service nfo) in the list of CCs, I hope I was not mistaken.
Comment 7 Myriam Schweingruber 2009-04-24 12:48:23 UTC
@Leo: any news on this? As it has been reported by two users, I switch this to 'new'. Is this still happening with the latest changes in SVN?
Comment 8 loizbec 2009-05-06 19:09:31 UTC
(In reply to comment #7)
> @Leo: any news on this? As it has been reported by two users, I switch this to
> 'new'. Is this still happening with the latest changes in SVN?

I have just re-installed Linux (3 days ago), switching to Xubuntu (my computer is kind of slow) I installed Amarok's latest version, made all the updates available, and I still get the same error.
Comment 9 Peco Danajlovski 2009-05-21 20:07:25 UTC
I am using nightly amarok build from SVN and I can confirm the problem with the exception that it is present only for scrobbled songs but if I mark a song as "Loved" it passes immidiately. As I can see from the amarok logs it seems that it sends 4 requests to the web service and one of them is failing to authenticate.

amarok(5875)/kio (Slave) KIO::Slave::createSlave: createSlave "http" for KUrl("http://ws.audioscrobbler.com/2.0/?api_key=402d3ca8e9bc9d3cf9b85e1202944ca5&method=user.getNeighbours&sk=&user=|Vortex|&api_sig=8a415495543b17ea1ee0f85f7e441c61")
amarok(5875)/kio (KIOConnection) KIO::ConnectionServer::listenForRemote: Listening on  "local:/home/vortex/.amarok-nightly/tmp/ksocket-vortex/amarokrL5875.slave-socket"
amarok(5875)/kio (Slave) KIO::Slave::createSlave: createSlave "http" for KUrl("http://ws.audioscrobbler.com/2.0/?api_key=402d3ca8e9bc9d3cf9b85e1202944ca5&method=user.getFriends&sk=&user=|Vortex|&api_sig=52d99ab750cd8aace4e1f72c979c462f")
amarok(5875)/kio (KIOConnection) KIO::ConnectionServer::listenForRemote: Listening on  "local:/home/vortex/.amarok-nightly/tmp/ksocket-vortex/amarokSm5875.slave-socket"
amarok(5875) KNetworkReply::setMimeType: "text/xml"
amarok(5875) ScrobblerHttp::createRequest: GetOperation:  QUrl( "http://post.audioscrobbler.com/?hs=true&p=1.2.1&c=ark&v=2.1-SVN&u=%7CVortex%7C&t=1242928239&a=898c058b2fbbb5eb46d9f2a5a97e0dba&api_key=402d3ca8e9bc9d3cf9b85e1202944ca5&sk=d030b27c6e8427ed29297a9b201ab124" )
HTTP GET "http://post.audioscrobbler.com/?hs=true&p=1.2.1&c=ark&v=2.1-SVN&u=%7CVortex%7C&t=1242928239&a=898c058b2fbbb5eb46d9f2a5a97e0dba&api_key=402d3ca8e9bc9d3cf9b85e1202944ca5&sk=d030b27c6e8427ed29297a9b201ab124"
amarok(5875) KNetworkAccessManager::createRequest: GetOperation:  QUrl( "http://ws.audioscrobbler.com/2.0/?api_key=402d3ca8e9bc9d3cf9b85e1202944ca5&method=user.getInfo&sk=d030b27c6e8427ed29297a9b201ab124&api_sig=94b182250c1ef1ca0fe2607c499c1181" )
amarok(5875)/kio (Slave) KIO::Slave::createSlave: createSlave "http" for KUrl("http://ws.audioscrobbler.com/2.0/?api_key=402d3ca8e9bc9d3cf9b85e1202944ca5&method=user.getInfo&sk=d030b27c6e8427ed29297a9b201ab124&api_sig=94b182250c1ef1ca0fe2607c499c1181")


amarok(5875) KNetworkReply::setMimeType: "text/xml"
amarok(5875) KNetworkReply::setMimeType: "text/xml"
amarok(5875) KNetworkReply::setMimeType: "text/plain"
"BADAUTH"
6
amarok(5875) KNetworkReply::setMimeType: "text/xml"

Also another thing that i've noticed is that one of the requests uses "%7CVortex%7C" instead of  |Vortex| so that's where it fails.

I hope I was of any help.
Comment 10 Peco Danajlovski 2009-06-09 23:11:39 UTC
I am sorry to bump this bug but I think it is easy one. Any progress?
Comment 11 Andrey Esin 2009-06-10 17:01:24 UTC
To Peco Danajlovski
Please try commit 979844, may be this will solve this problem.
Comment 12 Peco Danajlovski 2009-06-10 20:41:20 UTC
Just tried it, 979844 works for me. I am receiving "OK" instead of "BADAUTH 6" and the songs are submitted to Last.fm. 

Thanks.
Comment 13 Andrey Esin 2009-06-10 20:44:05 UTC
Wonderful.
We will wait some successful testing of this commit and we can close this bug.
Comment 14 Myriam Schweingruber 2009-08-02 13:30:24 UTC
Still waiting for somebody to confirm the fix, Anyone?
Comment 15 loizbec 2009-08-02 18:34:41 UTC
(In reply to comment #14)
> Still waiting for somebody to confirm the fix, Anyone?

It took me a few google queries to find out about svn and how to get amarok with it. I installed subversion through my package manager, then I tried to install amarok from svn, and it didn't work. My problem is I don't know which packages to install so that the script works. I lack kdialog : I'm using xubuntu, and not kubuntu. Last time I installed kde packages, I installed the whole deal (through dependences) and never found how to go back to my lightweight xubuntu (I once also changed from kde to gnome, by installing the wrong series of packages) and needed to reinstall my whole system (I'm sort of a linux newbie). I'm under a lot of pressure from work and can't possibly spend more time on this, therefore, I won't be able to fix this unless someone tells me how...
I'm really sorry I can't be of much help.
Comment 16 Kuba Serafinowski 2009-08-15 23:37:44 UTC
loizbec: please drop by #amarok on irc.freenode.net for help with compiling latest code or read this two things:

HowTo on Amarok: http://amarok.kde.org/blog/archives/1087-How-to-install-2.2-git-in-your-home-an-update.html

HowTo on GIT: http://techbase.kde.org/Getting_Started/Sources/KDE_git-tutorial

and help us close this bug by testing
Comment 17 loizbec 2009-08-16 01:24:49 UTC
I'll try to do that as soon as I finish my chapter (I am in the  
process of writing my PhD thesis and under quite bit of pressure),  
within a week or so. Since I'm running Xubuntu, I might be lacking  
some KDE library to compile. Do you have any heads up advices that  
would prevent me from accidentally replacing Xfce by KDE ? I  
accidentally replaced KDE by gnome once, I hope this does not make you  
pessimistic. On the bright side, if I manage to make this work, then  
this bug is officially definitely solved ;)
kind regards


Le 15 août 09 à 23:37, Kuba Serafinowski a écrit :

> https://bugs.kde.org/show_bug.cgi?id=179198
>
>
> Kuba Serafinowski <zizzfizzix@gmail.com> changed:
>
>           What    |Removed                     |Added
> ----------------------------------------------------------------------------
>             Status|NEW                         |NEEDSINFO
>                 CC|                            |zizzfizzix@gmail.com
>         Resolution|                            |WAITINGFORINFO
>
>
>
>
> --- Comment #16 from Kuba Serafinowski <zizzfizzix gmail com>   
> 2009-08-15 23:37:44 ---
> loizbec: please drop by #amarok on irc.freenode.net for help with  
> compiling
> latest code or read this two things:
>
> HowTo on Amarok:
> http://amarok.kde.org/blog/archives/1087-How-to-install-2.2-git-in-your-home-an-update.html
>
> HowTo on GIT: http://techbase.kde.org/Getting_Started/Sources/KDE_git-tutorial
>
> and help us close this bug by testing
>
> -- 
> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are a voter for the bug.
> You are on the CC list for the bug.


----
Mathieu Loiseau

"When copyright was invented, about three centuries ago, [copyright]  
was not perceived as anti-social, it was a publisher's weapon against  
competitors, not against the public. Nowadays, [...] copyright turned  
to a weapon shooting in the crowd." Wu Ming 1
(http://www.wumingfoundation.com/italiano/outtakes/copyleft_explained.html 
)
Comment 18 Edward Hades 2009-08-16 10:07:18 UTC
(In reply to comment #17)
Why don't you use Neon nightly builds? (http://amarok.kde.org/wiki/User:Apachelogger/Project_Neon)

They should resolve all dependencies automagically. Also, KDE and XFCE can perfectly live alongside together, so what you've done is probably changed the default session, not replaced XFCE with KDE. There should be nothing to be afraid of.
Comment 19 Myriam Schweingruber 2009-09-05 17:08:12 UTC
Closing for lack of feedback. Also this is most likely already fixed.

Mathieu, feel free to reopen if you come across this in Amarok 2.2 final, to be released in a few weeks.
Comment 20 Peco Danajlovski 2009-10-15 05:10:35 UTC
I just upgraded to Amarok 2.2. It reappeared again.
Comment 21 Peco Danajlovski 2009-10-17 14:12:59 UTC
Is someone to reopen this bug or should I file a make report for opening a new one?
Comment 22 Myriam Schweingruber 2009-10-17 15:23:34 UTC
Peco, I reopen it, this was closed because we didn't get any feedback since the fix. Leo?
Comment 23 Myriam Schweingruber 2009-11-04 00:27:57 UTC
Changing target.
Comment 24 Peco Danajlovski 2010-01-03 14:10:21 UTC
If this helps the bug is not present in 2.1, which means that it wasn't merged into 2.2. And please include it in 2.2.2, you already have the fix. Thanks.
Comment 25 Myriam Schweingruber 2010-02-19 09:29:47 UTC
Kevin, did you test that?
Comment 26 Peco Danajlovski 2010-03-16 17:40:45 UTC
I just upgraded to Amarok 2.3.0 (Ubuntu 9.10 through kubuntu backports), and unfortunately it's not fixed. I am getting the same BadAuth error mentioned couple of times before. Submitting loved tracks works so I guess the problem is not on last.fm's side.
Comment 27 Myriam Schweingruber 2010-03-16 20:00:04 UTC
(In reply to comment #26)
> I just upgraded to Amarok 2.3.0 (Ubuntu 9.10 through kubuntu backports), and
> unfortunately it's not fixed. I am getting the same BadAuth error mentioned
> couple of times before. Submitting loved tracks works so I guess the problem is
> not on last.fm's side.

Thank you for your feedback, reopening.
Comment 28 Mariusz Urbaniak 2010-06-28 14:45:50 UTC
I got the same problem. Amarok 1.4 worked well with special characters but after upgrading to 2.3.1 stopped scrobbling.
Comment 29 Myriam Schweingruber 2010-06-30 13:13:00 UTC
*** Bug 243030 has been marked as a duplicate of this bug. ***
Comment 30 Peco Danajlovski 2010-08-26 23:49:27 UTC
Is there a reason that this bug gets postponed for more than a year and a half? It was even fixed in 2.1, all you need to do is merge the fix...

I know this is not the place for this kind of comment and sorry if I sound nervous but I am getting a bit frustrated every time when I see this bug being pushed in the next branch. :)

I know you have a lot of work to do but please find time to fix this for 2.3.2 release. Lot of us who are still using 1.4 because of this will be grateful.

Thanks
Comment 31 Edward Hades 2010-09-20 12:14:25 UTC
I've just checked a username with dashes and it works (http://www.last.fm/user/test---)

Please test if you still have any trouble, and if so, what special characters are there in your username.
Comment 32 Myriam Schweingruber 2010-09-20 22:14:25 UTC
Setting status correctly.
Comment 33 Peco Danajlovski 2010-09-21 08:21:43 UTC
I am using the 'pipe' character in my username '|' and it still doesn't work for me. However the problem is present only for scrobbling and loving a track works without problem (and it works since 2.0). Scrobbling a track still returns "BADAUTH 6".
Comment 34 Myriam Schweingruber 2010-09-21 12:16:51 UTC
Thank you for the feedback.
Comment 35 Edward Hades 2010-09-22 11:42:42 UTC
Peco, thank you for the feedback. Unfortunately (or, maybe, fortunately) last.fm now forbids any special characters except dash (-) and underscore (_) in usernames, so I can not debug this personally.

Please check, if you are using latest liblastfm (it's version 0.3.0 now, if I am not mistaken).

Have you also tried to re-authenticate to lastfm in service settings?
Comment 36 Peco Danajlovski 2010-10-02 12:24:40 UTC
I am using that version of liblastfm (0.3.0) and reauthentication doesn't help the problem.

However as I stated previously the problem is not present when using 'love track' feature, so may guess would be that there is some difference in the way how web service for scrobbling is invoked.
Comment 37 Mariusz Urbaniak 2010-10-27 15:17:55 UTC
Still nothing (2.3.2). In my case username starts and ends with "-=".
Comment 38 Edward Hades 2011-02-01 20:40:13 UTC
Mariusz, Peco, do you by any chance have non-Latin characters in your usernames?
Comment 39 Peco Danajlovski 2011-03-12 11:58:36 UTC
@Edward: yes, my username is |Vortex|

I will repeat again, Amarok connects with last.fm, option "love track" works, the only thing that doesn't work is submitting the songs. What is the difference between "love track" and "submit song" methods? Is it possible that they have different implementations? 

I am still using Amarok 1.4 because of this glitch. :)
Comment 40 Myriam Schweingruber 2011-05-07 09:38:30 UTC
Peco, I think this is due to the new last.fm API which Amarok 2.x uses. You can either use Clementine (if they didn't adapt the API I can't tell) or report this upstream to last.fm. Sadly there is nothing we can do here.