Bug 178855 - rich text editor mostly broken/bad behavior
Summary: rich text editor mostly broken/bad behavior
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Unmaintained
Component: Chat Window (show other bugs)
Version: unspecified
Platform: Compiled Sources Unspecified
: NOR normal
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-27 03:51 UTC by Benson Tsai
Modified: 2009-03-27 05:06 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
addresses the issues above (3.07 KB, patch)
2008-12-27 03:55 UTC, Benson Tsai
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Benson Tsai 2008-12-27 03:51:43 UTC
Version:            (using Devel)
Installed from:    Compiled sources

First of all, when you choose a new font style (whether it be simply bolding or changing font altogether) and _then_ (as in after) highlight text, the highlighted text will be changed into the new fold style. I believe that this is absolutely broken behavior.

Also, I feel like if the user types in some text, goes back and highlights text, then changes the font of the highlighted text, the user does not mean to change the default font instead just the bit of text highlighted itself. The only exception I can see to this is if the user highlights _all_ of the text and changes the style.

Lastly, the bold/italics/underline shortcuts are broken.
Comment 1 Benson Tsai 2008-12-27 03:55:13 UTC
Created attachment 29660 [details]
addresses the issues above

This patch enables the shortcut keys for bold/italics/underline.

It also changes the behavior of the "default" font to be set only when either there is no text in the text box or if all of the text has been highlighted.

It also changes the "desired" font variable that floats around to be set to the font of the current cursor position.
Comment 2 Matt Rogers 2009-03-27 05:03:23 UTC
feel free to commit this and close the bug (if you haven't committed a variant of it with the new rich text editor stuff already)