Bug 178611 - Cube desktop not paint in the right location the cube reflection effect
Summary: Cube desktop not paint in the right location the cube reflection effect
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: compositing (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
: 193019 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-12-23 22:48 UTC by Javier G.
Modified: 2009-05-17 18:05 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
cube reflection painted on the wrong place (166.84 KB, image/jpeg)
2008-12-23 23:15 UTC, Javier G.
Details
Compiz example of a cube reflection (93.91 KB, image/png)
2008-12-23 23:17 UTC, Javier G.
Details
Move reflection down to touch the cube in its lowest point. (1.89 KB, patch)
2009-01-11 13:21 UTC, Michal Srb
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Javier G. 2008-12-23 22:48:21 UTC
Version:            (using Devel)
OS:                Linux
Installed from:    Compiled sources

Reflection effect of the "Cube desktop" isn't painted in the right location of the screen, it should be painted only to touch borders of the cube and the reflected cube (like a mirror effect) but currently real cube is painted over the reflected cube.
Comment 1 Javier G. 2008-12-23 23:15:19 UTC
Created attachment 29589 [details]
cube reflection painted on the wrong place

Here is an example of how I see the cube reflection.
Comment 2 Javier G. 2008-12-23 23:17:51 UTC
Created attachment 29590 [details]
Compiz example of a cube reflection

This is an example of how should be painted rightly the cube reflection, only touching the borders of the real cube.
Comment 3 Javier G. 2008-12-23 23:23:44 UTC
I'm sorry, I forget to include in the first message what version I'm using of KDE:

$kde4-config --version
Qt: 4.4.3
KDE: 4.1.85 (KDE 4.1.85 (KDE 4.2 Beta2))
kde4-config: 1.0
Comment 4 Martin Flöser 2009-01-04 20:28:43 UTC
If I remember correctly compiz fusion has several "reflection modes".
Comment 5 Michal Srb 2009-01-11 13:21:13 UTC
Created attachment 30126 [details]
Move reflection down to touch the cube in its lowest point.

This patch moves reflection down to touch the cube in its lowest point.
It works with any number of desktops.

Variables addedHeightCoeff1 and addedHeightCoeff2 should be re-counted only when numberOfDesktops, width or height of desktop changes, but I don't know how to do it. So they are re-counted every paintScreen.
Comment 6 Martin Flöser 2009-01-11 13:37:28 UTC
Thanks for the patch. I am currently working on cube and the way reflection is done will probably change for 4.3, so I can't say yet if the patch can be used.
Comment 7 Martin Flöser 2009-05-01 20:23:54 UTC
SVN commit 962205 by graesslin:

New cube reflection which moves reflection down to touch the cube in its lowest point. Thanks to Michal Srb for the patch. It' really great.

There are two small todos: when mixing manual (mouse) rotation with cursor key rotation or zooming the reflection becomes wrong.
FEATURE: 178611

 M  +15 -1     cube.cpp  
 M  +3 -0      cube.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=962205
Comment 8 Martin Flöser 2009-05-17 18:05:42 UTC
*** Bug 193019 has been marked as a duplicate of this bug. ***