Bug 178445 - only show project relevant kcm's in the project config dialog
Summary: only show project relevant kcm's in the project config dialog
Status: RESOLVED FIXED
Alias: None
Product: kdevplatform
Classification: Developer tools
Component: shell (show other bugs)
Version: git master
Platform: Compiled Sources Linux
: HI major
Target Milestone: 1.0.0
Assignee: kdevelop-bugs-null
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-22 11:28 UTC by András Manţia
Modified: 2010-08-29 22:13 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description András Manţia 2008-12-22 11:28:16 UTC
I get a QMake page in the CMake project configuration dialog, which I doubt it belongs there. :)
Comment 1 Andreas Pakulat 2008-12-22 12:17:33 UTC
The problem is more general: KCM's simply don't allows us to specify exactly which ones to load and which we don't want to load. At least last I tried this didn't work as we wanted it to work.

So the only solution I see right now is writing our framework for the project configuration and dropping KCM's (or maybe we can even integrate them).

However I don't see this happening anytime soon.
Comment 2 Andreas Pakulat 2009-07-22 16:16:25 UTC
SVN commit 1001036 by apaku:

Properly unload toolviews when the plugin is unloaded
CCBUG:178445


 M  +6 -0      cvs/cvsplugin.cpp  
 M  +2 -0      cvs/cvsplugin.h  
 M  +6 -0      git/gitplugin.cpp  
 M  +2 -0      git/gitplugin.h  
 M  +7 -0      mercurial/mercurialplugin.cpp  
 M  +2 -0      mercurial/mercurialplugin.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1001036
Comment 3 Andreas Pakulat 2009-07-22 16:16:25 UTC
SVN commit 1001037 by apaku:

Properly unload toolviews when the plugin is unloaded.
BUG:178445

 M  +18 -9     gdb/debuggerplugin.cpp  
 M  +7 -0      gdb/debuggerplugin.h  
 M  +8 -3      valgrind/valgrindplugin.cpp  
 M  +3 -0      valgrind/valgrindplugin.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1001037
Comment 4 Andreas Pakulat 2010-08-29 22:09:50 UTC
commit d9b26d7228a826263dce4d1696e08e74eae297a3
Author: Andreas Pakulat <apaku@gmx.de>
Date:   Wed Jul 22 14:15:56 2009 +0000

    Properly unload toolviews when the plugin is unloaded
    CCBUG:178445

diff --git a/gitplugin.cpp b/gitplugin.cpp
index 02fc821..17c8ee7 100644
--- a/gitplugin.cpp
+++ b/gitplugin.cpp
@@ -65,6 +65,12 @@ GitPlugin::~GitPlugin()
 }
 
 
+void GitPlugin::unload()
+{
+    core()->uiController()->removeToolView( dvcsViewFactory() );
+}
+
+
 QString GitPlugin::name() const
 {
     return QLatin1String("Git");
diff --git a/gitplugin.h b/gitplugin.h
index 1ab5a13..081a4f0 100644
--- a/gitplugin.h
+++ b/gitplugin.h
@@ -49,6 +49,8 @@ class GitPlugin: public KDevelop::DistributedVersionControlPlugin
 public:
     GitPlugin(QObject *parent, const QVariantList & args = QVariantList() );
     ~GitPlugin();
+   
+    virtual void unload();
 
     QString name() const;
Comment 5 Andreas Pakulat 2010-08-29 22:13:51 UTC
commit d9b26d7228a826263dce4d1696e08e74eae297a3
Author: Andreas Pakulat <apaku@gmx.de>
Date:   Wed Jul 22 14:15:56 2009 +0000

    Properly unload toolviews when the plugin is unloaded
    CCBUG:178445

diff --git a/gitplugin.cpp b/gitplugin.cpp
index 02fc821..17c8ee7 100644
--- a/gitplugin.cpp
+++ b/gitplugin.cpp
@@ -65,6 +65,12 @@ GitPlugin::~GitPlugin()
 }
 
 
+void GitPlugin::unload()
+{
+    core()->uiController()->removeToolView( dvcsViewFactory() );
+}
+
+
 QString GitPlugin::name() const
 {
     return QLatin1String("Git");
diff --git a/gitplugin.h b/gitplugin.h
index 1ab5a13..081a4f0 100644
--- a/gitplugin.h
+++ b/gitplugin.h
@@ -49,6 +49,8 @@ class GitPlugin: public KDevelop::DistributedVersionControlPlugin
 public:
     GitPlugin(QObject *parent, const QVariantList & args = QVariantList() );
     ~GitPlugin();
+   
+    virtual void unload();
 
     QString name() const;