Bug 178382 - Many and duplicate top level menu entries
Summary: Many and duplicate top level menu entries
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-Menus (show other bugs)
Version: 0.10.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-21 17:13 UTC by Martin Schmettow
Modified: 2017-07-29 06:22 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 0.10.0
Sentry Crash Report:


Attachments
problem in KDE3 (107.32 KB, image/png)
2008-12-28 11:11 UTC, Andi Clemens
Details
problem in KDE4 (466.21 KB, image/png)
2008-12-28 11:12 UTC, Andi Clemens
Details
updated ui.rc (130.40 KB, image/png)
2008-12-28 12:04 UTC, Andi Clemens
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Schmettow 2008-12-21 17:13:26 UTC
Version:           digikam-0.10.0b7 (using Devel)
OS:                Linux
Installed from:    Compiled sources

When in album view mode I see 14 menu entries, which is too much. On a small screen the right most even get hidden. Additionally, some menu entries appear twice (but are different in sub entries):
in Album mode: Edit (German: Bearbeiten)
in Edit mode: File (German: Datei)
Comment 1 caulier.gilles 2008-12-22 14:07:11 UTC
I don't understand exactly. please take a screenshot.

Gilles Caulier
Comment 2 caulier.gilles 2008-12-22 14:09:14 UTC
Martin,

It's duplicates of #177057 ?

Gilles Caulier
Comment 3 Andi Clemens 2008-12-28 11:11:05 UTC
I am not sure if this or the bug in 177057 is a downstream bug. I just updated to KDE unstable (a daily SVN snapshot repository) on Archlinux and now my menu is broken, too.
I removed digikamrc and digikamui files, but it doesn't help. Also the "Find Duplicates" action can be found in the menu now.
Comment 4 Andi Clemens 2008-12-28 11:11:43 UTC
Created attachment 29688 [details]
problem in KDE3

taken from a KDE3 session
Comment 5 Andi Clemens 2008-12-28 11:12:34 UTC
Created attachment 29689 [details]
problem in KDE4

taken from an completely new KDE4 user and session
Comment 6 Andi Clemens 2008-12-28 11:13:46 UTC
I just want to mention that all my other KDE4 apps are working fine, only digiKam shows this strange behavior.
Note: "Find Duplicates" can be found in the Edit-menu now, this is very strange.

Andi
Comment 7 Andi Clemens 2008-12-28 11:15:00 UTC
(In reply to comment #3)
> Also the "Find Duplicates" action can be found in the menu now.

in the toolbar...
Comment 8 Andi Clemens 2008-12-28 12:04:27 UTC
Created attachment 29692 [details]
updated ui.rc

I removed every action from the digikamui.rc file, so that only the pure skeleton of the file remained.
As you can see, everything is gone, but "Find Duplicates" is still visible in the menu and toolbar.
How is this possible?

After running updatedb I'm pretty sure there is only one digikamui.rc file left on my system:
/usr/share/apps/digikam/digikamui.rc

So there is no chance that a messed up digikamui.rc file is left somewhere else.

Andi
Comment 9 Marcel Wiesweg 2008-12-30 00:05:13 UTC
File/Edit/View/Settings/Help looks like a standard KDE menu structure.
The Find Duplicates is pretty interesting. You could grep your system KDE share directory (/usr/share/kde4 for me) and you ~/.kde4 for occurrences of "find_duplicates". You could also try what happens if you change this action's name in digikamapp.cpp: If it disappears then, there is something about this name that causes your problem.
Comment 10 Andi Clemens 2008-12-30 01:16:30 UTC
I grepped over

/usr/share/kde4
and
~/.kde4
but nothing.

Only in /usr/share/apps I find this entry (in the digikamui.rc file that is copied when installing from sources).

I really don't understand this. I thought that maybe the config is mixed somehow with the one from KDE3, but I removed digikam 0.9.x and the problem remains. This is weird.

I'll try to rename this, but even if the find_duplicates action goes away, the problem with the duplicate menu entries still exists.

Andi
Comment 11 Andi Clemens 2008-12-30 01:25:33 UTC
I renamed the action to a completely different name ("what_is_wronghere"), still the same issue.
I have no clue what to do about this anymore.
Comment 12 Mikolaj Machowski 2008-12-30 01:38:46 UTC
 Don't know if this is significant but I noticed that duplicate entries have different accel letters.
Comment 13 Andi Clemens 2008-12-30 02:56:27 UTC
SVN commit 903155 by aclemens:

We can't use KStandardAction::Find for three different actions here, it
will mess up the menus and toolbars. Also we need to call
KStandardAction::find(), not ::Find() to customize the standard action,
otherwise we will have duplicate menu entries and the action will appear
in the toolbar.

Gilles, Marcel,

simple search is not focusing / switching to the "search tab" on the left automatically,
so this action is not very useful if the "advanced search" tab is
closed or not displayed at all. It only works if the tab is already
opened.
I think we need to focus the tab automatically, like when using the "Find
similar" action.

CCBUG:178382

 M  +9 -12     digikamapp.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=903155
Comment 14 Andi Clemens 2008-12-30 02:56:31 UTC
SVN commit 903156 by aclemens:

Overwrite KStandardActions to avoid duplicate menu entries

CCBUG:178382

++

 M  +6 -6      digikamapp.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=903156
Comment 15 Andi Clemens 2008-12-30 02:58:28 UTC
The main problem should be fixed now.

Martin,

can you checkout latest SVN trunk and see if everything is fine?

Andi
Comment 16 Martin Schmettow 2009-01-01 14:11:38 UTC
Hi,

this seems to be partly fixed. The menu entries in album view are now as expected. The top level entry "File" in Edit mode remains duplicate. The first only has "Close" as an entry.The second has the expected entries (navigation, savin, etc.) 
Comment 17 Andi Clemens 2009-01-01 14:19:21 UTC
Right, I just checked the main app for those errors. I will go through everything now, LightTable, Editor, showFoto, CameraUI etc... thanks for the hint.

Andi
Comment 18 Andi Clemens 2009-01-01 14:57:18 UTC
Martin,

I commited changes to EditorWindow, LightTable and CameraUI right now. I hope I didn't forgot another window :-)
Can you test it?

Andi
Comment 19 Andi Clemens 2009-01-03 11:33:27 UTC
Martin,

I will close this one now. I think everything should be fixed. If not, feel free to re-open it again.

Andi
Comment 20 Martin Schmettow 2009-01-03 14:17:03 UTC
Checked the SVN version of 09/02/01. Indeed, the bug is resolved.