Bug 177815 - confused and overlapped icons in krunner
Summary: confused and overlapped icons in krunner
Status: RESOLVED FIXED
Alias: None
Product: krunner
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
: 176819 180436 180510 180848 183663 183871 184056 185007 186713 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-12-15 01:11 UTC by David Johnson
Modified: 2009-03-27 18:33 UTC (History)
23 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
krunner after typing "konq" (38.59 KB, image/png)
2008-12-15 01:12 UTC, David Johnson
Details
krunner after typing "kcalc" (27.61 KB, image/png)
2008-12-15 01:12 UTC, David Johnson
Details
KRunner with KTorren and OpenOffice.org overlaps (25.01 KB, image/png)
2009-01-27 02:05 UTC, Jeffrey
Details
krunner after typing kate (24.21 KB, image/png)
2009-02-02 06:49 UTC, Unknown
Details
proposed patch (1.29 KB, patch)
2009-02-07 02:09 UTC, Luca Gugelmann
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Johnson 2008-12-15 01:11:50 UTC
Version:            (using Devel)
Compiler:          4.3.2 
OS:                Linux
Installed from:    Compiled sources

See attached screenshots. First shot "konq" was typed, but five different icons appeared, three of which seem to be irrelevant. More serious is the second screenshot, which shows overlapping icons.

Besides uncluttering the icons, I think some usability gains can be made by only turning on a few of the runners by default.
Comment 1 David Johnson 2008-12-15 01:12:32 UTC
Created attachment 29345 [details]
krunner after typing "konq"
Comment 2 David Johnson 2008-12-15 01:12:57 UTC
Created attachment 29346 [details]
krunner after typing "kcalc"
Comment 3 Aaron J. Seigo 2008-12-15 17:06:36 UTC
for some reason, which i haven't tracked down yet, it seems that sometimes some icons get "forgotten" about and so sort of just hang about. this causes the problem you're seeing.

"I think some usability gains can be made by only turning on a few of the runners by default"

that obviously doesn't make much sense, as the entire point of krunner is provide possible matches.
Comment 4 FiNeX 2008-12-20 21:01:59 UTC
*** Bug 176819 has been marked as a duplicate of this bug. ***
Comment 5 Joseph Tate 2009-01-01 06:05:30 UTC
I still see this in KDE 4.2 beta 2.  Makes krunner nearly useless as a search tool.  I note that the "forgotten" icons are faded as if they were supposed to be animated away.  Also I note that the window doesn't shrink down.

This didn't happen with KDE 4.1.
Comment 6 Dario Andres 2009-01-12 11:29:08 UTC
*** Bug 180436 has been marked as a duplicate of this bug. ***
Comment 7 Nicolas L. 2009-01-13 08:31:13 UTC
*** Bug 180510 has been marked as a duplicate of this bug. ***
Comment 8 Nicolas L. 2009-01-13 08:31:42 UTC
confirming on kde 4.2 Beta2 too
Comment 9 Roman K. 2009-01-14 00:22:25 UTC
I can confirm this with openSUSE packages version 4.1.87.
Comment 10 Ben Boeckel 2009-01-14 10:17:04 UTC
I still see this occasionally in 4.1.96 (rc1). One way (only that I've found) to clean it is to exit krunner and restart it. Haven't been able to figure out what the trigger is for it though.
Comment 11 Dario Andres 2009-01-15 22:51:28 UTC
*** Bug 180848 has been marked as a duplicate of this bug. ***
Comment 12 Jeffrey 2009-01-27 02:05:16 UTC
Created attachment 30655 [details]
KRunner with KTorren and OpenOffice.org overlaps

Some times the [Enter] key will actually select the icon that appears which has zero relation to what I have typed.
Comment 13 Jeffrey 2009-01-27 02:06:54 UTC
This happens to me also in KDE 4.2rc on Debian Sid/Experimental from
deb http://kde42.debian.net/debian/ UNRELEASED main
Comment 14 Neil Skrypuch 2009-02-02 02:58:59 UTC
I can confirm this, I'm seeing the issue pretty frequently with krunner in KDE 4.2.
Comment 15 Unknown 2009-02-02 06:49:57 UTC
Created attachment 30850 [details]
krunner after typing kate

I am also confirming the same in KRunner (Run Command Interface: 0.1), KDE 4.2.00 in Ubuntu 8.10.

Thanks a lot...
Comment 16 AhmedG 2009-02-02 22:26:24 UTC
I have seen this across multiple distros. Please ask if you need more information.
Comment 17 Luca Gugelmann 2009-02-07 02:08:07 UTC
I think I found the cause for this bug. It is a race condition in workspace/krunner/interfaces/default/resultitem.cpp. 

As I understand it, if the ResultItem is remove()d while there is a call to animationComplete pending then the item is not properly deleted. The reason is that remove() starts an animation and connects the finished() signal of that animation to deleteLater(). In theory this animation should just run through and at the end cause the item to delete itself. The problem arises if before the end of the animation the pending call to animationComplete() is made: this function simply deletes the _current_ animation (which is the new one and not the one which caused animationComplete to be called in the first place) and therefore prevents the remove() animation from ever signaling finished() and therefore deleting the ResultItem.

Long story short, the attached stop-gap style patch fixes the problem for me.
Comment 18 Luca Gugelmann 2009-02-07 02:09:07 UTC
Created attachment 31062 [details]
proposed patch
Comment 19 Sebastian Strand 2009-02-07 14:02:41 UTC
Just tested the patch and it appears to work fine. I was experiencing this issue on pretty much every use of krunner, but I have not been able to reproduce it after applying the patch.
Comment 20 Dario Andres 2009-02-08 13:25:29 UTC
*** Bug 183663 has been marked as a duplicate of this bug. ***
Comment 21 Marco Martin 2009-02-08 16:41:59 UTC
Luca Gugelmann: the patch seems to make sense: can you commit?
Comment 22 Anne-Marie Mahfouf 2009-02-08 17:22:42 UTC
Fixed with Luca's patch, thanks a lot Luca!
See http://lists.kde.org/?l=kde-commits&m=123410970515259&w=2 for the reference commit.
Comment 23 Luca Gugelmann 2009-02-08 17:31:54 UTC
SVN commit 923352 by gugelmann:

CCBUG:177815
Fixes confused and overlapped icons in krunner which are sometimes left over
from previous queries. (backport from trunk.)


 M  +9 -4      resultitem.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=923352
Comment 24 Dario Andres 2009-02-10 14:09:17 UTC
*** Bug 183871 has been marked as a duplicate of this bug. ***
Comment 25 Dario Andres 2009-02-12 00:14:16 UTC
*** Bug 184056 has been marked as a duplicate of this bug. ***
Comment 26 FiNeX 2009-02-20 20:13:45 UTC
*** Bug 185007 has been marked as a duplicate of this bug. ***
Comment 27 Dario Andres 2009-03-27 18:33:10 UTC
*** Bug 186713 has been marked as a duplicate of this bug. ***