Bug 177738 - history navigation keys should be in toolbar
Summary: history navigation keys should be in toolbar
Status: RESOLVED INTENTIONAL
Alias: None
Product: kcharselect
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Unspecified
: NOR normal
Target Milestone: ---
Assignee: Bryce Nesbitt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-14 00:13 UTC by Stefan Majewsky
Modified: 2016-07-26 14:15 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Majewsky 2008-12-14 00:13:42 UTC
Version:            (using Devel)
Installed from:    Compiled sources

The navigation keys for the character history should not be in the KCharSelect widget, but in the application's toolbar. In the current state, it is not immediately clear what these buttons stand for, and, from the semantic point of view, they are grouped with the content, not with the actions.
Comment 1 Daniel Laidig 2008-12-14 02:52:50 UTC
With my comment in bug 177734 that there should be no toolbar at all, do you think it's still worth having these two buttons in a toolbar?

My thoughts:
* A toolbar with two buttons also looks strange. (I really don't want to have the find action there.)
* You can get the meaning of the buttons using the tooltips.
* The actual KCharSelect is a widget in kdelibs and the tool in kdeutils is just a small wrapper. Removing buttons from the actual widget and adding them in the toolbar would be possible with some effort, but I'm not sure whether I like the idea of having different UI layouts for KCharSelect-the-widget and KCharSelect-the-application.
* At the moment (without a toolbar) I don't think that the actions are "grouped with the content". They are right before the category dropdowns, so they are rather grouped with other navigational tools.
Comment 2 FiNeX 2008-12-16 18:37:57 UTC
I suggest to remove them completely. Moreover the current label doesn't explain that are used to go to the next/prev char selected on the "history".
Comment 3 Daniel Laidig 2008-12-16 19:31:02 UTC
So you want to suggest removing the history feature completely? That would be bad, as it was something introduced by Constantin Berzan for 4.2 and in my opinion it's quite a neat feature.

As for the tooltips, I agree that something like "Next Character in History" would proably be a good idea. However, because of the string freeze this would have to wait for 4.3.
Comment 4 FiNeX 2008-12-16 20:07:18 UTC
The feature is nice, but, for my personal usecases it us unneeded. Maybe for other users it could be useful :-)

About the string, don't forget it, maybe a TODO could be added :-)
Comment 5 Constantin Berzan 2009-03-02 21:47:27 UTC
SVN commit 934355 by cberzan:

Make it clear in the tooltips that the back and forward buttons refer to going back and forth in history.
CCBUG: 177738


 M  +4 -4      kcharselect.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=934355
Comment 6 Christoph Feck 2016-07-26 14:15:16 UTC
This will not be changed, mostly because of comment #1 point 3.